PopupContent::shouldDisplayValue() - Code Metrics - Inspection of "Put popup formatting code into dedicated class" - JeroenDeDauw/Maps - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — cargo ( d35b5e...08c93e )

by Jeroen De

created 2020-04-12 04:32 UTC

PopupContent::shouldDisplayValue() A

↳ Parent: PopupContent

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	11
rs	9.9
c	0
b	0
f	0
cc	2
nc	2
nop	2

<?php

declare( strict_types = 1 );

namespace Maps\Map\CargoFormat;

class PopupContent {

	private $titleHtml;
	private $propertyValues;

	/**
	 * @param string $titleHtml
	 * @param string[] $propertyValues
	 */
	public function __construct( string $titleHtml, array $propertyValues ) {
		$this->titleHtml = $titleHtml;
		$this->propertyValues = $propertyValues;
	}

	public function getHtml(): string {
		$valueList = $this->getPropertyValueList();
		$separator = $this->titleHtml === '' || $valueList === '' ? '' : '<br>';

		return '<h3>' . $this->titleHtml . '</h3>' . $separator . $valueList;
	}

	private function getPropertyValueList(): string {
		$lines = [];

		foreach ( $this->propertyValues as $name => $value ) {
			$lines[] = $this->bold( $name ) . ': ' . $value;
		}

		return implode( '<br>', $lines );
	}

	private function bold( string $html ): string {
		return '<strong>' . $html . '</strong>';
	}

	private function shouldDisplayValue( string $name, array $coordinateFields ): bool {

		$hiddenFields = [];

		foreach ( $coordinateFields as $field ) {
			$hiddenFields[] = $field;
			$hiddenFields[] = $field . '  lat';
			$hiddenFields[] = $field . '  lon';
		}

		return !in_array( $name, $hiddenFields );
	}

}


1			<?php
2
3			declare( strict_types = 1 );
4
5			namespace Maps\Map\CargoFormat;
6
7			class PopupContent {
8
9			private $titleHtml;
10			private $propertyValues;
11
12			/**
13			* @param string $titleHtml
14			* @param string[] $propertyValues
15			*/
16			public function __construct( string $titleHtml, array $propertyValues ) {
17			$this->titleHtml = $titleHtml;
18			$this->propertyValues = $propertyValues;
19			}
20
21			public function getHtml(): string {
22			$valueList = $this->getPropertyValueList();
23			$separator = $this->titleHtml === '' \|\| $valueList === '' ? '' : '<br>';
24
25			return '<h3>' . $this->titleHtml . '</h3>' . $separator . $valueList;
26			}
27
28			private function getPropertyValueList(): string {
29			$lines = [];
30
31			foreach ( $this->propertyValues as $name => $value ) {
32			$lines[] = $this->bold( $name ) . ': ' . $value;
33			}
34
35			return implode( '<br>', $lines );
36			}
37
38			private function bold( string $html ): string {
39			return '<strong>' . $html . '</strong>';
40			}
41
42			private function shouldDisplayValue( string $name, array $coordinateFields ): bool {
			0 ignored issues – show Unused Code introduced 2020-04-12 04:38 UTC by Report Bug Copy Issue Report This method is not used, and could be removed. Loading history...
43			$hiddenFields = [];
44
45			foreach ( $coordinateFields as $field ) {
46			$hiddenFields[] = $field;
47			$hiddenFields[] = $field . ' lat';
48			$hiddenFields[] = $field . ' lon';
49			}
50
51			return !in_array( $name, $hiddenFields );
52			}
53
54			}
55

JeroenDeDauw / Maps

Push — cargo ( d35b5e...08c93e )

PopupContent::shouldDisplayValue() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like