MapsGeodistance - Code Metrics - Inspection of "Remove dumb geocoding related settings" - JeroenDeDauw/Maps - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — rmds ( 34c84e )

by Jeroen De

created 2017-09-28 11:42 UTC

MapsGeodistance A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	107
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Test Coverage

Coverage

92.31%

Importance

Changes

Metric	Value
wmc	6
lcom	0
cbo	3
dl	0
loc	107
ccs	24
cts	26
cp	0.9231
rs	10
c	0
b	0
f	0

5 Methods

Rating	Name	Size	Complexity
A	getName()	3	1
B	getParameterInfo()	35	2
A	getDefaultParameters()	3	1
A	render()	13	1
A	getMessage()	3	1

<?php

/**
 * Class for the 'geodistance' parser hooks, which can
 * calculate the geographical distance between two points.
 * 
 * @since 0.7
 * 
 * @licence GNU GPL v2+
 * @author Jeroen De Dauw < [email protected] >
 */
class MapsGeodistance extends ParserHook {


	/**
	 * Gets the name of the parser hook.
	 * @see ParserHook::getName
	 * 
	 * @since 0.7
	 * 
	 * @return string
	 */
	protected function getName() {
		return 'geodistance';
	}
	
	/**
	 * Returns an array containing the parameter info.
	 * @see ParserHook::getParameterInfo
	 * 
	 * @since 0.7
	 * 
	 * @return array
	 */
	protected function getParameterInfo( $type ) {
		global $egMapsDistanceUnit, $egMapsDistanceDecimals;
		
		$params = [];

		$params['unit'] = [
			'default' => $egMapsDistanceUnit,
			'values' => MapsDistanceParser::getUnits(),
		];

		$params['decimals'] = [
			'type' => 'integer',
			'default' => $egMapsDistanceDecimals,
		];

		$params['location1'] = [
			'type' => 'mapslocation', // FIXME: geoservice is not used
			'aliases' => 'from',
		];

		$params['location2'] = [
			'type' => 'mapslocation', // FIXME: geoservice is not used
			'aliases' => 'to',
		];

		// Give grep a chance to find the usages:
		// maps-geodistance-par-mappingservice, maps-geodistance-par-geoservice,
		// maps-geodistance-par-unit, maps-geodistance-par-decimals,
		// maps-geodistance-par-location1, maps-geodistance-par-location2
		foreach ( $params as $name => &$param ) {
			$param['message'] = 'maps-geodistance-par-' . $name;
		}

		return $params;
	}
	
	/**
	 * Returns the list of default parameters.
	 * @see ParserHook::getDefaultParameters
	 * 
	 * @since 0.7
	 *
	 * @param $type
	 * 
	 * @return array
	 */
	protected function getDefaultParameters( $type ) {
		return [ 'location1', 'location2', 'unit', 'decimals' ];
	}
	
	/**
	 * Renders and returns the output.
	 * @see ParserHook::render
	 * 
	 * @since 0.7
	 * 
	 * @param array $parameters
	 * 
	 * @return string
	 * @throws MWException
	 */
	public function render( array $parameters ) {
		/**
		 * @var \DataValues\LatLongValue $coordinates1
		 * @var \DataValues\LatLongValue $coordinates2
		 */
		$coordinates1 = $parameters['location1']->getCoordinates();
		$coordinates2 = $parameters['location2']->getCoordinates();

		$distance = MapsGeoFunctions::calculateDistance( $coordinates1, $coordinates2 );
		$output = MapsDistanceParser::formatDistance( $distance, $parameters['unit'], $parameters['decimals'] );

		return $output;
	}

	/**
	 * @see ParserHook::getMessage
	 * 
	 * @since 1.0
	 */
	public function getMessage() {
		return 'maps-geodistance-description';
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
	}	
	
}

1		<?php
2
3		/**
4		* Class for the 'geodistance' parser hooks, which can
5		* calculate the geographical distance between two points.
6		*
7		* @since 0.7
8		*
9		* @licence GNU GPL v2+
10		* @author Jeroen De Dauw < [email protected] >
11		*/
12		class MapsGeodistance extends ParserHook {
		0 ignored issues – show Deprecated Code introduced 2015-12-04 20:45 UTC by Report Bug Copy Issue Report The class `ParserHook` has been deprecated with message: since 1.0 in favour of the ParserHooks library This class, trait or interface has been deprecated. The supplier of the file has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the type will be removed from the class and what other constant to use instead. Loading history...
13
14		/**
15		* Gets the name of the parser hook.
16		* @see ParserHook::getName
17		*
18		* @since 0.7
19		*
20		* @return string
21		*/
22	2	protected function getName() {
23	2	return 'geodistance';
24		}
25
26		/**
27		* Returns an array containing the parameter info.
28		* @see ParserHook::getParameterInfo
29		*
30		* @since 0.7
31		*
32		* @return array
33		*/
34	4	protected function getParameterInfo( $type ) {
35	4	global $egMapsDistanceUnit, $egMapsDistanceDecimals;
36
37	4	$params = [];
38
39	4	$params['unit'] = [
40	4	'default' => $egMapsDistanceUnit,
41	4	'values' => MapsDistanceParser::getUnits(),
42		];
43
44	4	$params['decimals'] = [
45	4	'type' => 'integer',
46	4	'default' => $egMapsDistanceDecimals,
47		];
48
49	4	$params['location1'] = [
50		'type' => 'mapslocation', // FIXME: geoservice is not used
51		'aliases' => 'from',
52		];
53
54	4	$params['location2'] = [
55		'type' => 'mapslocation', // FIXME: geoservice is not used
56		'aliases' => 'to',
57		];
58
59		// Give grep a chance to find the usages:
60		// maps-geodistance-par-mappingservice, maps-geodistance-par-geoservice,
61		// maps-geodistance-par-unit, maps-geodistance-par-decimals,
62		// maps-geodistance-par-location1, maps-geodistance-par-location2
63	4	foreach ( $params as $name => &$param ) {
64	4	$param['message'] = 'maps-geodistance-par-' . $name;
65		}
66
67	4	return $params;
68		}
69
70		/**
71		* Returns the list of default parameters.
72		* @see ParserHook::getDefaultParameters
73		*
74		* @since 0.7
75		*
76		* @param $type
77		*
78		* @return array
79		*/
80	2	protected function getDefaultParameters( $type ) {
81	2	return [ 'location1', 'location2', 'unit', 'decimals' ];
82		}
83
84		/**
85		* Renders and returns the output.
86		* @see ParserHook::render
87		*
88		* @since 0.7
89		*
90		* @param array $parameters
91		*
92		* @return string
93		* @throws MWException
94		*/
95	2	public function render( array $parameters ) {
96		/**
97		* @var \DataValues\LatLongValue $coordinates1
98		* @var \DataValues\LatLongValue $coordinates2
99		*/
100	2	$coordinates1 = $parameters['location1']->getCoordinates();
101	2	$coordinates2 = $parameters['location2']->getCoordinates();
102
103	2	$distance = MapsGeoFunctions::calculateDistance( $coordinates1, $coordinates2 );
104	2	$output = MapsDistanceParser::formatDistance( $distance, $parameters['unit'], $parameters['decimals'] );
105
106	2	return $output;
107		}
108
109		/**
110		* @see ParserHook::getMessage
111		*
112		* @since 1.0
113		*/
114		public function getMessage() {
115		return 'maps-geodistance-description';
		0 ignored issues – show Bug Best Practice introduced 2015-12-04 20:45 UTC by Report Bug Copy Issue Report The return type of `return 'maps-geodistance-description';` (`string`) is incompatible with the return type of the parent method `ParserHook::getMessage` of type `boolean`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
116		}
117
118		}

JeroenDeDauw / Maps

Push — rmds ( 34c84e )

MapsGeodistance A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

5 Methods

Duplication Side-by-Side

Filter issues like