PolygonParser::handlePolygonParams() - Code Metrics - Inspection of "Move wikitext parsers to src/" - JeroenDeDauw/Maps - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — move ( b63aae...04f5b5 )

by Jeroen De

created 2018-11-19 21:19 UTC

PolygonParser::handlePolygonParams() A

↳ Parent: PolygonParser

Complexity

Conditions	4
Paths	8

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	13
rs	9.8333
c	0
b	0
f	0
cc	4
nc	8
nop	2

<?php

namespace Maps\Presentation\WikitextParsers;

use Maps\Elements\Line;
use Maps\Elements\Polygon;

/**
 * ValueParser that parses the string representation of a polygon.
 *
 * @since 3.0
 *
 * @licence GNU GPL v2+
 * @author Jeroen De Dauw < [email protected] >
 */
class PolygonParser extends LineParser {

	protected function constructShapeFromLatLongValues( array $locations ) {
		return new Polygon( $locations );
	}

	protected function handleCommonParams( array &$params, Line &$line ) {
		parent::handleCommonParams( $params, $line );
		$this->handlePolygonParams( $params, $line );

	}

	protected function handlePolygonParams( array &$params, Polygon &$polygon ) {
		if ( $fillColor = array_shift( $params ) ) {
			$polygon->setFillColor( $fillColor );
		}

		if ( $fillOpacity = array_shift( $params ) ) {
			$polygon->setFillOpacity( $fillOpacity );
		}

		if ( $showOnlyOnHover = array_shift( $params ) ) {
			$polygon->setOnlyVisibleOnHover( strtolower( trim( $showOnlyOnHover ) ) === 'on' );
		}
	}

}


1			<?php
2
3			namespace Maps\Presentation\WikitextParsers;
4
5			use Maps\Elements\Line;
6			use Maps\Elements\Polygon;
7
8			/**
9			* ValueParser that parses the string representation of a polygon.
10			*
11			* @since 3.0
12			*
13			* @licence GNU GPL v2+
14			* @author Jeroen De Dauw < [email protected] >
15			*/
16			class PolygonParser extends LineParser {
17
18			protected function constructShapeFromLatLongValues( array $locations ) {
19			return new Polygon( $locations );
20			}
21
22			protected function handleCommonParams( array &$params, Line &$line ) {
23			parent::handleCommonParams( $params, $line );
24			$this->handlePolygonParams( $params, $line );
			0 ignored issues – show Compatibility introduced 2015-12-04 20:45 UTC by Report Bug Copy Issue Report `$line` of type `object<Maps\Elements\Line>` is not a sub-type of `object<Maps\Elements\Polygon>`. It seems like you assume a child class of the class `Maps\Elements\Line` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
25			}
26
27			protected function handlePolygonParams( array &$params, Polygon &$polygon ) {
28			if ( $fillColor = array_shift( $params ) ) {
29			$polygon->setFillColor( $fillColor );
30			}
31
32			if ( $fillOpacity = array_shift( $params ) ) {
33			$polygon->setFillOpacity( $fillOpacity );
34			}
35
36			if ( $showOnlyOnHover = array_shift( $params ) ) {
37			$polygon->setOnlyVisibleOnHover( strtolower( trim( $showOnlyOnHover ) ) === 'on' );
38			}
39			}
40
41			}
42

JeroenDeDauw / Maps

Push — move ( b63aae...04f5b5 )

PolygonParser::handlePolygonParams() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like