MapsOldGeocoderAdapterTest::testWhenInnerGeocoderHasNoResult_falseIsReturned() - Code Metrics - Inspection of "Corrected name of geocoding adapter" - JeroenDeDauw/Maps - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — rename ( 4e66d2 )

by Jeroen De

created 2016-09-13 12:40 UTC

testWhenInnerGeocoderHasNoResult_falseIsReturned() A

↳ Parent: MapsOldGeocoderAdapterTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	9
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	5
nc	1
nop	0
dl	0
loc	9
rs	9.6666
c	0
b	0
f	0

<?php

namespace Maps\Test;

use DataValues\Geo\Values\LatLongValue;
use FileFetcher\InMemoryFileFetcher;
use Maps\Geocoders\InMemoryGeocoder;
use Maps\Geocoders\NominatimGeocoder;

/**
 * @covers MapsOldGeocoderAdapter
 *
 * @group Maps
 *
 * @licence GNU GPL v2+
 * @author Jeroen De Dauw < [email protected] >
 */
class MapsOldGeocoderAdapterTest extends \PHPUnit_Framework_TestCase {

	public function testWhenInnerGeocoderHasResult_itGetsReturnedInArrayForm() {
		$geocoder = new InMemoryGeocoder( [
			'New York' => new LatLongValue( 40.7642499, -73.9545249 )
		] );

		$decoratedGeocoder = new \MapsOldGeocoderAdapter( $geocoder, 'maw' );

		$this->assertSame(
			[
				'lat' => 40.7642499,
				'lon' => -73.9545249,
			],
			$decoratedGeocoder->geocode( 'New York' )
		);
	}

	public function testWhenInnerGeocoderHasNoResult_falseIsReturned() {
		$geocoder = new InMemoryGeocoder( [
			'New York' => new LatLongValue( 40.7642499, -73.9545249 )
		] );

		$decoratedGeocoder = new \MapsOldGeocoderAdapter( $geocoder, 'maw' );

		$this->assertFalse( $decoratedGeocoder->geocode( 'durkadurkastan' ) );
	}

//	public function testWhenInnerGeocoderHasNoResult_falseIsReturned() {
//		$decoratedGeocoder = new \MapsDecoratedGeocoder( new InMemoryGeocoder( [] ), 'maw' );
//
//		$this->assertSame( [ 'maw' ], $decoratedGeocoder->getAliases() );
//	}

	// TODO: test exception case if we decided to not use null in the interface

}


1			<?php
2
3			namespace Maps\Test;
4
5			use DataValues\Geo\Values\LatLongValue;
6			use FileFetcher\InMemoryFileFetcher;
7			use Maps\Geocoders\InMemoryGeocoder;
8			use Maps\Geocoders\NominatimGeocoder;
9
10			/**
11			* @covers MapsOldGeocoderAdapter
12			*
13			* @group Maps
14			*
15			* @licence GNU GPL v2+
16			* @author Jeroen De Dauw < [email protected] >
17			*/
18			class MapsOldGeocoderAdapterTest extends \PHPUnit_Framework_TestCase {
19
20			public function testWhenInnerGeocoderHasResult_itGetsReturnedInArrayForm() {
21			$geocoder = new InMemoryGeocoder( [
22			'New York' => new LatLongValue( 40.7642499, -73.9545249 )
23			] );
24
25			$decoratedGeocoder = new \MapsOldGeocoderAdapter( $geocoder, 'maw' );
26
27			$this->assertSame(
28			[
29			'lat' => 40.7642499,
30			'lon' => -73.9545249,
31			],
32			$decoratedGeocoder->geocode( 'New York' )
33			);
34			}
35
36			public function testWhenInnerGeocoderHasNoResult_falseIsReturned() {
37			$geocoder = new InMemoryGeocoder( [
38			'New York' => new LatLongValue( 40.7642499, -73.9545249 )
39			] );
40
41			$decoratedGeocoder = new \MapsOldGeocoderAdapter( $geocoder, 'maw' );
42
43			$this->assertFalse( $decoratedGeocoder->geocode( 'durkadurkastan' ) );
44			}
45
46			// public function testWhenInnerGeocoderHasNoResult_falseIsReturned() {
47			// $decoratedGeocoder = new \MapsDecoratedGeocoder( new InMemoryGeocoder( [] ), 'maw' );
48			//
49			// $this->assertSame( [ 'maw' ], $decoratedGeocoder->getAliases() );
50			// }
51
52			// TODO: test exception case if we decided to not use null in the interface
53
54			}
55

JeroenDeDauw / Maps

Push — rename ( 4e66d2 )

testWhenInnerGeocoderHasNoResult_falseIsReturned() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like