Issues in MapsRegistration.php - All Issues - Inspection of "Basic page-based GeoJson support" - JeroenDeDauw/Maps - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — vishual ( 73c053...0d0a79 )

by Jeroen De

created 2018-07-28 01:34 UTC

MapsRegistration.php (1 issue)

Labels

Coding Style 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

use Maps\MapsSetup;

class MapsRegistration {

	public static function onRegistration( array $credits ) {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
		if ( defined( 'Maps_COORDS_FLOAT' ) ) {
			// Do not initialize more than once.
			return true;
		}

		if ( is_readable( __DIR__ . '/vendor/autoload.php' ) ) {
			include_once( __DIR__ . '/vendor/autoload.php' );
		}

		define( 'Maps_VERSION', $credits['version'] );
		define( 'SM_VERSION', Maps_VERSION );

		// The different coordinate notations.
		define( 'Maps_COORDS_FLOAT', 'float' );
		define( 'Maps_COORDS_DMS', 'dms' );
		define( 'Maps_COORDS_DM', 'dm' );
		define( 'Maps_COORDS_DD', 'dd' );

		define( 'NS_GEO_JSON', 420 );
		define( 'NS_GEO_JSON_TALK', 421 );

		require_once __DIR__ . '/Maps_Settings.php';

		// Internationalization
		$GLOBALS['wgMessagesDirs']['Maps.class'] = __DIR__ . '/i18n';
		$GLOBALS['wgExtensionMessagesFiles']['MapsMagic'] = __DIR__ . '/Maps.i18n.magic.php';
		$GLOBALS['wgExtensionMessagesFiles']['MapsAlias'] = __DIR__ . '/Maps.i18n.alias.php';

		$GLOBALS['wgExtensionFunctions'][] = function() {
			if ( $GLOBALS['egMapsDisableExtension'] ) {
				return true;
			}

			// Only initialize the extension when all dependencies are present.
			if ( !defined( 'Validator_VERSION' ) ) {
				throw new Exception( 'You need to have Validator installed in order to use Maps' );
			}

			if ( version_compare( $GLOBALS['wgVersion'], '1.27c', '<' ) ) {
				throw new Exception(
					'This version of Maps requires MediaWiki 1.27 or above; use Maps 4.2.x for older versions.'
					. ' More information at https://github.com/JeroenDeDauw/Maps/blob/master/INSTALL.md'
				);
			}

			( new MapsSetup( $GLOBALS ) )->setup();

			return true;
		};

		return true;
	}

}





1			<?php
2
3			use Maps\MapsSetup;
4
5			class MapsRegistration {
6
7			public static function onRegistration( array $credits ) {
			0 ignored issues – show Coding Style introduced 2018-07-28 00:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this `onRegistration` uses the super-global variable `$GLOBALS` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
8			if ( defined( 'Maps_COORDS_FLOAT' ) ) {
9			// Do not initialize more than once.
10			return true;
11			}
12
13			if ( is_readable( __DIR__ . '/vendor/autoload.php' ) ) {
14			include_once( __DIR__ . '/vendor/autoload.php' );
15			}
16
17			define( 'Maps_VERSION', $credits['version'] );
18			define( 'SM_VERSION', Maps_VERSION );
19
20			// The different coordinate notations.
21			define( 'Maps_COORDS_FLOAT', 'float' );
22			define( 'Maps_COORDS_DMS', 'dms' );
23			define( 'Maps_COORDS_DM', 'dm' );
24			define( 'Maps_COORDS_DD', 'dd' );
25
26			define( 'NS_GEO_JSON', 420 );
27			define( 'NS_GEO_JSON_TALK', 421 );
28
29			require_once __DIR__ . '/Maps_Settings.php';
30
31			// Internationalization
32			$GLOBALS['wgMessagesDirs']['Maps.class'] = __DIR__ . '/i18n';
33			$GLOBALS['wgExtensionMessagesFiles']['MapsMagic'] = __DIR__ . '/Maps.i18n.magic.php';
34			$GLOBALS['wgExtensionMessagesFiles']['MapsAlias'] = __DIR__ . '/Maps.i18n.alias.php';
35
36			$GLOBALS['wgExtensionFunctions'][] = function() {
37			if ( $GLOBALS['egMapsDisableExtension'] ) {
38			return true;
39			}
40
41			// Only initialize the extension when all dependencies are present.
42			if ( !defined( 'Validator_VERSION' ) ) {
43			throw new Exception( 'You need to have Validator installed in order to use Maps' );
44			}
45
46			if ( version_compare( $GLOBALS['wgVersion'], '1.27c', '<' ) ) {
47			throw new Exception(
48			'This version of Maps requires MediaWiki 1.27 or above; use Maps 4.2.x for older versions.'
49			. ' More information at https://github.com/JeroenDeDauw/Maps/blob/master/INSTALL.md'
50			);
51			}
52
53			( new MapsSetup( $GLOBALS ) )->setup();
54
55			return true;
56			};
57
58			return true;
59			}
60
61			}
62
63
64
65

JeroenDeDauw / Maps

Push — vishual ( 73c053...0d0a79 )

MapsRegistration.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like