JeroenDeDauw / Maps

src/DataAccess/JsonFileParser.php

Doc Comments +3 added lines

@@ -19,6 +19,9 @@
 	private $pageContentFetcher;
 	private $defaultNamespace;
 
+	/**
+	 * @param FileFetcher $fileFetcher
+	 */
 	public function __construct( $fileFetcher = null, PageContentFetcher $pageContentFetcher = null ) {
 		$this->fileFetcher = $fileFetcher instanceof FileFetcher
 			? $fileFetcher : MapsFactory::newDefault()->getFileFetcher();

src/MappingService.php

Doc Comments +4 added lines, -2 removed lines

@@ -55,7 +55,7 @@ 
 
 	/**
 	 * @param string $serviceName
-	 * @param array $aliases
+	 * @param string[] $aliases
 	 */
 	public function __construct( $serviceName, array $aliases = [] ) {
 		$this->serviceName = $serviceName;
@@ -72,6 +72,7 @@ 
 
 	/**
 	 * @since 0.6.3
+	 * @param string $featureName
 	 */
 	public function addFeature( $featureName, $handlingClass ) {
 		$this->features[$featureName] = $handlingClass;
@@ -180,6 +181,7 @@ 
 
 	/**
 	 * @since 0.6.3
+	 * @param string $alias
 	 */
 	public function hasAlias( $alias ) {
 		return in_array( $alias, $this->aliases );
@@ -190,7 +192,7 @@ 
 	 *
 	 * @since 0.7.3
 	 *
-	 * @param mixed $modules Array of string or string
+	 * @param string[] $modules Array of string or string
 	 */
 	public function addResourceModules( $modules ) {
 		$this->resourceModules = array_merge( $this->resourceModules, (array)$modules );

src/MapsFunctions.php

Doc Comments +1 added lines, -1 removed lines

@@ -72,7 +72,7 @@
 	/**
 	 * This function returns the definitions for the parameters used by every map feature.
 	 *
-	 * @return array
+	 * @return \ParamProcessor\IParamDefinition[]
 	 */
 	public static function getCommonParameters() {
 		$params = [];

Unused Use Statements -3 removed lines

@@ -2,9 +2,6 @@
 
 namespace Maps;
 
-use ImagePage;
-use Maps\DataAccess\MediaWikiFileUrlFinder;
-use Title;
 use Xml;
 
 /**

src/SemanticMW/ResultPrinters/QueryHandler.php

Doc Comments +2 added lines, -2 removed lines

@@ -169,7 +169,7 @@ 
 	}
 
 	/**
-	 * @return Location[]
+	 * @return \Generator
 	 */
 	public function getLocations(): iterable {
 		while ( ( $row = $this->queryResult->getNext() ) !== false ) {
@@ -410,7 +410,7 @@ 
 	/**
 	 * Get the icon for a row.
 	 *
-	 * @param array $row
+	 * @param SMWResultArray[] $row
 	 *
 	 * @return string
 	 */

src/MediaWiki/ParserHooks/DisplayMapRenderer.php

Doc Comments +4 added lines

@@ -136,6 +136,10 @@
 		return $locationJsonObjects;
 	}
 
+	/**
+	 * @param string $iconUrl
+	 * @param string $visitedIconUrl
+	 */
 	private function getLocationJsonObject( Location $location, array $params, $iconUrl, $visitedIconUrl ) {
 		$jsonObj = $location->getJSONObject( $params['title'], $params['label'], $iconUrl, '', '', $visitedIconUrl );
 

Unused Use Statements -1 removed lines

@@ -10,7 +10,6 @@
 use Maps\Presentation\WikitextParser;
 use Maps\Presentation\WikitextParsers\LocationParser;
 use Parser;
-use ParserOptions;
 
 /**
  * Class handling the #display_map rendering.

src/SemanticMW/ResultPrinters/MapPrinter.php

Doc Comments +4 added lines

@@ -205,6 +205,10 @@
 		return $location->getJSONObject();
 	}
 
+	/**
+	 * @param string $iconUrl
+	 * @param string $visitedIconUrl
+	 */
 	private function getJsonForStaticLocations( array $staticLocations, array $params, $iconUrl, $visitedIconUrl ) {
 		$locationsJson = [];