Maps\Geocoders\GeoNamesGeocoder

Complexity

Total Complexity

8

Size/Duplication

Total Lines	52
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	geocode()	0	17	4
A	getRequestUrl()	0	6	1
A	getXmlElementValue()	0	5	2

<?php

namespace Maps\Geocoders;

use DataValues\Geo\Values\LatLongValue;
use FileFetcher\FileFetcher;
use FileFetcher\FileFetchingException;

/**
 * @since 4.5
 *
 * @licence GNU GPL v2+
 * @author Jeroen De Dauw < jeroendedauw@gmail.com >
 */
class GeoNamesGeocoder implements Geocoder {

	private $fileFetcher;
	private $geoNamesUser;

	public function __construct( FileFetcher $fileFetcher, $geoNamesUser ) {
		$this->fileFetcher = $fileFetcher;
		$this->geoNamesUser = $geoNamesUser;
	}

	/**
	 * @param string $address
	 *
	 * @return LatLongValue|null
	 */
	public function geocode( $address ) {
		try {
			$response = $this->fileFetcher->fetchFile( $this->getRequestUrl( $address ) );
		}
		catch ( FileFetchingException $ex ) {
			return null;
		}

		$lon = self::getXmlElementValue( $response, 'lng' );
		$lat = self::getXmlElementValue( $response, 'lat' );

		if ( !$lon || !$lat ) {

The expression $lon of type string|false is loosely compared to false; this is ambiguous if the string can be empty. You might want to explicitly use === false instead.

The expression $lat of type string|false is loosely compared to false; this is ambiguous if the string can be empty. You might want to explicitly use === false instead.

			return null;
		}

		return new LatLongValue( (float)$lat, (float)$lon );
	}

	/**
	 * @param string $address
	 *
	 * @return string
	 */
	private function getRequestUrl( $address ) {
		return 'http://api.geonames.org/search?q='
			   . urlencode( $address )
			   . '&maxRows=1&username='
			   . urlencode( $this->geoNamesUser );
	}

	private function getXmlElementValue( $xml, $tagName ) {
		$match = [];
		preg_match( "/<$tagName>(.*?)<\/$tagName>/", $xml, $match );
		return count( $match ) > 1 ? $match[1] : false;
	}

}