SubObjectBuilder::pointToSubobject() - Code Metrics - Inspection of "Add sane way to construct subobjects" - JeroenDeDauw/Maps - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — SemanticGeoJson ( e5361a...e30e84 )

by Jeroen De

created 2020-02-13 23:40 UTC

SubObjectBuilder::pointToSubobject() A

↳ Parent: SubObjectBuilder

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	15
c	0
b	0
f	0
ccs	0
cts	9
cp	0
rs	9.7666
cc	1
nc	1
nop	0
crap	2

<?php

declare( strict_types = 1 );

namespace Maps\DataAccess\GeoJsonStore;

use Title;

class SubObjectBuilder {

	private $subjectPage;

	public function __construct( Title $subjectPage ) {
		$this->subjectPage = $subjectPage;
	}

	/**
	 * @return SubObject[]
	 */
	public function getSubObjectsFromGeoJson( string $geoJson ) {

		return [  ];
	}

	private function pointToSubobject(): SubObject {

		$subObject = new SubObject( 'MySubobjectName' );

		$subObject->addPropertyValuePair(
			'HasNumber',
			new \SMWDINumber( 455 )
		);

		$subObject->addPropertyValuePair(
			'HasNumber',
			new \SMWDINumber( 4555 )
		);

		return $subObject;
	}


}


1		<?php
2
3		declare( strict_types = 1 );
4
5		namespace Maps\DataAccess\GeoJsonStore;
6
7		use Title;
8
9		class SubObjectBuilder {
10
11		private $subjectPage;
12
13	5	public function __construct( Title $subjectPage ) {
14	5	$this->subjectPage = $subjectPage;
15	5	}
16
17		/**
18		* @return SubObject[]
19		*/
20	5	public function getSubObjectsFromGeoJson( string $geoJson ) {
		0 ignored issues – show Unused Code introduced 2020-02-13 23:44 UTC by Report Bug Copy Issue Report The parameter `$geoJson` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
21	5	return [ ];
22		}
23
24		private function pointToSubobject(): SubObject {
		0 ignored issues – show Unused Code introduced 2020-02-13 23:44 UTC by Report Bug Copy Issue Report This method is not used, and could be removed. Loading history...
25		$subObject = new SubObject( 'MySubobjectName' );
26
27		$subObject->addPropertyValuePair(
28		'HasNumber',
29		new \SMWDINumber( 455 )
30		);
31
32		$subObject->addPropertyValuePair(
33		'HasNumber',
34		new \SMWDINumber( 4555 )
35		);
36
37		return $subObject;
38		}
39
40
41		}
42

JeroenDeDauw / Maps

Push — SemanticGeoJson ( e5361a...e30e84 )

SubObjectBuilder::pointToSubobject() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like