SemanticGeoJsonStore::storeGeoJson() - Code Metrics - Inspection of "Add sane way to construct subobjects" - JeroenDeDauw/Maps - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — SemanticGeoJson ( e5361a...e30e84 )

by Jeroen De

created 2020-02-13 23:40 UTC

SemanticGeoJsonStore::storeGeoJson() A

↳ Parent: SemanticGeoJsonStore

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	2.108

Importance

Changes

Metric	Value
dl	0
loc	20
c	0
b	0
f	0
ccs	7
cts	10
cp	0.7
rs	9.6
cc	2
nc	2
nop	1
crap	2.108

<?php

declare( strict_types = 1 );

namespace Maps\DataAccess\GeoJsonStore;

use Onoi\EventDispatcher\EventDispatcher;
use SMW\DataModel\ContainerSemanticData;
use SMW\DIProperty;
use SMW\DIWikiPage;
use SMW\ParserData;
use SMWDIContainer;
use Title;

class SemanticGeoJsonStore implements GeoJsonStore {

	private $parserData;
	private $subjectPage;
	private $smwEventDispatcher;
	private $subObjectBuilder;

	public function __construct( ParserData $parserData, Title $subjectPage, EventDispatcher $smwEventDispatcher, SubObjectBuilder $subObjectBuilder ) {
		$this->parserData = $parserData;
		$this->subjectPage = $subjectPage;
		$this->smwEventDispatcher = $smwEventDispatcher;
		$this->subObjectBuilder = $subObjectBuilder;
	}

	public function storeGeoJson( string $geoJson ) {
//		$this->parserData->getSemanticData()->addPropertyObjectValue(
//			new DIProperty( 'HasNumber' ),
//			new \SMWDINumber( 44 )
//		);

		foreach ( $this->subObjectBuilder->getSubObjectsFromGeoJson( $geoJson ) as $subObject ) {
			$this->parserData->getSemanticData()->addPropertyObjectValue(
				new DIProperty( DIProperty::TYPE_SUBOBJECT ),
				new SMWDIContainer( $subObject->toContainerSemanticData( $this->subjectPage->getTitleValue() ) )
			);
		}

		$this->parserData->copyToParserOutput();

		$this->smwEventDispatcher->dispatch(
			'InvalidateEntityCache',
			[ 'title' => $this->subjectPage, 'context' => 'GeoJsonContent' ]
		);
	}

}


1		<?php
2
3		declare( strict_types = 1 );
4
5		namespace Maps\DataAccess\GeoJsonStore;
6
7		use Onoi\EventDispatcher\EventDispatcher;
8		use SMW\DataModel\ContainerSemanticData;
9		use SMW\DIProperty;
10		use SMW\DIWikiPage;
11		use SMW\ParserData;
12		use SMWDIContainer;
13		use Title;
14
15		class SemanticGeoJsonStore implements GeoJsonStore {
16
17		private $parserData;
18		private $subjectPage;
19		private $smwEventDispatcher;
20		private $subObjectBuilder;
21
22	3	public function __construct( ParserData $parserData, Title $subjectPage, EventDispatcher $smwEventDispatcher, SubObjectBuilder $subObjectBuilder ) {
23	3	$this->parserData = $parserData;
24	3	$this->subjectPage = $subjectPage;
25	3	$this->smwEventDispatcher = $smwEventDispatcher;
26	3	$this->subObjectBuilder = $subObjectBuilder;
27	3	}
28
29	3	public function storeGeoJson( string $geoJson ) {
30		// $this->parserData->getSemanticData()->addPropertyObjectValue(
31		// new DIProperty( 'HasNumber' ),
32		// new \SMWDINumber( 44 )
33		// );
34
35	3	foreach ( $this->subObjectBuilder->getSubObjectsFromGeoJson( $geoJson ) as $subObject ) {
36		$this->parserData->getSemanticData()->addPropertyObjectValue(
37		new DIProperty( DIProperty::TYPE_SUBOBJECT ),
38		new SMWDIContainer( $subObject->toContainerSemanticData( $this->subjectPage->getTitleValue() ) )
39		);
40		}
41
42	3	$this->parserData->copyToParserOutput();
43
44	3	$this->smwEventDispatcher->dispatch(
45	3	'InvalidateEntityCache',
46	3	[ 'title' => $this->subjectPage, 'context' => 'GeoJsonContent' ]
47		);
48	3	}
49
50		}
51

JeroenDeDauw / Maps

Push — SemanticGeoJson ( e5361a...e30e84 )

SemanticGeoJsonStore::storeGeoJson() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like