Completed
Push — geonames-geocoder ( 01e909...af3b1c )
by Jeroen De
04:28
created
includes/Geocoders.php 1 patch
Doc Comments   +7 added lines, -4 removed lines patch added patch discarded remove patch
@@ -124,7 +124,7 @@  discard block
 block discarded – undo
124 124
 	 * @param string $geoService
125 125
 	 * @param boolean $checkForCoords
126 126
 	 *
127
-	 * @return LatLongValue|false
127
+	 * @return LatLongValue
128 128
 	 */
129 129
 	public static function attemptToGeocode( $coordsOrAddress, $geoService = '', $checkForCoords = true ) {
130 130
 		if ( $checkForCoords ) {
@@ -150,7 +150,7 @@  discard block
 block discarded – undo
150 150
 	 * @param string $address
151 151
 	 * @param string $geoService
152 152
 	 *
153
-	 * @return LatLongValue|false
153
+	 * @return LatLongValue
154 154
 	 * @throws MWException
155 155
 	 */
156 156
 	public static function geocode( $address, $geoService = '' ) {
@@ -190,6 +190,9 @@  discard block
 block discarded – undo
190 190
 		return $coordinates;
191 191
 	}
192 192
 
193
+	/**
194
+	 * @param string $address
195
+	 */
193 196
 	private static function getGeocoded( Geocoder $geocoder, $address ) {
194 197
 		$coordinates = self::getGeocodedAsArray( $geocoder, $address );
195 198
 
@@ -260,7 +263,7 @@  discard block
 block discarded – undo
260 263
 	 * @since 0.7
261 264
 	 *
262 265
 	 * @param string $geocoderIdentifier
263
-	 * @param string|\Maps\Geocoders\Geocoder $geocoder
266
+	 * @param string $geocoder
264 267
 	 */
265 268
 	public static function registerGeocoder( $geocoderIdentifier, $geocoder ) {
266 269
 		self::$registeredGeocoders[$geocoderIdentifier] = $geocoder;
@@ -331,7 +334,7 @@  discard block
 block discarded – undo
331 334
 	 *
332 335
 	 * @param string $geocoderIdentifier
333 336
 	 *
334
-	 * @return string|bool
337
+	 * @return string
335 338
 	 * @throws MWException
336 339
 	 */
337 340
 	private static function getValidGeocoderIdentifier( $geocoderIdentifier ) {
Please login to merge, or discard this patch.
includes/parsers/LineParser.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -128,6 +128,9 @@  discard block
 block discarded – undo
128 128
 		}
129 129
 	}
130 130
 
131
+	/**
132
+	 * @param string $link
133
+	 */
131 134
 	protected function setLinkFromParameter( Line &$line , $link ) {
132 135
 		if ( filter_var( $link , FILTER_VALIDATE_URL , FILTER_FLAG_SCHEME_REQUIRED ) ) {
133 136
 			$line->setLink( $link );
@@ -141,7 +144,7 @@  discard block
 block discarded – undo
141 144
 	 * Checks if a string is prefixed with link:
142 145
 	 * @static
143 146
 	 * @param $link
144
-	 * @return bool|string
147
+	 * @return string|false
145 148
 	 * @since 2.0
146 149
 	 */
147 150
 	private function isLinkParameter( $link ) {
Please login to merge, or discard this patch.
src/Geocoders/GeoNamesGeocoder.php 1 patch
Doc Comments   +7 added lines patch added patch discarded remove patch
@@ -17,6 +17,9 @@  discard block
 block discarded – undo
17 17
 	private $fileFetcher;
18 18
 	private $geoNamesUser;
19 19
 
20
+	/**
21
+	 * @param string $geoNamesUser
22
+	 */
20 23
 	public function __construct( FileFetcher $fileFetcher, $geoNamesUser ) {
21 24
 		$this->fileFetcher = $fileFetcher;
22 25
 		$this->geoNamesUser = $geoNamesUser;
@@ -57,6 +60,10 @@  discard block
 block discarded – undo
57 60
 			   . urlencode( $this->geoNamesUser );
58 61
 	}
59 62
 
63
+	/**
64
+	 * @param string $xml
65
+	 * @param string $tagName
66
+	 */
60 67
 	private function getXmlElementValue( $xml, $tagName ) {
61 68
 		$match = [];
62 69
 		preg_match( "/<$tagName>(.*?)<\/$tagName>/", $xml, $match );
Please login to merge, or discard this patch.