Maps\ImageOverlayParser

Complexity

Total Complexity

5

Size/Duplication

Total Lines	42
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	parse()	0	14	2
A	stringToLatLongValue()	0	9	2

<?php

namespace Maps;

use Maps\Elements\ImageOverlay;
use ValueParsers\ParseException;
use ValueParsers\ValueParser;

/**
 * @since 3.1
 *
 * @licence GNU GPL v2+
 * @author Jeroen De Dauw < jeroendedauw@gmail.com >
 */
class ImageOverlayParser implements ValueParser {

	private $geocoder;

	public function __construct() {
		$this->geocoder = MapsFactory::newDefault()->newGeocoder();
	}

	/**
	 * @since 3.1
	 *
	 * @param string $value
	 *
	 * @return ImageOverlay
	 * @throws ParseException
	 */
	public function parse( $value ) {
		$parameters = explode( '~', $value );
		$imageParameters = explode( ':', $parameters[0], 3 );

		if ( count( $imageParameters ) === 3 ) {
			$boundsNorthEast = $this->stringToLatLongValue( $imageParameters[0] );
			$boundsSouthWest = $this->stringToLatLongValue( $imageParameters[1] );
			$imageUrl = \MapsMapper::getFileUrl( $imageParameters[2] );

The method MapsMapper::getFileUrl() has been deprecated.

			return new ImageOverlay( $boundsNorthEast, $boundsSouthWest, $imageUrl );

It seems like $boundsNorthEast defined by $this->stringToLatLongValue($imageParameters[0]) on line 36 can be null; however, Maps\Elements\ImageOverlay::__construct() does not accept null, maybe add an additional type check?

It seems like $boundsSouthWest defined by $this->stringToLatLongValue($imageParameters[1]) on line 37 can be null; however, Maps\Elements\ImageOverlay::__construct() does not accept null, maybe add an additional type check?

		}

		throw new ParseException( 'Need 3 parameters for an image overlay' );
	}

	private function stringToLatLongValue( $location ) {
		$latLong = $this->geocoder->geocode( $location );

		if ( $location === null ) {
			throw new ParseException( 'Failed to parse or geocode' );
		}

		return $latLong;
	}

}