Issues in MapsRegistration.php - All Issues - Inspection of "7.0.0 release" - JeroenDeDauw/Maps - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — rel700 ( ebf287 )

by Jeroen De

created 2018-12-15 02:22 UTC

MapsRegistration.php (1 issue)

Labels

Coding Style 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

use Maps\MapsSetup;

class MapsRegistration {

	public static function onRegistration( array $credits ) {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
		if ( defined( 'Maps_VERSION' ) ) {
			// Do not initialize more than once.
			return true;
		}

		if ( !defined( 'Maps_SETTINGS_LOADED' ) ) {
			foreach ( include __DIR__ . '/DefaultSettings.php' as $key => $value ) {
				$GLOBALS[$key] = $value;
			}

			define( 'Maps_SETTINGS_LOADED', true );
		}

		if ( is_readable( __DIR__ . '/vendor/autoload.php' ) ) {
			include_once( __DIR__ . '/vendor/autoload.php' );
		}

		define( 'Maps_VERSION', $credits['version'] );
		define( 'SM_VERSION', Maps_VERSION );

		if ( !(bool)'Defining PHP constants in JSON is a bad idea and breaks tools' ) {
			define( 'NS_GEO_JSON', 420 );
			define( 'NS_GEO_JSON_TALK', 421 );
		}

		$GLOBALS['wgExtensionFunctions'][] = function() {
			if ( $GLOBALS['egMapsDisableExtension'] ) {
				return true;
			}

			// Only initialize the extension when all dependencies are present.
			if ( !defined( 'Validator_VERSION' ) ) {
				throw new Exception( 'You need to have Validator installed in order to use Maps' );
			}

			if ( version_compare( $GLOBALS['wgVersion'], '1.27c', '<' ) ) {
				throw new Exception(
					'This version of Maps requires MediaWiki 1.27 or above; use Maps 4.2.x for older versions.'
					. ' More information at https://github.com/JeroenDeDauw/Maps/blob/master/INSTALL.md'
				);
			}

			( new MapsSetup( $GLOBALS ) )->setup();

			return true;
		};

		return true;
	}

}





1			<?php
2
3			use Maps\MapsSetup;
4
5			class MapsRegistration {
6
7			public static function onRegistration( array $credits ) {
			0 ignored issues – show Coding Style introduced 2018-07-28 00:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this `onRegistration` uses the super-global variable `$GLOBALS` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
8			if ( defined( 'Maps_VERSION' ) ) {
9			// Do not initialize more than once.
10			return true;
11			}
12
13			if ( !defined( 'Maps_SETTINGS_LOADED' ) ) {
14			foreach ( include __DIR__ . '/DefaultSettings.php' as $key => $value ) {
15			$GLOBALS[$key] = $value;
16			}
17
18			define( 'Maps_SETTINGS_LOADED', true );
19			}
20
21			if ( is_readable( __DIR__ . '/vendor/autoload.php' ) ) {
22			include_once( __DIR__ . '/vendor/autoload.php' );
23			}
24
25			define( 'Maps_VERSION', $credits['version'] );
26			define( 'SM_VERSION', Maps_VERSION );
27
28			if ( !(bool)'Defining PHP constants in JSON is a bad idea and breaks tools' ) {
29			define( 'NS_GEO_JSON', 420 );
30			define( 'NS_GEO_JSON_TALK', 421 );
31			}
32
33			$GLOBALS['wgExtensionFunctions'][] = function() {
34			if ( $GLOBALS['egMapsDisableExtension'] ) {
35			return true;
36			}
37
38			// Only initialize the extension when all dependencies are present.
39			if ( !defined( 'Validator_VERSION' ) ) {
40			throw new Exception( 'You need to have Validator installed in order to use Maps' );
41			}
42
43			if ( version_compare( $GLOBALS['wgVersion'], '1.27c', '<' ) ) {
44			throw new Exception(
45			'This version of Maps requires MediaWiki 1.27 or above; use Maps 4.2.x for older versions.'
46			. ' More information at https://github.com/JeroenDeDauw/Maps/blob/master/INSTALL.md'
47			);
48			}
49
50			( new MapsSetup( $GLOBALS ) )->setup();
51
52			return true;
53			};
54
55			return true;
56			}
57
58			}
59
60
61
62

JeroenDeDauw / Maps

Push — rel700 ( ebf287 )

MapsRegistration.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like