Maps\DataAccess\GeoJsonFetcher

Complexity

Total Complexity

12

Size/Duplication

Total Lines	73
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

97.06%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	parse()	0	3	1
B	fetch()	0	34	6
A	newEmptyResult()	0	6	1
A	normalizeJson()	0	13	3

<?php

declare( strict_types = 1 );

namespace Maps\DataAccess;

use FileFetcher\FileFetcher;
use FileFetcher\FileFetchingException;
use MediaWiki\Storage\RevisionLookup;

/**
 * Returns the content of the JSON file at the specified location as array.
 * Empty array is returned on failure.
 *
 * @licence GNU GPL v2+
 * @author Jeroen De Dauw < jeroendedauw@gmail.com >
 */
class GeoJsonFetcher {

	private $fileFetcher;
	private $titleParser;
	private $revisionLookup;

	public function __construct( FileFetcher $fileFetcher, \TitleParser $titleParser, RevisionLookup $revisionLookup ) {
		$this->fileFetcher = $fileFetcher;
		$this->titleParser = $titleParser;
		$this->revisionLookup = $revisionLookup;
	}

	public function parse( string $fileLocation ): array {
		return $this->fetch( $fileLocation )->getContent();
	}

	public function fetch( string $fileLocation ) {
		try {
			$title = $this->titleParser->parseTitle( $fileLocation, NS_GEO_JSON );
			$revision = $this->revisionLookup->getRevisionByTitle( $title );

			if ( $revision !== null ) {
				$content = $revision->getContent( 'main' );

				if ( $content instanceof \JsonContent ) {

The class JsonContent does not exist. Did you forget a USE statement, or did you not list all dependencies?

					return new GeoJsonFetcherResult(
						$this->normalizeJson( $content->getNativeData() ),
						$title
					);
				}
			}
		}
		catch ( \MalformedTitleException $e ) {

Consider adding a comment why this CATCH block is empty.

The class MalformedTitleException does not exist. Did you forget a USE statement, or did you not list all dependencies?

		}

		// Prevent reading JSON files on the server
		if( !filter_var( $fileLocation, FILTER_VALIDATE_URL) ) {
			return $this->newEmptyResult();
		}

		try {
			return new GeoJsonFetcherResult(
				$this->normalizeJson( $this->fileFetcher->fetchFile( $fileLocation ) ),
				null
			);
		}
		catch ( FileFetchingException $ex ) {
			return $this->newEmptyResult();
		}
	}

	private function newEmptyResult(): GeoJsonFetcherResult {
		return new GeoJsonFetcherResult(
			[],
			null
		);
	}

	private function normalizeJson( ?string $jsonString ): array {
		if ( $jsonString === null ) {
			return [];
		}

		$json = json_decode( $jsonString, true );

		if ( $json === null ) {
			return [];
		}

		return $json;
	}

}