for testing and deploying your application
for finding and fixing issues
for empowering human code reviews
<?php
declare( strict_types = 1 );
namespace Wikibase\JsonDumpReader\Tests\Unit\Iterator;
use PHPUnit\Framework\TestCase;
use Wikibase\JsonDumpReader\JsonDumpFactory;
use Wikibase\JsonDumpReader\Reader\FakeDumpReader;
/**
* @covers \Wikibase\JsonDumpReader\JsonDumpFactory
* @covers \Wikibase\JsonDumpReader\Reader\FakeDumpReader
*
* @licence GNU GPL v2+
* @author Jeroen De Dauw < [email protected] >
*/
class StringDumpIteratorTest extends TestCase {
public function testAdaptsDumpReaderToIterator() {
$lines = [ 'foo', 'bar', 'baz' ];
$iterator = ( new JsonDumpFactory() )->newStringDumpIterator( new FakeDumpReader( $lines ) );
$lines
array<integer,string,{"0..."string","2":"string"}>
string
It seems like the type of the argument is not accepted by the function/method which you are calling.
In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.
We suggest to add an explicit type cast like in the following example:
function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x);
$this->assertSame(
$lines,
iterator_to_array( $iterator )
);
}
JeroenDeDauw /
JsonDumpReader
It seems like the type of the argument is not accepted by the function/method which you are calling.
In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.
We suggest to add an explicit type cast like in the following example: