GitHubFetcher::getFileContent() - Code Metrics - Inspection of "Extracted content fetching reposinbility into own..." - JeroenDeDauw/GitHub - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — extract ( e8a5db )

by Jeroen De

created 2017-06-06 01:43 UTC

GitHubFetcher::getFileContent() A

↳ Parent: GitHubFetcher

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	10
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	6
nc	2
nop	3

<?php

namespace GitHub;

use FileFetcher\FileFetcher;
use FileFetcher\FileFetchingException;

/**
 * @licence GNU GPL v2+
 * @author Jeroen De Dauw < [email protected] >
 */
class GitHubFetcher {

	private $fileFetcher;
	private $gitHubUrl;

	public function __construct( FileFetcher $fileFetcher, string $gitHubUrl ) {
		$this->fileFetcher = $fileFetcher;
		$this->gitHubUrl = $gitHubUrl;
	}

	public function getFileContent( string $repoName, string $branchName, string $fileName ): string {
		$url = $this->getFileUrl( $repoName, $branchName, $fileName );

		try {
			return $this->fileFetcher->fetchFile( $url );
		}
		catch ( FileFetchingException $ex ) {
			return '';
		}
	}

	private function getFileUrl( string $repoName, string $branchName, string $fileName ): string {
		return sprintf(
			'%s/%s/%s/%s',
			$this->gitHubUrl,
			$repoName,
			$branchName,
			$fileName
		);
	}

}


1			<?php
2
3			namespace GitHub;
4
5			use FileFetcher\FileFetcher;
6			use FileFetcher\FileFetchingException;
7
8			/**
9			* @licence GNU GPL v2+
10			* @author Jeroen De Dauw < [email protected] >
11			*/
12			class GitHubFetcher {
13
14			private $fileFetcher;
15			private $gitHubUrl;
16
17			public function __construct( FileFetcher $fileFetcher, string $gitHubUrl ) {
18			$this->fileFetcher = $fileFetcher;
19			$this->gitHubUrl = $gitHubUrl;
20			}
21
22			public function getFileContent( string $repoName, string $branchName, string $fileName ): string {
23			$url = $this->getFileUrl( $repoName, $branchName, $fileName );
24
25			try {
26			return $this->fileFetcher->fetchFile( $url );
27			}
28			catch ( FileFetchingException $ex ) {
29			return '';
30			}
31			}
32
33			private function getFileUrl( string $repoName, string $branchName, string $fileName ): string {
34			return sprintf(
35			'%s/%s/%s/%s',
36			$this->gitHubUrl,
37			$repoName,
38			$branchName,
39			$fileName
40			);
41			}
42
43			}
44

JeroenDeDauw / GitHub

Push — extract ( e8a5db )

GitHubFetcher::getFileContent() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like