InMemoryFileFetcher::fetchFile() - Code Metrics - Inspection of "Added `$defaultContent` constructor parameter to `..." - JeroenDeDauw/FileFetcher - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#13)

by Jeroen De

created 2017-06-09 05:55 UTC

InMemoryFileFetcher::fetchFile() A

↳ Parent: InMemoryFileFetcher

Complexity

Conditions	3
Paths	3

Size

Total Lines	11
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	3

Importance

Changes

Metric	Value
dl	0
loc	11
ccs	6
cts	6
cp	1
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	6
nc	3
nop	1
crap	3

<?php

declare( strict_types=1 );

namespace FileFetcher;

use InvalidArgumentException;

/**
 * @since 3.1
 *
 * @licence GNU GPL v2+
 * @author Jeroen De Dauw < [email protected] >
 */
class InMemoryFileFetcher implements FileFetcher {

	private $files;
	private $defaultContent;

	/**
	 * @param string[] $files
	 * @param string|null $defaultContent Content that is returned when there is no matching entry in $files
	 * @throws InvalidArgumentException
	 */
	public function __construct( array $files, string $defaultContent = null ) {
		foreach ( $files as $url => $fileContents ) {
			if ( !is_string( $url ) || !is_string( $fileContents ) ) {
				throw new InvalidArgumentException( 'Both file url and file contents need to be of type string' );
			}
		}

		$this->files = $files;
		$this->defaultContent = $defaultContent;
	}

	/**
	 * @see FileFetcher::fetchFile
	 * @throws FileFetchingException
	 */
	public function fetchFile( string $fileUrl ): string {
		if ( array_key_exists( $fileUrl, $this->files ) ) {
			return $this->files[$fileUrl];
		}

		if ( $this->defaultContent === null ) {
			throw new FileFetchingException( $fileUrl );
		}

		return $this->defaultContent;
	}

}


1		<?php
2
3		declare( strict_types=1 );
4
5		namespace FileFetcher;
6
7		use InvalidArgumentException;
8
9		/**
10		* @since 3.1
11		*
12		* @licence GNU GPL v2+
13		* @author Jeroen De Dauw < [email protected] >
14		*/
15		class InMemoryFileFetcher implements FileFetcher {
16
17		private $files;
18		private $defaultContent;
19
20		/**
21		* @param string[] $files
22		* @param string\|null $defaultContent Content that is returned when there is no matching entry in $files
23		* @throws InvalidArgumentException
24		*/
25	9	public function __construct( array $files, string $defaultContent = null ) {
26	9	foreach ( $files as $url => $fileContents ) {
27	4	if ( !is_string( $url ) \|\| !is_string( $fileContents ) ) {
28		throw new InvalidArgumentException( 'Both file url and file contents need to be of type string' );
29		}
30		}
31
32	9	$this->files = $files;
33	9	$this->defaultContent = $defaultContent;
34	9	}
35
36		/**
37		* @see FileFetcher::fetchFile
38		* @throws FileFetchingException
39		*/
40	9	public function fetchFile( string $fileUrl ): string {
41	9	if ( array_key_exists( $fileUrl, $this->files ) ) {
42	3	return $this->files[$fileUrl];
43		}
44
45	6	if ( $this->defaultContent === null ) {
46	5	throw new FileFetchingException( $fileUrl );
47		}
48
49	1	return $this->defaultContent;
50		}
51
52		}
53

JeroenDeDauw / FileFetcher

Pull Request — master (#13)

InMemoryFileFetcher::fetchFile() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like