JeroenDeDauw / EntityStore

tests/integration/ItemStoreTest.php

Spacing +170 added lines, -170 removed lines

@@ -37,300 +37,300 @@
 		$this->createItemRowField();
 	}
 
-	private function createStore( $doDbInstall = false ) {
+	private function createStore($doDbInstall = false) {
 		$connection = TestFixtureFactory::newInstance()->newConnection();
 		$config = new EntityStoreConfig();
 
-		if ( $doDbInstall ) {
-			$installer = new EntityStoreInstaller( $connection->getSchemaManager(), $config );
+		if ($doDbInstall) {
+			$installer = new EntityStoreInstaller($connection->getSchemaManager(), $config);
 			$installer->install();
 		}
 
-		$this->store = ( new EntityStoreFactory( $connection, $config ) )->newItemStore();
+		$this->store = (new EntityStoreFactory($connection, $config))->newItemStore();
 	}
 
 	private function createItemRowField() {
-		$this->itemRow = ( new ItemRow() )
-			->setPageTitle( 'Item:Q1337' )
-			->setRevisionId( '424242' )
-			->setItemType( 1 )
-			->setRevisionTime( '2014-02-27T11:40:12Z' )
-			->setEnglishLabel( 'kittens' )
-			->setEnglishWikipediaTitle( 'cats' )
-			->setItemJson( 'json be here' )
-			->setNumericItemId( self::ITEM_ID );
+		$this->itemRow = (new ItemRow())
+			->setPageTitle('Item:Q1337')
+			->setRevisionId('424242')
+			->setItemType(1)
+			->setRevisionTime('2014-02-27T11:40:12Z')
+			->setEnglishLabel('kittens')
+			->setEnglishWikipediaTitle('cats')
+			->setItemJson('json be here')
+			->setNumericItemId(self::ITEM_ID);
 	}
 
 	public function testCanStoreAndRetrieveItemPage() {
-		$this->createStore( self::AND_INSTALL );
+		$this->createStore(self::AND_INSTALL);
 
-		$this->store->storeItemRow( $this->itemRow );
+		$this->store->storeItemRow($this->itemRow);
 
-		$newItemRow = $this->store->getItemRowByNumericItemId( self::ITEM_ID );
+		$newItemRow = $this->store->getItemRowByNumericItemId(self::ITEM_ID);
 
-		$this->assertInstanceOf( 'Queryr\EntityStore\Data\ItemRow', $newItemRow );
+		$this->assertInstanceOf('Queryr\EntityStore\Data\ItemRow', $newItemRow);
 
-		$this->assertSame( $this->itemRow->getNumericItemId(), $newItemRow->getNumericItemId() );
-		$this->assertSame( $this->itemRow->getItemJson(), $newItemRow->getItemJson() );
-		$this->assertSame( $this->itemRow->getPageTitle(), $newItemRow->getPageTitle() );
-		$this->assertSame( $this->itemRow->getRevisionId(), $newItemRow->getRevisionId() );
-		$this->assertSame( $this->itemRow->getRevisionTime(), $newItemRow->getRevisionTime() );
-		$this->assertSame( $this->itemRow->getItemType(), $newItemRow->getItemType() );
-		$this->assertSame( $this->itemRow->getEnglishLabel(), $newItemRow->getEnglishLabel() );
-		$this->assertSame( $this->itemRow->getEnglishWikipediaTitle(), $newItemRow->getEnglishWikipediaTitle() );
+		$this->assertSame($this->itemRow->getNumericItemId(), $newItemRow->getNumericItemId());
+		$this->assertSame($this->itemRow->getItemJson(), $newItemRow->getItemJson());
+		$this->assertSame($this->itemRow->getPageTitle(), $newItemRow->getPageTitle());
+		$this->assertSame($this->itemRow->getRevisionId(), $newItemRow->getRevisionId());
+		$this->assertSame($this->itemRow->getRevisionTime(), $newItemRow->getRevisionTime());
+		$this->assertSame($this->itemRow->getItemType(), $newItemRow->getItemType());
+		$this->assertSame($this->itemRow->getEnglishLabel(), $newItemRow->getEnglishLabel());
+		$this->assertSame($this->itemRow->getEnglishWikipediaTitle(), $newItemRow->getEnglishWikipediaTitle());
 	}
 
 	public function testGivenNotKnownId_getItemRowByNumericItemIdReturnsNull() {
-		$this->createStore( self::AND_INSTALL );
-		$this->assertNull( $this->store->getItemRowByNumericItemId( '32202' ) );
+		$this->createStore(self::AND_INSTALL);
+		$this->assertNull($this->store->getItemRowByNumericItemId('32202'));
 	}
 
 	public function testWhenStoreNotInitialized_storeItemRowThrowsException() {
-		$this->createStore( self::WITHOUT_INSTALLING );
-		$this->setExpectedException( 'Queryr\EntityStore\EntityStoreException' );
-		$this->store->storeItemRow( $this->itemRow );
+		$this->createStore(self::WITHOUT_INSTALLING);
+		$this->setExpectedException('Queryr\EntityStore\EntityStoreException');
+		$this->store->storeItemRow($this->itemRow);
 	}
 
 	public function testWhenStoreNotInitialized_getItemRowByNumericItemIdThrowsException() {
-		$this->createStore( self::WITHOUT_INSTALLING );
-		$this->setExpectedException( 'Queryr\EntityStore\EntityStoreException' );
-		$this->store->getItemRowByNumericItemId( 1 );
+		$this->createStore(self::WITHOUT_INSTALLING);
+		$this->setExpectedException('Queryr\EntityStore\EntityStoreException');
+		$this->store->getItemRowByNumericItemId(1);
 	}
 
 	public function testWhenStoreNotInitialized_getItemInfoThrowsException() {
-		$this->createStore( self::WITHOUT_INSTALLING );
-		$this->setExpectedException( 'Queryr\EntityStore\EntityStoreException' );
-		$this->store->getItemInfo( 10, 0 );
+		$this->createStore(self::WITHOUT_INSTALLING);
+		$this->setExpectedException('Queryr\EntityStore\EntityStoreException');
+		$this->store->getItemInfo(10, 0);
 	}
 
 	public function testWhenStoreNotInitialized_getItemTypesThrowsException() {
-		$this->createStore( self::WITHOUT_INSTALLING );
-		$this->setExpectedException( 'Queryr\EntityStore\EntityStoreException' );
+		$this->createStore(self::WITHOUT_INSTALLING);
+		$this->setExpectedException('Queryr\EntityStore\EntityStoreException');
 		$this->store->getItemTypes();
 	}
 
 	public function testWhenNoItemsInStore_getItemTypesReturnsEmptyArray() {
-		$this->createStore( self::AND_INSTALL );
-		$this->assertSame( [], $this->store->getItemTypes() );
+		$this->createStore(self::AND_INSTALL);
+		$this->assertSame([], $this->store->getItemTypes());
 	}
 
 	private function insertFiveItems() {
 		$this->store->storeItemRow(
-			( new ItemRow() )
-				->setPageTitle( 'Item:Q1000' )
-				->setRevisionId( '123456' )
-				->setItemType( 5 )
-				->setRevisionTime( '2014-02-27T11:40:12Z' )
-				->setEnglishLabel( 'kittens' )
-				->setItemJson( 'json be here' )
-				->setNumericItemId( 1000 )
+			(new ItemRow())
+				->setPageTitle('Item:Q1000')
+				->setRevisionId('123456')
+				->setItemType(5)
+				->setRevisionTime('2014-02-27T11:40:12Z')
+				->setEnglishLabel('kittens')
+				->setItemJson('json be here')
+				->setNumericItemId(1000)
 		);
 
 		$this->store->storeItemRow(
-			( new ItemRow() )
-				->setPageTitle( 'Item:Q2000' )
-				->setRevisionId( '234567' )
-				->setItemType( 5 )
-				->setRevisionTime( '2014-02-27T11:40:12Z' )
-				->setEnglishLabel( 'cats' )
-				->setItemJson( 'json be here' )
-				->setNumericItemId( 2000 )
+			(new ItemRow())
+				->setPageTitle('Item:Q2000')
+				->setRevisionId('234567')
+				->setItemType(5)
+				->setRevisionTime('2014-02-27T11:40:12Z')
+				->setEnglishLabel('cats')
+				->setItemJson('json be here')
+				->setNumericItemId(2000)
 		);
 
 		$this->store->storeItemRow(
-			( new ItemRow() )
-				->setPageTitle( 'Item:Q3000' )
-				->setRevisionId( '345678' )
-				->setItemType( 1 )
-				->setRevisionTime( '2014-02-27T11:40:12Z' )
-				->setEnglishLabel( 'more cats' )
-				->setItemJson( 'json be here' )
-				->setNumericItemId( 3000 )
+			(new ItemRow())
+				->setPageTitle('Item:Q3000')
+				->setRevisionId('345678')
+				->setItemType(1)
+				->setRevisionTime('2014-02-27T11:40:12Z')
+				->setEnglishLabel('more cats')
+				->setItemJson('json be here')
+				->setNumericItemId(3000)
 		);
 
 		$this->store->storeItemRow(
-			( new ItemRow() )
-				->setPageTitle( 'Item:Q4000' )
-				->setRevisionId( '456789' )
-				->setItemType( null )
-				->setRevisionTime( '2014-02-27T11:40:12Z' )
-				->setEnglishLabel( 'more kittens' )
-				->setItemJson( 'json be here' )
-				->setNumericItemId( 4000 )
+			(new ItemRow())
+				->setPageTitle('Item:Q4000')
+				->setRevisionId('456789')
+				->setItemType(null)
+				->setRevisionTime('2014-02-27T11:40:12Z')
+				->setEnglishLabel('more kittens')
+				->setItemJson('json be here')
+				->setNumericItemId(4000)
 		);
 
 		$this->store->storeItemRow(
-			( new ItemRow() )
-				->setPageTitle( 'Item:Q5000' )
-				->setRevisionId( '567890' )
-				->setItemType( 3 )
-				->setRevisionTime( '2014-02-27T11:40:12Z' )
-				->setEnglishLabel( 'all kittens' )
-				->setItemJson( 'json be here' )
-				->setNumericItemId( 5000 )
+			(new ItemRow())
+				->setPageTitle('Item:Q5000')
+				->setRevisionId('567890')
+				->setItemType(3)
+				->setRevisionTime('2014-02-27T11:40:12Z')
+				->setEnglishLabel('all kittens')
+				->setItemJson('json be here')
+				->setNumericItemId(5000)
 		);
 	}
 
 	public function testGetItemTypesReturnsDistinctNonNullTypes() {
-		$this->createStore( self::AND_INSTALL );
+		$this->createStore(self::AND_INSTALL);
 		$this->insertFiveItems();
 
-		$this->assertSame( [ 1, 3, 5 ], $this->store->getItemTypes() );
+		$this->assertSame([1, 3, 5], $this->store->getItemTypes());
 
-		$this->assertSame( [ 1 ], $this->store->getItemTypes( 1, 0 ) );
-		$this->assertSame( [ 3, 5 ], $this->store->getItemTypes( 10, 1 ) );
+		$this->assertSame([1], $this->store->getItemTypes(1, 0));
+		$this->assertSame([3, 5], $this->store->getItemTypes(10, 1));
 	}
 
 	public function testGivenNullTypeFilter_getItemInfoReturnsAllItems() {
-		$this->createStore( self::AND_INSTALL );
+		$this->createStore(self::AND_INSTALL);
 		$this->insertFiveItems();
 
-		$this->assertCount( 5, $this->store->getItemInfo( 10, 0, null ) );
+		$this->assertCount(5, $this->store->getItemInfo(10, 0, null));
 	}
 
 	public function testGivenMatchingTypeFilter_getItemInfoReturnsOnlyMatchingItems() {
-		$this->createStore( self::AND_INSTALL );
+		$this->createStore(self::AND_INSTALL);
 		$this->insertFiveItems();
 
-		$itemInfo = $this->store->getItemInfo( 10, 0, 5 );
+		$itemInfo = $this->store->getItemInfo(10, 0, 5);
 
-		$this->assertCount( 2, $itemInfo );
-		$this->assertSame( 1000, $itemInfo[0]->getNumericItemId() );
-		$this->assertSame( 2000, $itemInfo[1]->getNumericItemId() );
+		$this->assertCount(2, $itemInfo);
+		$this->assertSame(1000, $itemInfo[0]->getNumericItemId());
+		$this->assertSame(2000, $itemInfo[1]->getNumericItemId());
 	}
 
 	public function testGivenNonMatchingTypeFilter_getItemInfoReturnsEmptyArray() {
-		$this->createStore( self::AND_INSTALL );
+		$this->createStore(self::AND_INSTALL);
 		$this->insertFiveItems();
 
-		$this->assertSame( [], $this->store->getItemInfo( 10, 0, 1337 ) );
+		$this->assertSame([], $this->store->getItemInfo(10, 0, 1337));
 	}
 
 	public function testInsertingExistingItemOverridesTheOriginalOne() {
-		$this->createStore( self::AND_INSTALL );
+		$this->createStore(self::AND_INSTALL);
 
 		$this->store->storeItemRow(
-			( new ItemRow() )
-				->setPageTitle( 'Item:Q1000' )
-				->setRevisionId( '123456' )
-				->setItemType( 5 )
-				->setRevisionTime( '2014-02-27T11:40:12Z' )
-				->setEnglishLabel( 'kittens' )
-				->setItemJson( 'json be here' )
-				->setNumericItemId( 1000 )
+			(new ItemRow())
+				->setPageTitle('Item:Q1000')
+				->setRevisionId('123456')
+				->setItemType(5)
+				->setRevisionTime('2014-02-27T11:40:12Z')
+				->setEnglishLabel('kittens')
+				->setItemJson('json be here')
+				->setNumericItemId(1000)
 		);
 
 		$this->store->storeItemRow(
-			( new ItemRow() )
-				->setPageTitle( 'Item:Q1000' )
-				->setRevisionId( '123456789' )
-				->setItemType( 4 )
-				->setRevisionTime( '2014-02-27T11:40:12Z' )
-				->setEnglishLabel( 'cats' )
-				->setItemJson( 'json be here' )
-				->setNumericItemId( 1000 )
+			(new ItemRow())
+				->setPageTitle('Item:Q1000')
+				->setRevisionId('123456789')
+				->setItemType(4)
+				->setRevisionTime('2014-02-27T11:40:12Z')
+				->setEnglishLabel('cats')
+				->setItemJson('json be here')
+				->setNumericItemId(1000)
 		);
 
-		$infoSets = $this->store->getItemInfo(  10, 0 );
-		$this->assertCount( 1, $infoSets );
-		$this->assertSame( 4, $infoSets[0]->getItemType() );
+		$infoSets = $this->store->getItemInfo(10, 0);
+		$this->assertCount(1, $infoSets);
+		$this->assertSame(4, $infoSets[0]->getItemType());
 	}
 
 	public function testWhenStoreNotInitialized_deleteItemByIdThrowsException() {
-		$this->createStore( self::WITHOUT_INSTALLING );
-		$this->setExpectedException( 'Queryr\EntityStore\EntityStoreException' );
-		$this->store->deleteItemById( new ItemId( 'Q1' ) );
+		$this->createStore(self::WITHOUT_INSTALLING);
+		$this->setExpectedException('Queryr\EntityStore\EntityStoreException');
+		$this->store->deleteItemById(new ItemId('Q1'));
 	}
 
 	public function testGivenNonExistingId_deleteItemByIdDoesNotDeleteItems() {
-		$this->createStore( self::AND_INSTALL );
+		$this->createStore(self::AND_INSTALL);
 
 		$this->store->storeItemRow(
-			( new ItemRow() )
-				->setPageTitle( 'Item:Q1000' )
-				->setRevisionId( '123456' )
-				->setItemType( 5 )
-				->setRevisionTime( '2014-02-27T11:40:12Z' )
-				->setEnglishLabel( 'kittens' )
-				->setItemJson( 'json be here' )
-				->setNumericItemId( 1000 )
+			(new ItemRow())
+				->setPageTitle('Item:Q1000')
+				->setRevisionId('123456')
+				->setItemType(5)
+				->setRevisionTime('2014-02-27T11:40:12Z')
+				->setEnglishLabel('kittens')
+				->setItemJson('json be here')
+				->setNumericItemId(1000)
 		);
 
-		$this->store->deleteItemById( new ItemId( 'Q1001' ) );
+		$this->store->deleteItemById(new ItemId('Q1001'));
 
-		$this->assertCount( 1, $this->store->getItemInfo(  10, 0 ) );
+		$this->assertCount(1, $this->store->getItemInfo(10, 0));
 	}
 
 	public function testGivenExistingId_deleteItemByIdDeletesItem() {
-		$this->createStore( self::AND_INSTALL );
+		$this->createStore(self::AND_INSTALL);
 
 		$this->store->storeItemRow(
-			( new ItemRow() )
-				->setPageTitle( 'Item:Q1000' )
-				->setRevisionId( '123456' )
-				->setItemType( 5 )
-				->setRevisionTime( '2014-02-27T11:40:12Z' )
-				->setEnglishLabel( 'kittens' )
-				->setItemJson( 'json be here' )
-				->setNumericItemId( 1000 )
+			(new ItemRow())
+				->setPageTitle('Item:Q1000')
+				->setRevisionId('123456')
+				->setItemType(5)
+				->setRevisionTime('2014-02-27T11:40:12Z')
+				->setEnglishLabel('kittens')
+				->setItemJson('json be here')
+				->setNumericItemId(1000)
 		);
 
-		$this->store->deleteItemById( new ItemId( 'Q1000' ) );
+		$this->store->deleteItemById(new ItemId('Q1000'));
 
-		$this->assertCount( 0, $this->store->getItemInfo(  10, 0 ) );
+		$this->assertCount(0, $this->store->getItemInfo(10, 0));
 	}
 
 	public function testGivenNotExistingPage_getIdForEnWikiPageReturnsNull() {
-		$this->createStore( self::AND_INSTALL );
+		$this->createStore(self::AND_INSTALL);
 
-		$this->assertNull( $this->store->getIdForEnWikiPage( 'kittens' ) );
+		$this->assertNull($this->store->getIdForEnWikiPage('kittens'));
 	}
 
 	public function testWhenStoreNotInitialized_getIdForEnWikiPageThrowsException() {
-		$this->createStore( self::WITHOUT_INSTALLING );
-		$this->setExpectedException( 'Queryr\EntityStore\EntityStoreException' );
-		$this->assertNull( $this->store->getIdForEnWikiPage( 'kittens' ) );
+		$this->createStore(self::WITHOUT_INSTALLING);
+		$this->setExpectedException('Queryr\EntityStore\EntityStoreException');
+		$this->assertNull($this->store->getIdForEnWikiPage('kittens'));
 	}
 
 	public function testGivenExistingPage_getIdForEnWikiPageReturnsPage() {
-		$this->createStore( self::AND_INSTALL );
+		$this->createStore(self::AND_INSTALL);
 
 		$this->store->storeItemRow(
-			( new ItemRow() )
-				->setPageTitle( 'Item:Q55555' )
-				->setRevisionId( '55555555' )
-				->setItemType( 5 )
-				->setRevisionTime( '2014-02-27T11:40:12Z' )
-				->setEnglishWikipediaTitle( 'cats' )
-				->setItemJson( 'json be here' )
-				->setNumericItemId( 55555 )
+			(new ItemRow())
+				->setPageTitle('Item:Q55555')
+				->setRevisionId('55555555')
+				->setItemType(5)
+				->setRevisionTime('2014-02-27T11:40:12Z')
+				->setEnglishWikipediaTitle('cats')
+				->setItemJson('json be here')
+				->setNumericItemId(55555)
 		);
 
 		$this->store->storeItemRow(
-			( new ItemRow() )
-				->setPageTitle( 'Item:Q1000' )
-				->setRevisionId( '123456' )
-				->setItemType( 1 )
-				->setRevisionTime( '2014-02-27T11:40:12Z' )
-				->setEnglishWikipediaTitle( 'kittens' )
-				->setItemJson( 'json be here' )
-				->setNumericItemId( 1000 )
+			(new ItemRow())
+				->setPageTitle('Item:Q1000')
+				->setRevisionId('123456')
+				->setItemType(1)
+				->setRevisionTime('2014-02-27T11:40:12Z')
+				->setEnglishWikipediaTitle('kittens')
+				->setItemJson('json be here')
+				->setNumericItemId(1000)
 		);
 
 		$this->store->storeItemRow(
-			( new ItemRow() )
-				->setPageTitle( 'Item:Q999999' )
-				->setRevisionId( '9999999' )
-				->setItemType( 9 )
-				->setRevisionTime( '2014-02-27T11:40:12Z' )
-				->setEnglishWikipediaTitle( 'fluff' )
-				->setItemJson( 'json be here' )
-				->setNumericItemId( 999999 )
+			(new ItemRow())
+				->setPageTitle('Item:Q999999')
+				->setRevisionId('9999999')
+				->setItemType(9)
+				->setRevisionTime('2014-02-27T11:40:12Z')
+				->setEnglishWikipediaTitle('fluff')
+				->setItemJson('json be here')
+				->setNumericItemId(999999)
 		);
 
 		$this->assertEquals(
-			new ItemId( 'Q1000' ),
-			$this->store->getIdForEnWikiPage( 'kittens' )
+			new ItemId('Q1000'),
+			$this->store->getIdForEnWikiPage('kittens')
 		);
 	}
 

tests/integration/StoreNotInstalledTest.php

Spacing +3 added lines, -3 removed lines

@@ -22,12 +22,12 @@
 		$connection = TestFixtureFactory::newInstance()->newConnection();
 		$config = new EntityStoreConfig();
 
-		$this->factory = new EntityStoreFactory( $connection, $config );
+		$this->factory = new EntityStoreFactory($connection, $config);
 	}
 
 	public function testPropertyTypeLookupThrowsExceptionWhenStoreNotInstalled() {
-		$this->setExpectedException( 'Queryr\EntityStore\PropertyTypeLookupException' );
-		$this->factory->newPropertyTypeLookup()->getTypeOfProperty( new PropertyId( 'P2'  ) );
+		$this->setExpectedException('Queryr\EntityStore\PropertyTypeLookupException');
+		$this->factory->newPropertyTypeLookup()->getTypeOfProperty(new PropertyId('P2'));
 	}
 
 }

tests/integration/EntityStoreInfoFetchingTest.php

Spacing +47 added lines, -47 removed lines

@@ -45,38 +45,38 @@ 
 		$connection = TestFixtureFactory::newInstance()->newConnection();
 		$config = new EntityStoreConfig();
 
-		$installer = new EntityStoreInstaller( $connection->getSchemaManager(), $config );
+		$installer = new EntityStoreInstaller($connection->getSchemaManager(), $config);
 		$installer->install();
 
-		$this->store = ( new EntityStoreFactory( $connection, $config ) )->newEntityStore();
+		$this->store = (new EntityStoreFactory($connection, $config))->newEntityStore();
 	}
 
 	private function insertItemRows() {
-		foreach ( [ 1, 10, 2, 9, 8, 7, 3, 4, 6, 5 ] as $integer ) {
-			$row = ( new ItemRow() )
-				->setItemJson( 'json be here ' . $integer )
-				->setEnglishLabel( 'item ' . $integer )
-				->setItemType( $integer + 1 )
-				->setRevisionTime( '2014-02-27T11:40:' . $integer . 'Z' )
-				->setRevisionId( '424242' . $integer )
-				->setNumericItemId( $integer )
-				->setPageTitle( 'Item:Q' . $integer );
+		foreach ([1, 10, 2, 9, 8, 7, 3, 4, 6, 5] as $integer) {
+			$row = (new ItemRow())
+				->setItemJson('json be here '.$integer)
+				->setEnglishLabel('item '.$integer)
+				->setItemType($integer + 1)
+				->setRevisionTime('2014-02-27T11:40:'.$integer.'Z')
+				->setRevisionId('424242'.$integer)
+				->setNumericItemId($integer)
+				->setPageTitle('Item:Q'.$integer);
 
 			$this->itemInfos[$integer] = $row->getItemInfo();
 
-			$this->store->storeItemRow( $row );
+			$this->store->storeItemRow($row);
 		}
 
-		sort( $this->itemInfos );
+		sort($this->itemInfos);
 	}
 
 	private function insertPropertyRows() {
-		foreach ( [ 101, 110, 102, 109, 108, 107, 103, 104, 106, 105 ] as $integer ) {
+		foreach ([101, 110, 102, 109, 108, 107, 103, 104, 106, 105] as $integer) {
 			$info = new PropertyInfo(
 				$integer,
-				'Property:P' . $integer,
-				'424242' . $integer,
-				$integer . '4-02-27T11:40:12Z',
+				'Property:P'.$integer,
+				'424242'.$integer,
+				$integer.'4-02-27T11:40:12Z',
 				'string'
 			);
 
@@ -84,103 +84,103 @@ 
 
 			$this->store->storePropertyRow(
 				new PropertyRow(
-					'json be here ' . $integer,
+					'json be here '.$integer,
 					$info
 				)
 			);
 		}
 
-		sort( $this->propertyInfos );
+		sort($this->propertyInfos);
 	}
 
 	public function testGivenLimitBiggerThanSet_getPropertyInfoReturnsAllRows() {
-		$propertyInfoSets = $this->store->getPropertyInfo( 100, 0 );
+		$propertyInfoSets = $this->store->getPropertyInfo(100, 0);
 
-		$this->assertIsPropertyInfoArray( $propertyInfoSets );
+		$this->assertIsPropertyInfoArray($propertyInfoSets);
 		$this->assertEquals(
-			array_values( $this->propertyInfos ),
+			array_values($this->propertyInfos),
 			$propertyInfoSets
 		);
 	}
 
 	public function testGivenLimitSmallerThanSet_getPropertyInfoReturnsLimitedRows() {
-		$propertyInfoSets = $this->store->getPropertyInfo( 5, 0 );
+		$propertyInfoSets = $this->store->getPropertyInfo(5, 0);
 
-		$this->assertIsPropertyInfoArray( $propertyInfoSets );
+		$this->assertIsPropertyInfoArray($propertyInfoSets);
 		$this->assertEquals(
-			array_values( array_slice(  $this->propertyInfos, 0, 5 ) ),
+			array_values(array_slice($this->propertyInfos, 0, 5)),
 			$propertyInfoSets
 		);
 	}
 
 	public function testGivenOffsetSmallerThanSet_getPropertyInfoReturnsPagedRows() {
-		$propertyInfoSets = $this->store->getPropertyInfo( 5, 7 );
+		$propertyInfoSets = $this->store->getPropertyInfo(5, 7);
 
-		$this->assertIsPropertyInfoArray( $propertyInfoSets );
+		$this->assertIsPropertyInfoArray($propertyInfoSets);
 		$this->assertEquals(
-			array_values( array_slice(  $this->propertyInfos, 7, 5 ) ),
+			array_values(array_slice($this->propertyInfos, 7, 5)),
 			$propertyInfoSets
 		);
 	}
 
 	public function testGivenOffsetBiggerThanSet_getPropertyInfoReturnsEmptyArray() {
-		$propertyInfoSets = $this->store->getPropertyInfo( 5, 20 );
+		$propertyInfoSets = $this->store->getPropertyInfo(5, 20);
 
-		$this->assertIsPropertyInfoArray( $propertyInfoSets );
+		$this->assertIsPropertyInfoArray($propertyInfoSets);
 		$this->assertEquals(
 			[],
 			$propertyInfoSets
 		);
 	}
 
-	private function assertIsPropertyInfoArray( $info ) {
-		$this->assertInternalType( 'array', $info );
-		$this->assertContainsOnlyInstancesOf( 'Queryr\EntityStore\Data\PropertyInfo', $info );
+	private function assertIsPropertyInfoArray($info) {
+		$this->assertInternalType('array', $info);
+		$this->assertContainsOnlyInstancesOf('Queryr\EntityStore\Data\PropertyInfo', $info);
 	}
 
 	public function testGivenLimitBiggerThanSet_getItemInfoReturnsAllRows() {
-		$itemInfoSets = $this->store->getItemInfo( 100, 0 );
+		$itemInfoSets = $this->store->getItemInfo(100, 0);
 
-		$this->assertIsItemInfoArray( $itemInfoSets );
+		$this->assertIsItemInfoArray($itemInfoSets);
 		$this->assertEquals(
-			array_values( $this->itemInfos ),
+			array_values($this->itemInfos),
 			$itemInfoSets
 		);
 	}
 
 	public function testGivenLimitSmallerThanSet_getItemInfoReturnsLimitedRows() {
-		$itemInfoSets = $this->store->getItemInfo( 5, 0 );
+		$itemInfoSets = $this->store->getItemInfo(5, 0);
 
-		$this->assertIsItemInfoArray( $itemInfoSets );
+		$this->assertIsItemInfoArray($itemInfoSets);
 		$this->assertEquals(
-			array_values( array_slice(  $this->itemInfos, 0, 5 ) ),
+			array_values(array_slice($this->itemInfos, 0, 5)),
 			$itemInfoSets
 		);
 	}
 
 	public function testGivenOffsetSmallerThanSet_getItemInfoReturnsPagedRows() {
-		$itemInfoSets = $this->store->getItemInfo( 5, 7 );
+		$itemInfoSets = $this->store->getItemInfo(5, 7);
 
-		$this->assertIsItemInfoArray( $itemInfoSets );
+		$this->assertIsItemInfoArray($itemInfoSets);
 		$this->assertEquals(
-			array_values( array_slice(  $this->itemInfos, 7, 5 ) ),
+			array_values(array_slice($this->itemInfos, 7, 5)),
 			$itemInfoSets
 		);
 	}
 
 	public function testGivenOffsetBiggerThanSet_getItemInfoReturnsEmptyArray() {
-		$itemInfoSets = $this->store->getItemInfo( 5, 20 );
+		$itemInfoSets = $this->store->getItemInfo(5, 20);
 
-		$this->assertIsItemInfoArray( $itemInfoSets );
+		$this->assertIsItemInfoArray($itemInfoSets);
 		$this->assertEquals(
 			[],
 			$itemInfoSets
 		);
 	}
 
-	private function assertIsItemInfoArray( $info ) {
-		$this->assertInternalType( 'array', $info );
-		$this->assertContainsOnlyInstancesOf( 'Queryr\EntityStore\Data\ItemInfo', $info );
+	private function assertIsItemInfoArray($info) {
+		$this->assertInternalType('array', $info);
+		$this->assertContainsOnlyInstancesOf('Queryr\EntityStore\Data\ItemInfo', $info);
 	}
 
 }

tests/integration/PropertyStoreTest.php

Spacing +46 added lines, -46 removed lines

@@ -38,16 +38,16 @@ 
 		$this->createPropertyRowField();
 	}
 
-	private function createStore( $doDbInstall = false ) {
+	private function createStore($doDbInstall = false) {
 		$connection = TestFixtureFactory::newInstance()->newConnection();
 		$config = new EntityStoreConfig();
 
-		if ( $doDbInstall ) {
-			$installer = new EntityStoreInstaller( $connection->getSchemaManager(), $config );
+		if ($doDbInstall) {
+			$installer = new EntityStoreInstaller($connection->getSchemaManager(), $config);
 			$installer->install();
 		}
 
-		$this->store = ( new EntityStoreFactory( $connection, $config ) )->newPropertyStore();
+		$this->store = (new EntityStoreFactory($connection, $config))->newPropertyStore();
 	}
 
 	private function createPropertyRowField() {
@@ -64,49 +64,49 @@ 
 	}
 
 	public function testCanStoreAndRetrievePropertyPage() {
-		$this->createStore( self::AND_INSTALL );
+		$this->createStore(self::AND_INSTALL);
 
-		$this->store->storePropertyRow( $this->propertyRow );
+		$this->store->storePropertyRow($this->propertyRow);
 
-		$newPropertyRow = $this->store->getPropertyRowByNumericPropertyId( self::PROPERTY_ID );
+		$newPropertyRow = $this->store->getPropertyRowByNumericPropertyId(self::PROPERTY_ID);
 
-		$this->assertInstanceOf( 'Queryr\EntityStore\Data\PropertyRow', $newPropertyRow );
+		$this->assertInstanceOf('Queryr\EntityStore\Data\PropertyRow', $newPropertyRow);
 
-		$this->assertSame( $this->propertyRow->getNumericPropertyId(), $newPropertyRow->getNumericPropertyId() );
-		$this->assertSame( $this->propertyRow->getPropertyJson(), $newPropertyRow->getPropertyJson() );
-		$this->assertSame( $this->propertyRow->getPageTitle(), $newPropertyRow->getPageTitle() );
-		$this->assertSame( $this->propertyRow->getRevisionId(), $newPropertyRow->getRevisionId() );
-		$this->assertSame( $this->propertyRow->getRevisionTime(), $newPropertyRow->getRevisionTime() );
-		$this->assertSame( $this->propertyRow->getPropertyType(), $newPropertyRow->getPropertyType() );
+		$this->assertSame($this->propertyRow->getNumericPropertyId(), $newPropertyRow->getNumericPropertyId());
+		$this->assertSame($this->propertyRow->getPropertyJson(), $newPropertyRow->getPropertyJson());
+		$this->assertSame($this->propertyRow->getPageTitle(), $newPropertyRow->getPageTitle());
+		$this->assertSame($this->propertyRow->getRevisionId(), $newPropertyRow->getRevisionId());
+		$this->assertSame($this->propertyRow->getRevisionTime(), $newPropertyRow->getRevisionTime());
+		$this->assertSame($this->propertyRow->getPropertyType(), $newPropertyRow->getPropertyType());
 	}
 
 	public function testGivenNotKnownId_getPropertyRowByNumericPropertyIdReturnsNull() {
-		$this->createStore( self::AND_INSTALL );
-		$this->assertNull( $this->store->getPropertyRowByNumericPropertyId( '32202' ) );
+		$this->createStore(self::AND_INSTALL);
+		$this->assertNull($this->store->getPropertyRowByNumericPropertyId('32202'));
 	}
 
 	public function testWhenStoreNotInitialized_storePropertyRowThrowsException() {
-		$this->createStore( self::WITHOUT_INSTALLING );
-		$this->setExpectedException( 'Queryr\EntityStore\EntityStoreException' );
-		$this->store->storePropertyRow( $this->propertyRow );
+		$this->createStore(self::WITHOUT_INSTALLING);
+		$this->setExpectedException('Queryr\EntityStore\EntityStoreException');
+		$this->store->storePropertyRow($this->propertyRow);
 	}
 
 	public function testWhenStoreNotInitialized_getPropertyRowByNumericPropertyIdThrowsException() {
-		$this->createStore( self::WITHOUT_INSTALLING );
-		$this->setExpectedException( 'Queryr\EntityStore\EntityStoreException' );
-		$this->store->getPropertyRowByNumericPropertyId( 1 );
+		$this->createStore(self::WITHOUT_INSTALLING);
+		$this->setExpectedException('Queryr\EntityStore\EntityStoreException');
+		$this->store->getPropertyRowByNumericPropertyId(1);
 	}
 
 	public function testWhenStoreNotInitialized_getPropertyInfoThrowsException() {
-		$this->createStore( self::WITHOUT_INSTALLING );
-		$this->setExpectedException( 'Queryr\EntityStore\EntityStoreException' );
-		$this->store->getPropertyInfo( 10, 0 );
+		$this->createStore(self::WITHOUT_INSTALLING);
+		$this->setExpectedException('Queryr\EntityStore\EntityStoreException');
+		$this->store->getPropertyInfo(10, 0);
 	}
 
 	public function testInsertingExistingPropertyOverridesTheOriginalOne() {
-		$this->createStore( self::AND_INSTALL );
+		$this->createStore(self::AND_INSTALL);
 
-		$this->store->storePropertyRow( new PropertyRow(
+		$this->store->storePropertyRow(new PropertyRow(
 			'json be here',
 			new PropertyInfo(
 				42,
@@ -115,9 +115,9 @@ 
 				'2014-02-27T11:40:12Z',
 				'string'
 			)
-		) );
+		));
 
-		$this->store->storePropertyRow( new PropertyRow(
+		$this->store->storePropertyRow(new PropertyRow(
 			'json be here',
 			new PropertyInfo(
 				42,
@@ -126,23 +126,23 @@ 
 				'2014-02-27T11:40:12Z',
 				'kittens'
 			)
-		) );
+		));
 
-		$infoSets = $this->store->getPropertyInfo(  10, 0 );
-		$this->assertCount( 1, $infoSets );
-		$this->assertSame( 'kittens', $infoSets[0]->getPropertyType() );
+		$infoSets = $this->store->getPropertyInfo(10, 0);
+		$this->assertCount(1, $infoSets);
+		$this->assertSame('kittens', $infoSets[0]->getPropertyType());
 	}
 
 	public function testWhenStoreNotInitialized_deleteItemByIdThrowsException() {
-		$this->createStore( self::WITHOUT_INSTALLING );
-		$this->setExpectedException( 'Queryr\EntityStore\EntityStoreException' );
-		$this->store->deletePropertyById( new PropertyId( 'P1' ) );
+		$this->createStore(self::WITHOUT_INSTALLING);
+		$this->setExpectedException('Queryr\EntityStore\EntityStoreException');
+		$this->store->deletePropertyById(new PropertyId('P1'));
 	}
 
 	public function testGivenNonExistingId_deleteItemByIdDoesNotDeleteItems() {
-		$this->createStore( self::AND_INSTALL );
+		$this->createStore(self::AND_INSTALL);
 
-		$this->store->storePropertyRow( new PropertyRow(
+		$this->store->storePropertyRow(new PropertyRow(
 			'json be here',
 			new PropertyInfo(
 				42,
@@ -151,17 +151,17 @@ 
 				'2014-02-27T11:40:12Z',
 				'string'
 			)
-		) );
+		));
 
-		$this->store->deletePropertyById( new PropertyId( 'P43' ) );
+		$this->store->deletePropertyById(new PropertyId('P43'));
 
-		$this->assertCount( 1, $this->store->getPropertyInfo(  10, 0 ) );
+		$this->assertCount(1, $this->store->getPropertyInfo(10, 0));
 	}
 
 	public function testGivenExistingId_deleteItemByIdDeletesItem() {
-		$this->createStore( self::AND_INSTALL );
+		$this->createStore(self::AND_INSTALL);
 
-		$this->store->storePropertyRow( new PropertyRow(
+		$this->store->storePropertyRow(new PropertyRow(
 			'json be here',
 			new PropertyInfo(
 				42,
@@ -170,11 +170,11 @@ 
 				'2014-02-27T11:40:12Z',
 				'string'
 			)
-		) );
+		));
 
-		$this->store->deletePropertyById( new PropertyId( 'P42' ) );
+		$this->store->deletePropertyById(new PropertyId('P42'));
 
-		$this->assertCount( 0, $this->store->getPropertyInfo(  10, 0 ) );
+		$this->assertCount(0, $this->store->getPropertyInfo(10, 0));
 	}
 
 }

tests/unit/InstanceOfTypeExtractorTest.php

Spacing +8 added lines, -8 removed lines

@@ -20,33 +20,33 @@
 	const INSTANCEOF_PROP_ID = 31;
 
 	public function testGivenEmptyItem_nullIsReturned() {
-		$this->assertNull( ( new InstanceOfTypeExtractor() )->getTypeOfItem( new Item() ) );
+		$this->assertNull((new InstanceOfTypeExtractor())->getTypeOfItem(new Item()));
 	}
 
 	public function testGivenBerlin_then515isReturned() {
 		$this->assertSame(
 			515,
-			( new InstanceOfTypeExtractor() )->getTypeOfItem( ( new Berlin() )->newItem() )
+			(new InstanceOfTypeExtractor())->getTypeOfItem((new Berlin())->newItem())
 		);
 	}
 
 	public function testGivenItemWithNoValueType_nullIsReturned() {
 		$item = new Item();
 
-		$item->getStatements()->addNewStatement( new PropertyNoValueSnak( self::INSTANCEOF_PROP_ID ) );
+		$item->getStatements()->addNewStatement(new PropertyNoValueSnak(self::INSTANCEOF_PROP_ID));
 
-		$this->assertNull( ( new InstanceOfTypeExtractor() )->getTypeOfItem( $item ) );
+		$this->assertNull((new InstanceOfTypeExtractor())->getTypeOfItem($item));
 	}
 
 	public function testGivenItemWithNonIdType_nullIsReturned() {
 		$item = new Item();
 
-		$item->getStatements()->addNewStatement( new PropertyValueSnak(
+		$item->getStatements()->addNewStatement(new PropertyValueSnak(
 			self::INSTANCEOF_PROP_ID,
-			new StringValue( 'not an id' )
-		) );
+			new StringValue('not an id')
+		));
 
-		$this->assertNull( ( new InstanceOfTypeExtractor() )->getTypeOfItem( $item ) );
+		$this->assertNull((new InstanceOfTypeExtractor())->getTypeOfItem($item));
 	}
 
 }
\ No newline at end of file

tests/unit/ItemRowFactoryTest.php

Spacing +29 added lines, -29 removed lines

@@ -16,77 +16,77 @@
 
 	public function testNewRowForBerlin() {
 		$itemRow = $this->newFactory()->newFromItemAndPageInfo(
-			( new Berlin() )->newItem(),
+			(new Berlin())->newItem(),
 			$this->newPageInfo()
 		);
 
-		$this->assertSame( 'kittens', $itemRow->getPageTitle() );
-		$this->assertSame( '0000', $itemRow->getRevisionTime() );
-		$this->assertSame( 9001, $itemRow->getRevisionId() );
+		$this->assertSame('kittens', $itemRow->getPageTitle());
+		$this->assertSame('0000', $itemRow->getRevisionTime());
+		$this->assertSame(9001, $itemRow->getRevisionId());
 
-		$this->assertSame( 64, $itemRow->getNumericItemId() );
-		$this->assertSame( 'Berlin', $itemRow->getEnglishLabel() );
-		$this->assertSame( 'Berlin', $itemRow->getEnglishWikipediaTitle() );
-		$this->assertSame( '["the","serialization"]', $itemRow->getItemJson() );
-		$this->assertSame( 42, $itemRow->getItemType() );
+		$this->assertSame(64, $itemRow->getNumericItemId());
+		$this->assertSame('Berlin', $itemRow->getEnglishLabel());
+		$this->assertSame('Berlin', $itemRow->getEnglishWikipediaTitle());
+		$this->assertSame('["the","serialization"]', $itemRow->getItemJson());
+		$this->assertSame(42, $itemRow->getItemType());
 	}
 
 	public function testNewRowForItemWithoutEnglishLabel() {
-		$item = ( new Berlin() )->newItem();
-		$item->getFingerprint()->removeLabel( 'en' );
+		$item = (new Berlin())->newItem();
+		$item->getFingerprint()->removeLabel('en');
 
 		$itemRow = $this->newFactory()->newFromItemAndPageInfo(
 			$item,
 			$this->newPageInfo()
 		);
 
-		$this->assertNull( $itemRow->getEnglishLabel() );
+		$this->assertNull($itemRow->getEnglishLabel());
 	}
 
 	public function testNewRowForItemWithoutType() {
 		$factory = new ItemRowFactory(
 			$this->newStubItemSerializer(),
-			$this->newStubTypeExtractor( null )
+			$this->newStubTypeExtractor(null)
 		);
 
 		$itemRow = $factory->newFromItemAndPageInfo(
-			( new Berlin() )->newItem(),
+			(new Berlin())->newItem(),
 			$this->newPageInfo()
 		);
 
-		$this->assertNull( $itemRow->getItemType() );
+		$this->assertNull($itemRow->getItemType());
 	}
 
 	private function newFactory() {
 		return new ItemRowFactory(
 			$this->newStubItemSerializer(),
-			$this->newStubTypeExtractor( 42 )
+			$this->newStubTypeExtractor(42)
 		);
 	}
 
 	private function newPageInfo() {
-		return ( new EntityPageInfo() )
-			->setPageTitle( 'kittens' )
-			->setRevisionTime( '0000' )
-			->setRevisionId( '9001' );
+		return (new EntityPageInfo())
+			->setPageTitle('kittens')
+			->setRevisionTime('0000')
+			->setRevisionId('9001');
 	}
 
 	private function newStubItemSerializer() {
-		$serializer = $this->getMock( 'Serializers\Serializer' );
+		$serializer = $this->getMock('Serializers\Serializer');
 
-		$serializer->expects( $this->any() )
-			->method( 'serialize' )
-			->will( $this->returnValue( [ 'the', 'serialization' ] ) );
+		$serializer->expects($this->any())
+			->method('serialize')
+			->will($this->returnValue(['the', 'serialization']));
 
 		return $serializer;
 	}
 
-	private function newStubTypeExtractor( $returnValue ) {
-		$extractor = $this->getMock( 'Queryr\EntityStore\ItemTypeExtractor' );
+	private function newStubTypeExtractor($returnValue) {
+		$extractor = $this->getMock('Queryr\EntityStore\ItemTypeExtractor');
 
-		$extractor->expects( $this->any() )
-			->method( 'getTypeOfItem' )
-			->will( $this->returnValue( $returnValue ) );
+		$extractor->expects($this->any())
+			->method('getTypeOfItem')
+			->will($this->returnValue($returnValue));
 
 		return $extractor;
 	}

tests/fixtures/TestFixtureFactory.php

Spacing +2 added lines, -2 removed lines

@@ -11,10 +11,10 @@
 	}
 
 	public function newConnection() {
-		return DriverManager::getConnection( array(
+		return DriverManager::getConnection(array(
 			'driver' => 'pdo_sqlite',
 			'memory' => true,
-		) );
+		));
 	}
 
 }
\ No newline at end of file

tests/bootstrap.php

Spacing +9 added lines, -9 removed lines

@@ -1,18 +1,18 @@
 <?php
 
-if ( PHP_SAPI !== 'cli' ) {
-	die( 'Not an entry point' );
+if (PHP_SAPI !== 'cli') {
+	die('Not an entry point');
 }
 
-error_reporting( E_ALL | E_STRICT );
-ini_set( 'display_errors', 1 );
+error_reporting(E_ALL | E_STRICT);
+ini_set('display_errors', 1);
 
-if ( !is_readable( __DIR__ . '/../vendor/autoload.php' ) ) {
-	die( 'You need to install this package with Composer before you can run the tests' );
+if (!is_readable(__DIR__.'/../vendor/autoload.php')) {
+	die('You need to install this package with Composer before you can run the tests');
 }
 
-$autoLoader = require __DIR__ . '/../vendor/autoload.php';
+$autoLoader = require __DIR__.'/../vendor/autoload.php';
 
-$autoLoader->addPsr4( 'Tests\\Queryr\\EntityStore\\Fixtures\\', 'tests/fixtures/' );
+$autoLoader->addPsr4('Tests\\Queryr\\EntityStore\\Fixtures\\', 'tests/fixtures/');
 
-unset( $autoLoader );
\ No newline at end of file
+unset($autoLoader);
\ No newline at end of file