JeroenDeDauw / EntityStore

src/Data/EntityPageInfo.php

Spacing +3 added lines, -3 removed lines

@@ -39,7 +39,7 @@ 
 	 * @param string $pageTitle
 	 * @return $this
 	 */
-	public function setPageTitle( $pageTitle ) {
+	public function setPageTitle($pageTitle) {
 		$this->pageTitle = $pageTitle;
 		return $this;
 	}
@@ -48,7 +48,7 @@ 
 	 * @param int|string $revisionId
 	 * @return $this
 	 */
-	public function setRevisionId( $revisionId ) {
+	public function setRevisionId($revisionId) {
 		$this->revisionId = (int)$revisionId;
 		return $this;
 	}
@@ -57,7 +57,7 @@ 
 	 * @param string $revisionTime
 	 * @return $this
 	 */
-	public function setRevisionTime( $revisionTime ) {
+	public function setRevisionTime($revisionTime) {
 		$this->revisionTime = $revisionTime;
 		return $this;
 	}

src/EntityStoreFactory.php

Spacing +4 added lines, -4 removed lines

@@ -13,7 +13,7 @@ 
 	private $connection;
 	private $config;
 
-	public function __construct( Connection $connection, EntityStoreConfig $config ) {
+	public function __construct(Connection $connection, EntityStoreConfig $config) {
 		$this->connection = $connection;
 		$this->config = $config;
 	}
@@ -26,15 +26,15 @@ 
 	}
 
 	public function newItemStore() {
-		return new ItemStore( $this->connection, $this->config->getItemTableName() );
+		return new ItemStore($this->connection, $this->config->getItemTableName());
 	}
 
 	public function newPropertyStore() {
-		return new PropertyStore( $this->connection, $this->config->getPropertyTableName() );
+		return new PropertyStore($this->connection, $this->config->getPropertyTableName());
 	}
 
 	public function newPropertyTypeLookup() {
-		return new PropertyTypeLookup( $this->connection, $this->config->getPropertyTableName() );
+		return new PropertyTypeLookup($this->connection, $this->config->getPropertyTableName());
 	}
 
 }
\ No newline at end of file

src/InstanceOfTypeExtractor.php

Spacing +7 added lines, -7 removed lines

@@ -21,7 +21,7 @@ 
 	private $instanceOfPropertyId;
 
 	public function __construct() {
-		$this->instanceOfPropertyId = new PropertyId( 'P31' );
+		$this->instanceOfPropertyId = new PropertyId('P31');
 	}
 
 	/**
@@ -31,23 +31,23 @@ 
 	 *
 	 * @return int|null
 	 */
-	public function getTypeOfItem( Item $item ) {
+	public function getTypeOfItem(Item $item) {
 		/**
 		 * @var Statement $statement
 		 */
-		foreach ( $item->getStatements() as $statement ) {
-			if ( $statement->getPropertyId()->equals( $this->instanceOfPropertyId ) ) {
+		foreach ($item->getStatements() as $statement) {
+			if ($statement->getPropertyId()->equals($this->instanceOfPropertyId)) {
 				$valueSnak = $statement->getMainSnak();
 
-				if ( $valueSnak instanceof PropertyValueSnak ) {
+				if ($valueSnak instanceof PropertyValueSnak) {
 					$value = $valueSnak->getDataValue();
 
 
-					if ( $value instanceof EntityIdValue ) {
+					if ($value instanceof EntityIdValue) {
 
 						$itemId = $value->getEntityId();
 
-						if ( $itemId instanceof ItemId ) {
+						if ($itemId instanceof ItemId) {
 							return $itemId->getNumericId();
 						}
 					}

src/PropertyStore.php

Spacing +32 added lines, -32 removed lines

@@ -23,7 +23,7 @@ 
 	 * @param Connection $connection
 	 * @param string $tableName
 	 */
-	public function __construct( Connection $connection, $tableName ) {
+	public function __construct(Connection $connection, $tableName) {
 		$this->connection = $connection;
 		$this->tableName = $tableName;
 	}
@@ -33,8 +33,8 @@ 
 	 *
 	 * @throws EntityStoreException
 	 */
-	public function storePropertyRow( PropertyRow $propertyRow ) {
-		$this->deletePropertyById( PropertyId::newFromNumber( $propertyRow->getNumericPropertyId() ) );
+	public function storePropertyRow(PropertyRow $propertyRow) {
+		$this->deletePropertyById(PropertyId::newFromNumber($propertyRow->getNumericPropertyId()));
 
 		try {
 			$this->connection->insert(
@@ -51,8 +51,8 @@ 
 				)
 			);
 		}
-		catch ( DBALException $ex ) {
-			throw new EntityStoreException( $ex->getMessage(), $ex );
+		catch (DBALException $ex) {
+			throw new EntityStoreException($ex->getMessage(), $ex);
 		}
 	}
 
@@ -61,7 +61,7 @@ 
 	 *
 	 * @throws EntityStoreException
 	 */
-	public function deletePropertyById( PropertyId $propertyId ) {
+	public function deletePropertyById(PropertyId $propertyId) {
 		try {
 			$this->connection->delete(
 				$this->tableName,
@@ -70,8 +70,8 @@ 
 				]
 			);
 		}
-		catch ( DBALException $ex ) {
-			throw new EntityStoreException( $ex->getMessage(), $ex );
+		catch (DBALException $ex) {
+			throw new EntityStoreException($ex->getMessage(), $ex);
 		}
 	}
 
@@ -81,18 +81,18 @@ 
 	 * @return PropertyRow|null
 	 * @throws EntityStoreException
 	 */
-	public function getPropertyRowByNumericPropertyId( $numericPropertyId ) {
+	public function getPropertyRowByNumericPropertyId($numericPropertyId) {
 		try {
 			$rows = $this->selectProperties()
-				->where( 'property_id = ?' )
-				->setParameter( 0, (int)$numericPropertyId )
+				->where('property_id = ?')
+				->setParameter(0, (int)$numericPropertyId)
 				->execute();
 		}
-		catch ( DBALException $ex ) {
-			throw new EntityStoreException( $ex->getMessage(), $ex );
+		catch (DBALException $ex) {
+			throw new EntityStoreException($ex->getMessage(), $ex);
 		}
 
-		return $this->newPropertyRowFromResult( $rows );
+		return $this->newPropertyRowFromResult($rows);
 	}
 
 	private function selectProperties() {
@@ -103,25 +103,25 @@ 
 			'revision_id',
 			'revision_time',
 			'property_type'
-		)->from( $this->tableName );
+		)->from($this->tableName);
 	}
 
-	private function newPropertyRowFromResult( \Traversable $rows ) {
-		$rows = iterator_to_array( $rows );
+	private function newPropertyRowFromResult(\Traversable $rows) {
+		$rows = iterator_to_array($rows);
 
-		if ( count( $rows ) < 1 ) {
+		if (count($rows) < 1) {
 			return null;
 		}
 
-		$row = reset( $rows );
+		$row = reset($rows);
 
 		return new PropertyRow(
 			$row['property_json'],
-			$this->newPropertyInfoFromResultRow( $row )
+			$this->newPropertyInfoFromResultRow($row)
 		);
 	}
 
-	private function newPropertyInfoFromResultRow( array $row ) {
+	private function newPropertyInfoFromResultRow(array $row) {
 		return new PropertyInfo(
 			$row['property_id'],
 			$row['page_title'],
@@ -138,7 +138,7 @@ 
 			'revision_id',
 			'revision_time',
 			'property_type'
-		)->from( $this->tableName );
+		)->from($this->tableName);
 	}
 
 	/**
@@ -148,26 +148,26 @@ 
 	 * @return PropertyInfo[]
 	 * @throws EntityStoreException
 	 */
-	public function getPropertyInfo( $limit, $offset ) {
+	public function getPropertyInfo($limit, $offset) {
 		try {
 			$rows = $this->selectPropertyInfoSets()
-				->orderBy( 'property_id', 'asc' )
-				->setMaxResults( $limit )
-				->setFirstResult( $offset )
+				->orderBy('property_id', 'asc')
+				->setMaxResults($limit)
+				->setFirstResult($offset)
 				->execute();
 		}
-		catch ( DBALException $ex ) {
-			throw new EntityStoreException( $ex->getMessage(), $ex );
+		catch (DBALException $ex) {
+			throw new EntityStoreException($ex->getMessage(), $ex);
 		}
 
-		return $this->newPropertyInfoArrayFromResult( $rows );
+		return $this->newPropertyInfoArrayFromResult($rows);
 	}
 
-	private function newPropertyInfoArrayFromResult( \Traversable $rows ) {
+	private function newPropertyInfoArrayFromResult(\Traversable $rows) {
 		$infoList = [];
 
-		foreach ( $rows as $resultRow ) {
-			$infoList[] = $this->newPropertyInfoFromResultRow( $resultRow );
+		foreach ($rows as $resultRow) {
+			$infoList[] = $this->newPropertyInfoFromResultRow($resultRow);
 		}
 
 		return $infoList;

Braces +4 added lines, -8 removed lines

@@ -50,8 +50,7 @@ 
 					'property_type' => $propertyRow->getPropertyType(),
 				)
 			);
-		}
-		catch ( DBALException $ex ) {
+		} catch ( DBALException $ex ) {
 			throw new EntityStoreException( $ex->getMessage(), $ex );
 		}
 	}
@@ -69,8 +68,7 @@ 
 					'property_id' => $propertyId->getNumericId()
 				]
 			);
-		}
-		catch ( DBALException $ex ) {
+		} catch ( DBALException $ex ) {
 			throw new EntityStoreException( $ex->getMessage(), $ex );
 		}
 	}
@@ -87,8 +85,7 @@ 
 				->where( 'property_id = ?' )
 				->setParameter( 0, (int)$numericPropertyId )
 				->execute();
-		}
-		catch ( DBALException $ex ) {
+		} catch ( DBALException $ex ) {
 			throw new EntityStoreException( $ex->getMessage(), $ex );
 		}
 
@@ -155,8 +152,7 @@ 
 				->setMaxResults( $limit )
 				->setFirstResult( $offset )
 				->execute();
-		}
-		catch ( DBALException $ex ) {
+		} catch ( DBALException $ex ) {
 			throw new EntityStoreException( $ex->getMessage(), $ex );
 		}
 

src/EntityStoreException.php

Spacing +2 added lines, -2 removed lines

@@ -8,8 +8,8 @@
  */
 class EntityStoreException extends \RuntimeException {
 
-	public function __construct( $message, \Exception $previous = null ) {
-		parent::__construct( $message, 0, $previous );
+	public function __construct($message, \Exception $previous = null) {
+		parent::__construct($message, 0, $previous);
 	}
 
 }
\ No newline at end of file

src/PropertyTypeLookupException.php

Spacing +2 added lines, -2 removed lines

@@ -8,8 +8,8 @@
  */
 class PropertyTypeLookupException extends \RuntimeException {
 
-	public function __construct( $message, \Exception $previous = null ) {
-		parent::__construct( $message, 0, $previous );
+	public function __construct($message, \Exception $previous = null) {
+		parent::__construct($message, 0, $previous);
 	}
 
 }
\ No newline at end of file

src/EntityStoreConfig.php

Spacing +3 added lines, -3 removed lines

@@ -10,16 +10,16 @@
 
 	private $prefix;
 
-	public function __construct( $tablePrefix = '' ) {
+	public function __construct($tablePrefix = '') {
 		$this->prefix = $tablePrefix;
 	}
 
 	public function getItemTableName() {
-		return $this->prefix . 'items';
+		return $this->prefix.'items';
 	}
 
 	public function getPropertyTableName() {
-		return $this->prefix . 'properties';
+		return $this->prefix.'properties';
 	}
 
 }
\ No newline at end of file

tests/integration/PropertyTypeLookupTest.php

Spacing +7 added lines, -7 removed lines

@@ -28,7 +28,7 @@ 
 	public function setUp() {
 		$factory = $this->createFactory();
 
-		$this->insertPropertyRows( $factory->newPropertyStore() );
+		$this->insertPropertyRows($factory->newPropertyStore());
 
 		$this->lookup = $factory->newPropertyTypeLookup();
 	}
@@ -37,14 +37,14 @@ 
 		$connection = TestFixtureFactory::newInstance()->newConnection();
 		$config = new EntityStoreConfig();
 
-		$installer = new EntityStoreInstaller( $connection->getSchemaManager(), $config );
+		$installer = new EntityStoreInstaller($connection->getSchemaManager(), $config);
 		$installer->install();
 
-		return new EntityStoreFactory( $connection, $config );
+		return new EntityStoreFactory($connection, $config);
 	}
 
 
-	private function insertPropertyRows( PropertyStore $store ) {
+	private function insertPropertyRows(PropertyStore $store) {
 		$store->storePropertyRow(
 			new PropertyRow(
 				'first property',
@@ -73,15 +73,15 @@ 
 	}
 
 	public function testGivenNotKnownProperty_nullIsReturned() {
-		$this->assertNull( $this->lookup->getTypeOfProperty( new PropertyId( 'P42' ) ) );
+		$this->assertNull($this->lookup->getTypeOfProperty(new PropertyId('P42')));
 	}
 
 	public function testReturnsTypeOfP1() {
-		$this->assertEquals( 'kittens', $this->lookup->getTypeOfProperty( new PropertyId( 'P1' ) ) );
+		$this->assertEquals('kittens', $this->lookup->getTypeOfProperty(new PropertyId('P1')));
 	}
 
 	public function testReturnsTypeOfP2() {
-		$this->assertEquals( 'cats', $this->lookup->getTypeOfProperty( new PropertyId( 'P2' ) ) );
+		$this->assertEquals('cats', $this->lookup->getTypeOfProperty(new PropertyId('P2')));
 	}
 
 }

tests/integration/EntityStoreInstallerTest.php

Spacing +5 added lines, -5 removed lines

@@ -31,20 +31,20 @@
 
 		$this->storeInstaller = new EntityStoreInstaller(
 			$this->schemaManager,
-			new EntityStoreConfig( 'kittens_' )
+			new EntityStoreConfig('kittens_')
 		);
 	}
 
 	public function testInstallationAndRemoval() {
 		$this->storeInstaller->install();
 
-		$this->assertTrue( $this->schemaManager->tablesExist( 'kittens_items' ) );
-		$this->assertTrue( $this->schemaManager->tablesExist( 'kittens_properties' ) );
+		$this->assertTrue($this->schemaManager->tablesExist('kittens_items'));
+		$this->assertTrue($this->schemaManager->tablesExist('kittens_properties'));
 
 		$this->storeInstaller->uninstall();
 
-		$this->assertFalse( $this->schemaManager->tablesExist( 'kittens_items' ) );
-		$this->assertFalse( $this->schemaManager->tablesExist( 'kittens_properties' ) );
+		$this->assertFalse($this->schemaManager->tablesExist('kittens_items'));
+		$this->assertFalse($this->schemaManager->tablesExist('kittens_properties'));
 	}
 
 	public function testStoresPage() {