Issues in GuestPassService.php (master) - Issues in master - Jeroen-G/GuestPass - Measure and Improve Code Quality continuously with Scrutinizer

Issues (11)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/GuestPassService.php (8 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace JeroenG\GuestPass;

use Illuminate\Database\Eloquent\Model;

class GuestPassService
{
    /**
     * Create a new instance.
     */
    public function __construct()
    {
        // constructor body
    }

    /**
     * Register the routes.
     * @return void
     */
    public function routes()
    {
        $router = app('router');
        $router->get('gp/{owner}/{key}', 'JeroenG\GuestPass\Controllers\Access');
    }

    /**
     * Create a new Guest Pass.
     * @param  lluminate\Database\Eloquent\Model $owner

     * @param  lluminate\Database\Eloquent\Model $object

     * @param  string|null                       $view   Leave out the .blade.php extension.
     * @return bool|Exception
     */
    public function create(Model $owner, Model $object, $view = null)
    {
        try {
            GuestPass::create([

                'key' => str_random(10),
                'owner_id' => $owner->id,
                'owner_model' => get_class($owner),
                'object_id' => $object->id,
                'object_model' => get_class($object),
                'view' => $view,
            ]);

            return true;
        } catch (Exception $e) {

            return false;
        }
    }

    /**
     * Check if the given user created the Guest Pass.
     * @param  lluminate\Database\Eloquent\Model $owner

     * @param  lluminate\Database\Eloquent\Model $guestpass

     * @return bool
     */
    public function isOwner(Model $owner, Model $guestpass)
    {
        return $owner->id == $guestpass->owner_id;
    }

    /**
     * Get all keys belonging to the owner.
     * @param  lluminate\Database\Eloquent\Model  $owner

     * @return array
     */
    public function getKeysOf(Model $owner)
    {
        return GuestPass::where([
            'owner_id' => $owner->id,
            'owner_model' => get_class($owner),
        ])->get()->keyBy('key');
    }

    /**
     * Find (or fail) the Guest Pass belonging to an owner-object pairing.
     * @param  lluminate\Database\Eloquent\Model                $owner
     * @param  lluminate\Database\Eloquent\Model                $object

     * @return lluminate\Database\Eloquent\Collection|Exception
     */
    public function findGuestPass(Model $owner, Model $object)
    {
        return GuestPass::where([
            'owner_id' => $owner->id,
            'owner_model' => get_class($owner),
            'object_id' => $object->id,
            'object_model' => get_class($object),
        ])->firstOrFail();
    }

    /**
     * Get a Guest Pass by its key (or fail).
     * @param  string                                      $key
     * @return lluminate\Database\Eloquent\Model|Exception
     */
    public function getGuestPass($key)
    {
        return GuestPass::where('key', $key)->firstOrFail();
    }
}


1			<?php
2
3			namespace JeroenG\GuestPass;
4
5			use Illuminate\Database\Eloquent\Model;
6
7			class GuestPassService
8			{
9			/**
10			* Create a new instance.
11			*/
12			public function __construct()
13			{
14			// constructor body
15			}
16
17			/**
18			* Register the routes.
19			* @return void
20			*/
21			public function routes()
22			{
23			$router = app('router');
24			$router->get('gp/{owner}/{key}', 'JeroenG\GuestPass\Controllers\Access');
25			}
26
27			/**
28			* Create a new Guest Pass.
29			* @param lluminate\Database\Eloquent\Model $owner
			0 ignored issues – show Documentation introduced 2017-08-15 22:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this Should the type for parameter `$owner` not be `Model`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
30			* @param lluminate\Database\Eloquent\Model $object
			0 ignored issues – show Documentation introduced 2017-08-15 22:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this Should the type for parameter `$object` not be `Model`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
31			* @param string\|null $view Leave out the .blade.php extension.
32			* @return bool\|Exception
33			*/
34			public function create(Model $owner, Model $object, $view = null)
35			{
36			try {
37			GuestPass::create([
			0 ignored issues – show Bug introduced 2017-08-15 22:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `create()` does not exist on `JeroenG\GuestPass\GuestPass`. Did you maybe mean `created()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
38			'key' => str_random(10),
39			'owner_id' => $owner->id,
40			'owner_model' => get_class($owner),
41			'object_id' => $object->id,
42			'object_model' => get_class($object),
43			'view' => $view,
44			]);
45
46			return true;
47			} catch (Exception $e) {
			0 ignored issues – show Bug introduced 2017-08-15 22:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this The class `JeroenG\GuestPass\Exception` does not exist. Did you forget a USE statement, or did you not list all dependencies? Scrutinizer analyzes your `composer.json`/`composer.lock` file if available to determine the classes, and functions that are defined by your dependencies. It seems like the listed class was neither found in your dependencies, nor was it found in the analyzed files in your repository. If you are using some other form of dependency management, you might want to disable this analysis. Loading history...
48			return false;
49			}
50			}
51
52			/**
53			* Check if the given user created the Guest Pass.
54			* @param lluminate\Database\Eloquent\Model $owner
			0 ignored issues – show Documentation introduced 2017-08-15 22:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this Should the type for parameter `$owner` not be `Model`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
55			* @param lluminate\Database\Eloquent\Model $guestpass
			0 ignored issues – show Documentation introduced 2017-08-15 22:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this Should the type for parameter `$guestpass` not be `Model`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
56			* @return bool
57			*/
58			public function isOwner(Model $owner, Model $guestpass)
59			{
60			return $owner->id == $guestpass->owner_id;
61			}
62
63			/**
64			* Get all keys belonging to the owner.
65			* @param lluminate\Database\Eloquent\Model $owner
			0 ignored issues – show Documentation introduced 2017-08-15 22:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this Should the type for parameter `$owner` not be `Model`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
66			* @return array
67			*/
68			public function getKeysOf(Model $owner)
69			{
70			return GuestPass::where([
71			'owner_id' => $owner->id,
72			'owner_model' => get_class($owner),
73			])->get()->keyBy('key');
74			}
75
76			/**
77			* Find (or fail) the Guest Pass belonging to an owner-object pairing.
78			* @param lluminate\Database\Eloquent\Model $owner
79			* @param lluminate\Database\Eloquent\Model $object
			0 ignored issues – show Documentation introduced 2017-08-15 22:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this Should the type for parameter `$object` not be `Model`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
80			* @return lluminate\Database\Eloquent\Collection\|Exception
81			*/
82			public function findGuestPass(Model $owner, Model $object)
83			{
84			return GuestPass::where([
85			'owner_id' => $owner->id,
86			'owner_model' => get_class($owner),
87			'object_id' => $object->id,
88			'object_model' => get_class($object),
89			])->firstOrFail();
90			}
91
92			/**
93			* Get a Guest Pass by its key (or fail).
94			* @param string $key
95			* @return lluminate\Database\Eloquent\Model\|Exception
96			*/
97			public function getGuestPass($key)
98			{
99			return GuestPass::where('key', $key)->firstOrFail();
100			}
101			}
102

Jeroen-G / GuestPass

Issues (11)

Security Analysis no request data

src/GuestPassService.php (8 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like