JeroenG\Flickr\Flickr

Complexity

Total Complexity

8

Size/Duplication

Total Lines	57
Duplicated Lines	0 %

Importance

Changes	2
Bugs	1	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	photosForSet()	0	10	2
A	listSets()	0	3	1
A	photoInfo()	0	9	2
A	echoThis()	0	3	1
A	request()	0	3	1

<?php

namespace JeroenG\Flickr;

class Flickr
{
    public Api $api;

    public function __construct(Api $api)
    {
        $this->api = $api;
    }

    public function request(string $method, ?array $parameters = null): Response
    {
        return $this->api->request($method, $parameters);

The expression return $this->api->request($method, $parameters) could return the type string which is incompatible with the type-hinted return JeroenG\Flickr\Response. Consider adding an additional type-check to rule them out.

    }

    /**
     * Flickr echo request, for testing purposes.
     */
    public function echoThis(string $string): Response
    {
        return $this->request('flickr.test.echo', ['this' => $string]);
    }

    /**
     * Get a list of photosets.
     */
    public function listSets(?array $parameters = null): Response
    {
        return $this->request('flickr.photosets.getList', $parameters);
    }

    /**
     * Get all photos in a photoset.
     */
    public function photosForSet(string $setId, string $userId, ?array $otherParameters = null): Response
    {
        $parameters['photoset_id'] = $setId;

$parameters was never initialized. Although not strictly required by PHP, it is generally a good practice to add $parameters = array(); before regardless.

        $parameters['user_id'] = $userId;

        if (is_array($otherParameters)) {
            $parameters = array_merge($parameters, $otherParameters);
        }

        return $this->request('flickr.photosets.getPhotos', $parameters);
    }

    /**
     * Get all info on a photo.
     */
    public function photoInfo(string $photoId, ?string $secretId = null): Response
    {
        $parameters['photo_id'] = $photoId;

$parameters was never initialized. Although not strictly required by PHP, it is generally a good practice to add $parameters = array(); before regardless.

        if (! is_null($secretId)) {
            $parameters['secret'] = $secretId;
        }

        return $this->request('flickr.photos.getInfo', $parameters);
    }
}