JeroenG\Flickr\Api

Complexity

Total Complexity

7

Size/Duplication

Total Lines	50
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	parameters()	0	13	3
A	api()	0	3	1
A	request()	0	9	2
A	__construct()	0	10	1

<?php

namespace JeroenG\Flickr;

use GuzzleHttp\Client;

class Api
{
    protected string $key;

    protected Client $client;

    public string $format;

    public function __construct(
        string $apiKey,
        string $format = 'php_serial',
        string $endpoint = 'https://api.flickr.com/services/rest/'
    ) {
        $this->key = $apiKey;
        $this->format = $format;

        $this->client = new Client([
            'base_uri' => $endpoint,
        ]);
    }

    public function request(string $call, ?array $parameters = null)
    {
        $guzzleResponse = $this->client->get($this->api().'&method='.$call.$this->parameters($parameters));

It seems like $parameters can also be of type null; however, parameter $array of JeroenG\Flickr\Api::parameters() does only seem to accept array, maybe add an additional type check?

        if ($guzzleResponse->getStatusCode() === 200) {
            return new Response($guzzleResponse);
        }

        return 'Failed request';
    }

    protected function api(): string
    {
        return '?api_key='.$this->key.'&format='.$this->format;
    }

    protected function parameters(array $array): string
    {
        if (! is_array($array)) {

The condition is_array($array) is always true.

            return '';
        }

        $encoded = [];

        foreach ($array as $k => $v) {
            $encoded[] = urlencode($k).'='.urlencode($v);
        }

        return '&'.implode('&', $encoded);
    }
}