JanPiet\PhpTranspiler\Feature\StrictTypesFeature::fix()

Complexity

Conditions	5
Paths	7

Size

Total Lines	27
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	5.246

Importance

Changes

0

<?php declare (strict_types = 1);
    public function fix(NodeSearch $nodeSearch): bool
    {
        $found = false;

        foreach ($nodeSearch->eachType(Declare_::class) as $declareNode) {
            $newDeclares = [];

            /** @var DeclareDeclare $declareStatement */
            foreach ($declareNode->declares as $declareStatement) {
                if ($declareStatement->key === 'strict_types') {
                    $found = true;
                    continue;
                }

                $newDeclares[] = $declareNode;
            }

            if ($newDeclares) {

The expression $newDeclares of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

                $declareNode->declares = $newDeclares;
                continue;
            }

            $nodeSearch->removeNode($declareNode);
        }

        return $found;
    }
}