Issues in Routing.php (master) - Issues in master - JanHuang/fastD - Measure and Improve Code Quality continuously with Scrutinizer

Issues (30)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Console/Routing.php (6 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * @author    jan huang <[email protected]>
 * @copyright 2016
 *
 * @see      https://www.github.com/janhuang
 * @see      https://fastdlabs.com
 */

namespace FastD\Console;

use FastD\Http\ServerRequest;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Helper\Table;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;

/**
 * Class Route.
 */
class Routing extends Command
{
    public function configure()
    {
        $this
            ->setName('route')
            ->setHelp('Show all route')
            ->setDescription('Show you defined routes.')
            ->addArgument('method', InputArgument::OPTIONAL, 'Route request method.')
            ->addArgument('path', InputArgument::OPTIONAL, 'Route path.')
            ->addOption('data', 'd', InputOption::VALUE_OPTIONAL, 'Path request data.')
            ->addOption('all', 'a', InputOption::VALUE_OPTIONAL, 'Test all routes')
        ;
    }

    /**
     * @param InputInterface  $input
     * @param OutputInterface $output
     *
     * @return mixed
     */
    public function execute(InputInterface $input, OutputInterface $output)
    {
        if (empty($path = $input->getArgument('path'))) {
            $this->render($input, $output);
        } else {
            $this->test($input->getArgument('method'), $path, $input, $output);
        }

        return 0;
    }

    /**
     * @param $method
     * @param $path
     * @param InputInterface  $input
     * @param OutputInterface $output
     */
    protected function test($method, $path, InputInterface $input, OutputInterface $output)

    {
        $request = new ServerRequest($method, $path, [
            'User-Agent' => 'FastD Console/'.version(),
        ]);

        $response = app()->handleRequest($request);

        $output->writeln(sprintf('Method: <info>%s</info>', $method));
        $output->writeln(sprintf('Path: <info>%s</info>', $path).PHP_EOL);

        $headersLIne = '';

        foreach ($response->getHeaders() as $name => $header) {
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            $headersLIne .= $name.': '.$response->getHeaderLine($name).PHP_EOL;
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        }

        $body = (string) $response->getBody();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        $body = json_encode(json_decode($body, true), JSON_PRETTY_PRINT);
        $output->writeln($headersLIne.PHP_EOL.$body);
    }

    /**
     * @param InputInterface  $input
     * @param OutputInterface $output
     */
    protected function render(InputInterface $input, OutputInterface $output)

    {
        $table = new Table($output);
        $rows = [];
        $table->setHeaders(array('Path', 'Method', 'Callback', 'Middleware'));
        foreach (route()->aliasMap as $routes) {
            foreach ($routes as $route) {
                $m = [];
                $middleware = $route->getMiddleware();
                if (is_array($middleware)) {
                    foreach ($middleware as $value) {
                        if (is_object($value)) {
                            $m[] = get_class($value);
                        } else {
                            $m[] = $value;
                        }
                    }
                } elseif (is_object($middleware)) {
                    $m[] = get_class($middleware);
                }
                $rows[] = [
                    $route->getPath(),
                    $route->getMethod(),
                    $route->getCallback(),
                    implode(',', $m),
                ];
            }
        }

        $table->setRows($rows);

        $table->render();
    }
}


1		<?php
2		/**
3		* @author jan huang <[email protected]>
4		* @copyright 2016
5		*
6		* @see https://www.github.com/janhuang
7		* @see https://fastdlabs.com
8		*/
9
10		namespace FastD\Console;
11
12		use FastD\Http\ServerRequest;
13		use Symfony\Component\Console\Command\Command;
14		use Symfony\Component\Console\Helper\Table;
15		use Symfony\Component\Console\Input\InputArgument;
16		use Symfony\Component\Console\Input\InputInterface;
17		use Symfony\Component\Console\Input\InputOption;
18		use Symfony\Component\Console\Output\OutputInterface;
19
20		/**
21		* Class Route.
22		*/
23		class Routing extends Command
24		{
25		public function configure()
26		{
27		$this
28		->setName('route')
29		->setHelp('Show all route')
30		->setDescription('Show you defined routes.')
31		->addArgument('method', InputArgument::OPTIONAL, 'Route request method.')
32		->addArgument('path', InputArgument::OPTIONAL, 'Route path.')
33		->addOption('data', 'd', InputOption::VALUE_OPTIONAL, 'Path request data.')
34		->addOption('all', 'a', InputOption::VALUE_OPTIONAL, 'Test all routes')
35		;
36		}
37
38		/**
39		* @param InputInterface $input
40		* @param OutputInterface $output
41		*
42		* @return mixed
43		*/
44		public function execute(InputInterface $input, OutputInterface $output)
45		{
46		if (empty($path = $input->getArgument('path'))) {
47		$this->render($input, $output);
48		} else {
49		$this->test($input->getArgument('method'), $path, $input, $output);
50		}
51
52		return 0;
53		}
54
55		/**
56		* @param $method
57		* @param $path
58		* @param InputInterface $input
59		* @param OutputInterface $output
60		*/
61		protected function test($method, $path, InputInterface $input, OutputInterface $output)
		0 ignored issues – show Unused Code introduced 2017-11-24 06:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$input` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
62		{
63		$request = new ServerRequest($method, $path, [
64		'User-Agent' => 'FastD Console/'.version(),
65		]);
66
67		$response = app()->handleRequest($request);
68
69		$output->writeln(sprintf('Method: <info>%s</info>', $method));
70		$output->writeln(sprintf('Path: <info>%s</info>', $path).PHP_EOL);
71
72		$headersLIne = '';
73
74	View Code Duplication	foreach ($response->getHeaders() as $name => $header) {
		0 ignored issues – show Bug introduced 2017-11-28 09:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `getHeaders` does only exist in `FastD\Http\Response`, but not in `Symfony\Component\HttpFoundation\Response`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history... Duplication introduced 2017-11-28 09:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
75		$headersLIne .= $name.': '.$response->getHeaderLine($name).PHP_EOL;
		0 ignored issues – show Bug introduced 2017-11-28 09:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `getHeaderLine` does only exist in `FastD\Http\Response`, but not in `Symfony\Component\HttpFoundation\Response`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
76		}
77
78		$body = (string) $response->getBody();
		0 ignored issues – show Bug introduced 2017-11-28 09:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `getBody` does only exist in `FastD\Http\Response`, but not in `Symfony\Component\HttpFoundation\Response`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
79		$body = json_encode(json_decode($body, true), JSON_PRETTY_PRINT);
80		$output->writeln($headersLIne.PHP_EOL.$body);
81		}
82
83		/**
84		* @param InputInterface $input
85		* @param OutputInterface $output
86		*/
87		protected function render(InputInterface $input, OutputInterface $output)
		0 ignored issues – show Unused Code introduced 2017-11-24 06:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$input` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
88		{
89		$table = new Table($output);
90		$rows = [];
91		$table->setHeaders(array('Path', 'Method', 'Callback', 'Middleware'));
92		foreach (route()->aliasMap as $routes) {
93		foreach ($routes as $route) {
94		$m = [];
95		$middleware = $route->getMiddleware();
96		if (is_array($middleware)) {
97		foreach ($middleware as $value) {
98		if (is_object($value)) {
99		$m[] = get_class($value);
100		} else {
101		$m[] = $value;
102		}
103		}
104		} elseif (is_object($middleware)) {
105		$m[] = get_class($middleware);
106		}
107		$rows[] = [
108		$route->getPath(),
109		$route->getMethod(),
110		$route->getCallback(),
111		implode(',', $m),
112		];
113		}
114		}
115
116		$table->setRows($rows);
117
118		$table->render();
119		}
120		}
121

JanHuang / fastD

Issues (30)

Security Analysis not enabled

src/Console/Routing.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like