TestCase::getConnection() - Code Metrics - Inspection of "update configuration" - JanHuang/fastD - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 68289f...b25dc9 )

by huang

created 2017-04-07 08:25 UTC

TestCase::getConnection() A

↳ Parent: TestCase

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	5
nc	2
nop	0
dl	0
loc	8
rs	9.4285
c	0
b	0
f	0

<?php
/**
 * @author    jan huang <[email protected]>
 * @copyright 2016
 *
 * @link      https://www.github.com/janhuang
 * @link      http://www.fast-d.cn/
 */

namespace FastD\Test;


use FastD\Application;
use FastD\Testing\WebTestCase;
use PHPUnit_Extensions_Database_DataSet_IDataSet;
use PHPUnit_Extensions_Database_DB_IDatabaseConnection;

/**
 * Class TestCase
 * @package FastD\Test
 */
class TestCase extends WebTestCase
{
    /**
     * @var Application
     */
    protected $app;

    /**
     * Set up unit.
     */
    public function setUp()
    {
        $this->app = $this->createApplication();
        parent::setUp();
    }

    /**
     * @return Application
     */
    public function createApplication()
    {
        return new Application(getcwd());
    }

    /**
     * Returns the test database connection.
     *
     * @return PHPUnit_Extensions_Database_DB_IDatabaseConnection
     */
    protected function getConnection()
    {
        $connection = env('connection');
        if (!$connection) {
            $connection = 'default';
        }
        return $this->createDefaultDBConnection(database($connection)->pdo);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    /**
     * Returns the test dataset.
     *
     * @return PHPUnit_Extensions_Database_DataSet_IDataSet
     */
    protected function getDataSet()
    {
        $path = app()->getPath() . '/database/dataset/*';

        $composite = new \PHPUnit_Extensions_Database_DataSet_CompositeDataSet();

        foreach (glob($path) as $file) {
            $dataSet = load($file);
            $tableName = pathinfo($file, PATHINFO_FILENAME);
            $composite->addDataSet(new \PHPUnit_Extensions_Database_DataSet_ArrayDataSet([
                $tableName => $dataSet
            ]));
        }

        return $composite;
    }
}

1			<?php
2			/**
3			* @author jan huang <[email protected]>
4			* @copyright 2016
5			*
6			* @link https://www.github.com/janhuang
7			* @link http://www.fast-d.cn/
8			*/
9
10			namespace FastD\Test;
11
12
13			use FastD\Application;
14			use FastD\Testing\WebTestCase;
15			use PHPUnit_Extensions_Database_DataSet_IDataSet;
16			use PHPUnit_Extensions_Database_DB_IDatabaseConnection;
17
18			/**
19			* Class TestCase
20			* @package FastD\Test
21			*/
22			class TestCase extends WebTestCase
23			{
24			/**
25			* @var Application
26			*/
27			protected $app;
28
29			/**
30			* Set up unit.
31			*/
32			public function setUp()
33			{
34			$this->app = $this->createApplication();
35			parent::setUp();
36			}
37
38			/**
39			* @return Application
40			*/
41			public function createApplication()
42			{
43			return new Application(getcwd());
44			}
45
46			/**
47			* Returns the test database connection.
48			*
49			* @return PHPUnit_Extensions_Database_DB_IDatabaseConnection
50			*/
51			protected function getConnection()
52			{
53			$connection = env('connection');
54			if (!$connection) {
55			$connection = 'default';
56			}
57			return $this->createDefaultDBConnection(database($connection)->pdo);
			0 ignored issues – show Bug introduced 2017-04-07 07:32 UTC by Report Bug Copy Issue Report The property `pdo` does not seem to exist in `Medoo\Medoo`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history... Bug introduced 2017-04-07 07:32 UTC by Report Bug Copy Issue Report It seems like `$connection` defined by `env('connection')` on line `53` can also be of type `boolean`; however, `database()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
58			}
59
60			/**
61			* Returns the test dataset.
62			*
63			* @return PHPUnit_Extensions_Database_DataSet_IDataSet
64			*/
65			protected function getDataSet()
66			{
67			$path = app()->getPath() . '/database/dataset/*';
68
69			$composite = new \PHPUnit_Extensions_Database_DataSet_CompositeDataSet();
70
71			foreach (glob($path) as $file) {
72			$dataSet = load($file);
73			$tableName = pathinfo($file, PATHINFO_FILENAME);
74			$composite->addDataSet(new \PHPUnit_Extensions_Database_DataSet_ArrayDataSet([
75			$tableName => $dataSet
76			]));
77			}
78
79			return $composite;
80			}
81			}

JanHuang / fastD

Push — master ( 68289f...b25dc9 )

TestCase::getConnection() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like