FastD\Servitization\Server\UDPServer

Complexity

Total Complexity

4

Size/Duplication

Total Lines	31
Duplicated Lines	22.58 %

Coupling/Cohesion

Components	0
Dependencies	6

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	doPacket()	7	19	4

<?php
/**
 * @author    jan huang <bboyjanhuang@gmail.com>
 * @copyright 2016
 *
 * @see      https://www.github.com/janhuang
 * @see      http://www.fast-d.cn/
 */

namespace FastD\Servitization\Server;

use FastD\Http\ServerRequest;
use FastD\Packet\Json;
use FastD\Servitization\OnWorkerStart;
use FastD\Swoole\Server\UDP;
use swoole_server;

/**
 * Class UDPServer.
 */
class UDPServer extends UDP
{
    use OnWorkerStart;

    /**
     * @param swoole_server $server
     * @param $data
     * @param $clientInfo
     *
     * @return mixed
     */
    public function doPacket(swoole_server $server, $data, $clientInfo)
    {
        $data = Json::decode($data);
        $request = new ServerRequest($data['method'], $data['path']);
        if (isset($data['args'])) {

This code seems to be duplicated across your project.

            if ('GET' === $request->getMethod()) {
                $request->withQueryParams($data['args']);

$data['args'] is of type string, but the function expects a array.

            } else {
                $request->withParsedBody($data['args']);

$data['args'] is of type string, but the function expects a null|array|object.

            }
        }
        try {
            $response = app()->handleRequest($request);
        } catch (\Exception $e) {
            $response = app()->handleException($request, $e);
        }
        $server->sendto($clientInfo['address'], $clientInfo['port'], (string) $response->getBody());
        app()->shutdown($request, $response);
    }
}