Passed
Push — master ( 59a5a5...30f57b )
by huang
02:58
created

WebSocketServer   A

Complexity

Total Complexity 4

Size/Duplication

Total Lines 32
Duplicated Lines 21.88 %

Coupling/Cohesion

Components 0
Dependencies 6

Test Coverage

Coverage 0%

Importance

Changes 0
Metric Value
dl 7
loc 32
ccs 0
cts 15
cp 0
rs 10
c 0
b 0
f 0
wmc 4
lcom 0
cbo 6

1 Method

Rating   Name   Duplication   Size   Complexity  
A doMessage() 7 21 4

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
/**
3
 * @author    jan huang <[email protected]>
4
 * @copyright 2016
5
 *
6
 * @see      https://www.github.com/janhuang
7
 * @see      http://www.fast-d.cn/
8
 */
9
10
namespace FastD\Servitization\Server;
11
12
use FastD\Http\ServerRequest;
13
use FastD\Packet\Json;
14
use FastD\Servitization\OnWorkerStart;
15
use FastD\Swoole\Server\WebSocket;
16
use swoole_server;
17
use swoole_websocket_frame;
18
19
/**
20
 * Class WebSocketServer.
21
 */
22
class WebSocketServer extends WebSocket
23
{
24
    use OnWorkerStart;
25
26
    /**
27
     * @param swoole_server          $server
28
     * @param swoole_websocket_frame $frame
29
     *
30
     * @return mixed
31
     */
32
    public function doMessage(swoole_server $server, swoole_websocket_frame $frame)
33
    {
34
        $data = $frame->data;
35
        $data = Json::decode($data);
36
        $request = new ServerRequest($data['method'], $data['path']);
37 View Code Duplication
        if (isset($data['args'])) {
0 ignored issues
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
38
            if ('GET' === $request->getMethod()) {
39
                $request->withQueryParams($data['args']);
0 ignored issues
show
Documentation introduced by
$data['args'] is of type string, but the function expects a array.

It seems like the type of the argument is not accepted by the function/method which you are calling.

In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.

We suggest to add an explicit type cast like in the following example:

function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
Loading history...
40
            } else {
41
                $request->withParsedBody($data['args']);
0 ignored issues
show
Documentation introduced by
$data['args'] is of type string, but the function expects a null|array|object.

It seems like the type of the argument is not accepted by the function/method which you are calling.

In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.

We suggest to add an explicit type cast like in the following example:

function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
Loading history...
42
            }
43
        }
44
        try {
45
            $response = app()->handleRequest($request);
46
        } catch (\Exception $e) {
47
            $response = app()->handleException($e);
48
        }
49
        $server->push($frame->fd, (string) $response->getBody());
50
51
        return 0;
52
    }
53
}
54