After::continuingDirectives() - Code Metrics - Inspection of "Reduce complexity in Server object." - JamesRezo/webhelper-parser - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( cadef0...55fd4a )

by James

created 2016-09-17 08:38 UTC

After::continuingDirectives() A

↳ Parent: After

Complexity

Conditions	3
Paths	3

Size

Total Lines	13
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	3

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	13
ccs	8
cts	8
cp	1
rs	9.4285
cc	3
eloc	6
nc	3
nop	1
crap	3

<?php

/**
 * This file is part of WebHelper Parser.
 *
 * (c) James <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace WebHelper\Parser\Parser;

/**
 * Methods that can be applied depending of the kind of server after a parsed configuration file turns into an array.
 *
 * @author James <[email protected]>
 */
class After
{
    /**
     * Trim all blank lines.
     *
     * @param array $activeConfig config file exploded in an array of lines
     *
     * @return array an array cleaned of blank lines
     */
    public static function deleteBlankLines(array $activeConfig = array())
    {
        $cleanedActiveConfig = [];

        foreach (array_map('trim', $activeConfig) as $line) {
            if ($line != '') {
                $cleanedActiveConfig[] = $line;
            }
        }

        return $cleanedActiveConfig;
    }

    /**
     * Reassembles discontinued simple directives in one line.
     *
     * In an Apache server context, it may be encountered.
     *
     * @param array $activeConfig config file exploded in an array of lines
     *
     * @return array an array with continuing lines gathered as one
     */
    public static function continuingDirectives(array $activeConfig = array())
    {
        $cleanedActiveConfig = [];

        //Continuing directives with "\" at the very end of a line are reassembled
        foreach ($activeConfig as $line) {
            if (!static::setLineIfPrevious($line)) {
class YourClass
{
    private static function getTemperature() {
        return "3422 °C";
}

public static function getSomeVariable()
{
    return static::getTemperature();
}
                $cleanedActiveConfig[] = $line;
            }
        }

        return $cleanedActiveConfig;
    }

    /**
     * Helps to gather continuing lines as one.
     *
     * @param string &$line a line to add to previous lines or matching a contuining end line marker
     */
    private static function setLineIfPrevious(&$line)
    {
        static $previousLine = '';

        if ($previousLine) {
            $line = $previousLine.' '.trim($line);
            $previousLine = '';
        }

        if (preg_match('/(.+)\\\$/', $line, $container)) {
            $previousLine = $container[1];
        }

        return $previousLine;
    }
}


1		<?php
2
3		/**
4		* This file is part of WebHelper Parser.
5		*
6		* (c) James <[email protected]>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace WebHelper\Parser\Parser;
13
14		/**
15		* Methods that can be applied depending of the kind of server after a parsed configuration file turns into an array.
16		*
17		* @author James <[email protected]>
18		*/
19		class After
20		{
21		/**
22		* Trim all blank lines.
23		*
24		* @param array $activeConfig config file exploded in an array of lines
25		*
26		* @return array an array cleaned of blank lines
27		*/
28	11	public static function deleteBlankLines(array $activeConfig = array())
29		{
30	11	$cleanedActiveConfig = [];
31
32	11	foreach (array_map('trim', $activeConfig) as $line) {
33	11	if ($line != '') {
34	9	$cleanedActiveConfig[] = $line;
35	9	}
36	11	}
37
38	11	return $cleanedActiveConfig;
39		}
40
41		/**
42		* Reassembles discontinued simple directives in one line.
43		*
44		* In an Apache server context, it may be encountered.
45		*
46		* @param array $activeConfig config file exploded in an array of lines
47		*
48		* @return array an array with continuing lines gathered as one
49		*/
50	5	public static function continuingDirectives(array $activeConfig = array())
51		{
52	5	$cleanedActiveConfig = [];
53
54		//Continuing directives with "\" at the very end of a line are reassembled
55	5	foreach ($activeConfig as $line) {
56	5	if (!static::setLineIfPrevious($line)) {
		0 ignored issues – show Bug introduced 2016-09-17 08:41 UTC by Report Bug Copy Issue Report Since `setLineIfPrevious()` is declared private, calling it with `static` will lead to errors in possible sub-classes. You can either use `self`, or increase the visibility of `setLineIfPrevious()` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return static::getTemperature(); } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { private static function getTemperature() { return "-182 °C"; } } print YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return self::getTemperature(); } } Loading history...
57	5	$cleanedActiveConfig[] = $line;
58	5	}
59	5	}
60
61	5	return $cleanedActiveConfig;
62		}
63
64		/**
65		* Helps to gather continuing lines as one.
66		*
67		* @param string &$line a line to add to previous lines or matching a contuining end line marker
68		*/
69	5	private static function setLineIfPrevious(&$line)
70		{
71	5	static $previousLine = '';
72
73	5	if ($previousLine) {
74	1	$line = $previousLine.' '.trim($line);
75	1	$previousLine = '';
76	1	}
77
78	5	if (preg_match('/(.+)\\\$/', $line, $container)) {
79	1	$previousLine = $container[1];
80	1	}
81
82	5	return $previousLine;
83		}
84		}
85

JamesRezo / webhelper-parser

GitHub Access Token became invalid

Push — master ( cadef0...55fd4a )

After::continuingDirectives() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like