WebServerFactory - Code Metrics - Inspection of "Introducing WebServer objects" - JamesRezo/WebHelper - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — new-architecture (764111)

by James

created 2016-08-12 08:12 UTC

WebServerFactory A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	28
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Test Coverage

Coverage

100%

Importance

Changes	4
Bugs	0	Features	1

Metric	Value
wmc	3
c	4
b	0
f	1
lcom	0
cbo	3
dl	0
loc	28
ccs	12
cts	12
cp	1
rs	10

1 Method

Rating	Name	Duplication	Size	Complexity
A	create()	0	17	3

<?php

/**
 * This file is, guess what, part of WebHelper.
 *
 * (c) James <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace JamesRezo\WebHelper\WebServer;

/**
 * WebServer Factory Class.
 *
 * @author James <[email protected]>
 */
class WebServerFactory
{
    /**
     * Create a WebServerInterface Object.
     *
     * @param string $name    a web server software name
     * @param string $version a web server software version
     *
     * @return WebServerInterface a WebServer Object
     */
    public function create($name, $version)
    {
        $webserver = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        switch ($name) {
            case 'apache':
                $webserver = new ApacheWebServer($version);
                break;
            case 'nginx':
                $webserver = new NginxWebServer($version);
                break;
            default:
                $webserver = new NullWebServer($version);
        }

        return $webserver;
    }
}


1		<?php
2
3		/**
4		* This file is, guess what, part of WebHelper.
5		*
6		* (c) James <[email protected]>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace JamesRezo\WebHelper\WebServer;
13
14		/**
15		* WebServer Factory Class.
16		*
17		* @author James <[email protected]>
18		*/
19		class WebServerFactory
20		{
21		/**
22		* Create a WebServerInterface Object.
23		*
24		* @param string $name a web server software name
25		* @param string $version a web server software version
26		*
27		* @return WebServerInterface a WebServer Object
28		*/
29	3	public function create($name, $version)
30		{
31	3	$webserver = null;
		0 ignored issues – show Unused Code introduced 2016-08-12 08:15 UTC by Report Bug Copy Issue Report `$webserver` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
32
33		switch ($name) {
34	3	case 'apache':
35	1	$webserver = new ApacheWebServer($version);
36	1	break;
37	2	case 'nginx':
38	1	$webserver = new NginxWebServer($version);
39	1	break;
40	1	default:
41	1	$webserver = new NullWebServer($version);
42	1	}
43
44	3	return $webserver;
45		}
46		}
47

JamesRezo / WebHelper

Branch — new-architecture (764111)

WebServerFactory A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

1 Method

Duplication Side-by-Side

Filter issues like