StreamableTrait::getItemLinks()

Complexity

Conditions	4
Paths	4

Size

Total Lines	24
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
	public function getItemLinks()
	{
		$items = array();

		// An item may consist of multiple items, a file may consist of multiple 
		// links
		foreach ($this->getStreamableItems() as $mediaItem)

It seems like getStreamableItems() must be provided by classes using this trait. How about adding it as abstract method to this trait?

		{
			$name = $mediaItem->getDisplayName();

			// Get the links to the media. We have to omit credentials from the 
			// URLs if the user is using Internet Explorer since it won't 
			// follow such links
			$links = VideoLibrary::getVideoLinks($mediaItem->file, Browser::isInternetExplorer());
			$linkCount = count($links);

			foreach ($links as $k=> $link)
			{
				$label = $linkCount > 1 ? $name.' (#'.++$k.')' : $name;
				$items[] = new ItemLink($label, $link, $mediaItem);
			}
		}

		return $items;
	}