Jalle19\StatusManager\Test\Database\UserQueryTest

Complexity

Total Complexity

3

Size/Duplication

Total Lines	43
Duplicated Lines	0 %

Importance

Changes	2
Bugs	1	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	testFilterIgnoredUsersNone()	0	7	1
A	testFilterIgnoredUsers()	0	13	1
A	getMockedUserQuery()	0	5	1

<?php

namespace Jalle19\StatusManager\Test\Database;

use Jalle19\StatusManager\Database\UserQuery;
use PHPUnit\Framework\TestCase;

/**
 * Class UserQueryTest
 * @package   Jalle19\StatusManager\Test\Database
 * @copyright Copyright &copy; Sam Stenvall 2016-
 * @license   https://www.gnu.org/licenses/gpl.html The GNU General Public License v2.0
 */
class UserQueryTest extends TestCase
{

	/**
	 * There should be four filter calls for three passed names, since the DVR user is added transparently
	 */
	public function testFilterIgnoredUsers()
	{
		$mock = $this->getMockedUserQuery();
		$mock->expects($this->exactly(4))

The method expects() does not exist on Jalle19\StatusManager\Database\UserQuery. Since you implemented __call, consider adding a @method annotation.

		     ->method('filterByName');

		$ignoredUsers = [
			'foo',
			'bar',
			'baz',
		];

		$mock->filterIgnoredUsers($ignoredUsers);
	}


	/**
	 * When no ignored users are specified, only the DVR user should be added
	 */
	public function testFilterIgnoredUsersNone()
	{
		$mock = $this->getMockedUserQuery();
		$mock->expects($this->once())
		     ->method('filterByName');

		$mock->filterIgnoredUsers([]);
	}


	/**
	 * @return \PHPUnit_Framework_MockObject_MockObject|UserQuery
	 */
	private function getMockedUserQuery()
	{
		return $this->getMockBuilder(UserQuery::class)

The expression return $this->getMockBuilder(Jalle19\StatusManager\Database\UserQuery::class)->setMethods(array('filterByName'))->getMock() returns the type PHPUnit\Framework\MockObject\MockObject which is incompatible with the documented return type Jalle19\StatusManager\Database\UserQuery&PHPUnit_Framework_MockObject_MockObject.

The function PHPUnit\Framework\MockObject\MockBuilder::setMethods() has been deprecated: https://github.com/sebastianbergmann/phpunit/pull/3687

		            ->setMethods(['filterByName'])
		            ->getMock();
	}

}