ApiHelper::successMessage() - Code Metrics - Inspection of "Merge remote-tracking branch 'origin/master'" - Jagepard/Rudra-Framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f92166...9df481 )

by Korotkov

created 2017-10-10 12:51 UTC

ApiHelper::successMessage() A

↳ Parent: ApiHelper

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	9
rs	9.6666
c	0
b	0
f	0
cc	2
eloc	6
nc	2
nop	2

<?php

declare(strict_types = 1);

/**
 * @author    : Korotkov Danila <[email protected]>
 * @copyright Copyright (c) 2017, Korotkov Danila
 * @license   http://www.gnu.org/licenses/gpl.html GNU GPLv3.0
 */

namespace App\Http\Supports;

trait ApiHelper
{

    protected function jsonResponse(array $data)
    {
        $this->container()->jsonResponse($data);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    protected function successMessage(string $message, string $key = 'alert')
    {
        if ($this->hasData('api')) {
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            $this->jsonResponse(['success' => [$key => $message]]);
        } else {
            $this->setSession($key, $message, 'success');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            $this->redirect($this->data('uri'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        }
    }

    protected function errorMessage($errors, string $key = 'alert')
    {
        if ($this->hasData('api')) {
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            $this->jsonResponse($errors);
        } else {
            foreach ($errors as $errorKey => $error) {
                $this->setSession($key, $error, $errorKey);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            }

            $this->redirect($this->data('uri'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        }
    }
}

1			<?php
2
3			declare(strict_types = 1);
4
5			/**
6			* @author : Korotkov Danila <[email protected]>
7			* @copyright Copyright (c) 2017, Korotkov Danila
8			* @license http://www.gnu.org/licenses/gpl.html GNU GPLv3.0
9			*/
10
11			namespace App\Http\Supports;
12
13			trait ApiHelper
14			{
15
16			protected function jsonResponse(array $data)
17			{
18			$this->container()->jsonResponse($data);
			0 ignored issues – show Bug introduced 2017-10-10 12:59 UTC by Report Bug Copy Issue Report It seems like `container()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
19			}
20
21			protected function successMessage(string $message, string $key = 'alert')
22			{
23			if ($this->hasData('api')) {
			0 ignored issues – show Bug introduced 2017-10-10 12:59 UTC by Report Bug Copy Issue Report It seems like `hasData()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
24			$this->jsonResponse(['success' => [$key => $message]]);
25			} else {
26			$this->setSession($key, $message, 'success');
			0 ignored issues – show Bug introduced 2017-10-10 12:59 UTC by Report Bug Copy Issue Report It seems like `setSession()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
27			$this->redirect($this->data('uri'));
			0 ignored issues – show Bug introduced 2017-10-10 12:59 UTC by Report Bug Copy Issue Report It seems like `data()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history... Bug introduced 2017-10-10 12:59 UTC by Report Bug Copy Issue Report It seems like `redirect()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
28			}
29			}
30
31			protected function errorMessage($errors, string $key = 'alert')
32			{
33			if ($this->hasData('api')) {
			0 ignored issues – show Bug introduced 2017-10-10 12:59 UTC by Report Bug Copy Issue Report It seems like `hasData()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
34			$this->jsonResponse($errors);
35			} else {
36			foreach ($errors as $errorKey => $error) {
37			$this->setSession($key, $error, $errorKey);
			0 ignored issues – show Bug introduced 2017-10-10 12:59 UTC by Report Bug Copy Issue Report It seems like `setSession()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
38			}
39
40			$this->redirect($this->data('uri'));
			0 ignored issues – show Bug introduced 2017-10-10 12:59 UTC by Report Bug Copy Issue Report It seems like `data()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history... Bug introduced 2017-10-10 12:59 UTC by Report Bug Copy Issue Report It seems like `redirect()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
41			}
42			}
43			}

Jagepard / Rudra-Framework

Push — master ( f92166...9df481 )

ApiHelper::successMessage() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like