Jagepard / Rudra-Framework

app/web/Supports/HttpErrors.php

<?php

namespace App\Web\Supports;

use Rudra\RouterException;

trait HttpErrors
{

    public function handle404($data, string $type = 'db', array $page = [])
    {
        if ($type == 'db') {
            if (count($data) < 1 or !$data) {

Using logical operators such as or instead of || is generally not recommended.

                throw new RouterException('404');
            }
        } elseif ($type == 'pagination') {
            if ($page['id'] > count($data)) {
                throw new RouterException('404');
            }
        }
    }

    public function handleApi404($data, string $type = 'db', array $page = [])
    {
        if ($type == 'db') {
            if (count($data) < 1 or !$data) {

Using logical operators such as or instead of || is generally not recommended.

                $this->jsonResponse(['status' => 'Not Found']);

It seems like jsonResponse() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            }
        } elseif ($type == 'pagination') {
            if ($page['id'] > count($data)) {
                $this->jsonResponse(['status' => 'Not Found']);

It seems like jsonResponse() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            }
        }
    }

    public function error404()

This method seems to be duplicated in your project.

    {
        $this->redirect()->responseCode('404');

        return $this->twig('errors/404.html.twig', [
            'title' => '404 Page Not Found :: ' . $this->data('title'),
        ]);
    }

    public function error503()
    {
        $this->redirect()->responseCode('503');

        return $this->twig('errors/503.html.twig', [
            'title' => '503 Service Unavailable :: ' . $this->data('title'),
        ]);
    }

    public function error500()
    {
        $this->redirect()->responseCode('503');

        return $this->twig('errors/503.html.twig', [
            'title' => '503 Service Unavailable :: ' . $this->data('title'),
        ]);
    }

    /**
     * @param null $target
     *
     * @return mixed
     */
    public abstract function redirect($target = null);

    /**
     * @param string $template
     * @param array  $params
     */
    public abstract function twig(string $template, array $params = []): void;

    /**
     * @param string $key
     *
     * @return string|array
     */
    public abstract function data(string $key = null);
}