Rudra\ContainerReflectionTrait

Complexity

Total Complexity

9

Size/Duplication

Total Lines	56
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
B	getParamsIoC()	0	19	5
A	iOc()	0	12	3
A	rawSet()	0	3	1

<?php
/**
 * Date: 03.05.18
 * Time: 18:23
 *
 * @author    : Korotkov Danila <dankorot@gmail.com>
 * @copyright Copyright (c) 2018, Korotkov Danila
 * @license   http://www.gnu.org/licenses/gpl.html GNU GPLv3.0
 */

namespace Rudra;


use \ReflectionClass;
use \ReflectionMethod;


/**
 * Trait ContainerReflectionTrait
 * @package Rudra
 */
trait ContainerReflectionTrait
{

    /**
     * @param string $key
     * @param        $object
     */
    protected function rawSet(string $key, $object)
    {
        $this->objects[$key] = $object;

The property objects does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }

    /**
     * @param string $key
     * @param        $object
     * @param null   $params

Are you sure the doc-type for parameter $params is correct as it would always require null to be passed?

     */
    protected function iOc(string $key, $object, $params = null): void
    {
        $reflection  = new ReflectionClass($object);
        $constructor = $reflection->getConstructor();

        if ($constructor && $constructor->getNumberOfParameters()) {
            $paramsIoC           = $this->getParamsIoC($constructor, $params);
            $this->objects[$key] = $reflection->newInstanceArgs($paramsIoC);

The property objects does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            return;
        }

        $this->objects[$key] = new $object;
    }


    /**
     * @param ReflectionMethod $constructor
     * @param                  $params
     * @return array
     */
    protected function getParamsIoC(ReflectionMethod $constructor, $params): array
    {
        $paramsIoC = [];
        foreach ($constructor->getParameters() as $key => $value) {
            if (isset($value->getClass()->name)) {
                $className       = $this->getBinding($value->getClass()->name);

It seems like getBinding() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                $paramsIoC[$key] = (is_object($className)) ? $className : new $className;
                continue;
            }

            if ($value->isDefaultValueAvailable()) {
                $paramsIoC[$key] = $value->getDefaultValue();
                continue;
            }

            $paramsIoC[$key] = $params[$value->getName()];
        }

        return $paramsIoC;
    }
}