Interpreter::getDataFromRegistry() - Code Metrics - Inspection of "Merge pull request #24 from Jagepard/wip" - Jagepard/PhpDesignPatterns-Interpreter - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( de30cb...30b342 )

by Korotkov

created 2020-07-15 07:54 UTC

Interpreter::getDataFromRegistry() A

↳ Parent: Interpreter

Complexity

Conditions	4
Paths	5

Size

Total Lines	15
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	4
eloc	7
c	0
b	0
f	0
nc	5
nop	2
dl	0
loc	15
rs	10

<?php

declare(strict_types=1);

/**
 * @author  : Jagepard <[email protected]>
 * @license https://mit-license.org/ MIT
 */

namespace Behavioral\Interpreter;

class Interpreter implements InterpreterInterface
{
    private array $registryData;

    public function __construct(RegistryInterface $registry)
    {
        $this->registryData = $registry->getData();
    }

    /**
     * @param string $input
     * @return array
     */
    public function interpret(string $input): array
    {
        $input = explode(' ', $input);

        foreach ($input as $value) {
            if (is_numeric($value)) {
                return $this->getDataFromRegistry($input, $this->registryData[$value - 1]);
            }
        }

        throw new \InvalidArgumentException("No id specified");
    }

    /**
     * @param array $input
     * @param AlbumInterface $item
     * @return array
     */
    private function getDataFromRegistry(array $input, AlbumInterface $item): array
    {
        $dataArray = [];

        foreach ($input as $value) {
            if ($value === "author") {
                $dataArray["author"] = $item->getAuthor();
            }

            if ($value === "album") {
                $dataArray["album"] = $item->getAlbum();
            }
        }

        return $dataArray;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/**
6			* @author : Jagepard <[email protected]>
7			* @license https://mit-license.org/ MIT
8			*/
9
10			namespace Behavioral\Interpreter;
11
12			class Interpreter implements InterpreterInterface
13			{
14			private array $registryData;
15
16			public function __construct(RegistryInterface $registry)
17			{
18			$this->registryData = $registry->getData();
19			}
20
21			/**
22			* @param string $input
23			* @return array
24			*/
25			public function interpret(string $input): array
26			{
27			$input = explode(' ', $input);
28
29			foreach ($input as $value) {
30			if (is_numeric($value)) {
31			return $this->getDataFromRegistry($input, $this->registryData[$value - 1]);
32			}
33			}
34
35			throw new \InvalidArgumentException("No id specified");
36			}
37
38			/**
39			* @param array $input
40			* @param AlbumInterface $item
41			* @return array
42			*/
43			private function getDataFromRegistry(array $input, AlbumInterface $item): array
44			{
45			$dataArray = [];
46
47			foreach ($input as $value) {
48			if ($value === "author") {
49			$dataArray["author"] = $item->getAuthor();
50			}
51
52			if ($value === "album") {
53			$dataArray["album"] = $item->getAlbum();
54			}
55			}
56
57			return $dataArray;
58			}
59			}
60

Jagepard / PhpDesignPatterns-Interpreter

Push — master ( de30cb...30b342 )

Interpreter::getDataFromRegistry() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like