Completed
Push — master ( a3e9c3...3a2779 )
by Korotkov
03:50 queued 02:11
created

PCBuilder   A

Complexity

Total Complexity 2

Size/Duplication

Total Lines 23
Duplicated Lines 0 %

Importance

Changes 1
Bugs 0 Features 0
Metric Value
wmc 2
eloc 5
c 1
b 0
f 0
dl 0
loc 23
rs 10

2 Methods

Rating   Name   Duplication   Size   Complexity  
A setPart() 0 4 1
A getComputer() 0 3 1
1
<?php
2
3
declare(strict_types=1);
4
5
/**
6
 * @author  : Jagepard <[email protected]>
7
 * @license https://mit-license.org/ MIT
8
 */
9
10
namespace Creational\Builder;
11
12
use Creational\Builder\Hardware\AbstractPart;
13
use Creational\Builder\Interfaces\BuilderInterface;
0 ignored issues
show
Bug introduced by
This use statement conflicts with another class in this namespace, Creational\Builder\BuilderInterface. Consider defining an alias.

Let?s assume that you have a directory layout like this:

.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

and let?s assume the following content of Bar.php:

// Bar.php
namespace OtherDir;

use SomeDir\Foo; // This now conflicts the class OtherDir\Foo

If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the same runtime, you will see a PHP error such as the following:

PHP Fatal error:  Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php

However, as OtherDir/Foo.php does not necessarily have to be loaded and the error is only triggered if it is loaded before OtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias:

// Bar.php
namespace OtherDir;

use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore.
Loading history...
14
use Creational\Builder\Interfaces\ComputerInterface;
0 ignored issues
show
Bug introduced by
This use statement conflicts with another class in this namespace, Creational\Builder\ComputerInterface. Consider defining an alias.

Let?s assume that you have a directory layout like this:

.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

and let?s assume the following content of Bar.php:

// Bar.php
namespace OtherDir;

use SomeDir\Foo; // This now conflicts the class OtherDir\Foo

If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the same runtime, you will see a PHP error such as the following:

PHP Fatal error:  Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php

However, as OtherDir/Foo.php does not necessarily have to be loaded and the error is only triggered if it is loaded before OtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias:

// Bar.php
namespace OtherDir;

use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore.
Loading history...
15
16
class PCBuilder implements BuilderInterface
17
{
18
    /**
19
     * @var array
20
     */
21
    private $components;
22
23
    /**
24
     * @param AbstractPart $part
25
     * @return BuilderInterface
26
     */
27
    public function setPart(AbstractPart $part): BuilderInterface
28
    {
29
        $this->components[get_class($part)] = $part;
30
        return $this;
31
    }
32
33
    /**
34
     * @return ComputerInterface
35
     */
36
    public function getComputer(): ComputerInterface
37
    {
38
        return new Desktop($this->components);
39
    }
40
}
41