Issues in Voys.php (master) - Issues in master - JCID/voys - Measure and Improve Code Quality continuously with Scrutinizer

Issues (3)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Voys.php (2 issues)

Labels

Compatibility 2

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Jcid\Voys;

use Assert\Assertion;
use GuzzleHttp\Client;
use GuzzleHttp\RequestOptions;

final class Voys
{
    const API_URL = 'https://api.voipgrid.nl/api/clicktodial/';

    /**
     * @var Client
     */
    private $client;

    /**
     * @var string
     */
    private $login;

    /**
     * @var string
     */
    private $password;

    /**
     * @param string $login
     * @param string $password
     */
    public function __construct(string $login, string $password)
    {
        $this->client = new Client();
        $this->validateLoginAndPassword($login, $password);
    }

    /**
     * @param string $fromPhonenumer
     * @param string $toPhonenumer
     *
     * @return string
     */
    public function callPhonenumer(string $toPhonenumer, string $fromPhonenumer): string
    {
        $this->validatePhonenumbers($toPhonenumer, $fromPhonenumer);

        $response = $this->client->request(
            'POST',
            self::API_URL,
            [
                RequestOptions::AUTH => [$this->login, $this->password],
                RequestOptions::JSON => [
                    VoysOptionsInterface::B_NUMBER => $toPhonenumer,
                    VoysOptionsInterface::A_NUMBER => $fromPhonenumer,
                ],
            ]
        );
        $voysResponse = new VoysResponse($response);


        return $voysResponse->getCallid();
    }

    /**
     * @param string $callid
     *
     * @return string
     */
    public function getCallStatus(string $callid): string
    {
        $this->validateCallId($callid);

        $response = $this->client->request(
            'GET',
            sprintf('%s%s/', self::API_URL, $callid),
            [
                RequestOptions::AUTH => [$this->login, $this->password],
            ]
        );
        $voysResponse = new VoysResponse($response);


        return $voysResponse->getStatus();
    }

    /**
     * @param string $login
     * @param string $password
     */
    private function validateLoginAndPassword(string $login, string $password): void
    {
        // Login validation
        Assertion::string($login, 'Login: Value "%s" expected to be string, type %s given.');
        Assertion::email($login, 'Login: Value "%s" was expected to be a valid e-mail address.');

        // Password validation
        Assertion::string($password, 'Password: Value "%s" expected to be string, type %s given.');

        $this->login = $login;
        $this->password = $password;
    }

    /**
     * @param string $toPhonenumer
     * @param string $fromPhonenumer
     */
    private function validatePhonenumbers(string $toPhonenumer, string $fromPhonenumer): void
    {
        Assertion::notNull($toPhonenumer);
        Assertion::notNull($fromPhonenumer);
    }

    /**
     * @param string $callid
     */
    private function validateCallId($callid): void
    {
        Assertion::string($callid);
    }
}


1			<?php
2
3			namespace Jcid\Voys;
4
5			use Assert\Assertion;
6			use GuzzleHttp\Client;
7			use GuzzleHttp\RequestOptions;
8
9			final class Voys
10			{
11			const API_URL = 'https://api.voipgrid.nl/api/clicktodial/';
12
13			/**
14			* @var Client
15			*/
16			private $client;
17
18			/**
19			* @var string
20			*/
21			private $login;
22
23			/**
24			* @var string
25			*/
26			private $password;
27
28			/**
29			* @param string $login
30			* @param string $password
31			*/
32			public function __construct(string $login, string $password)
33			{
34			$this->client = new Client();
35			$this->validateLoginAndPassword($login, $password);
36			}
37
38			/**
39			* @param string $fromPhonenumer
40			* @param string $toPhonenumer
41			*
42			* @return string
43			*/
44			public function callPhonenumer(string $toPhonenumer, string $fromPhonenumer): string
45			{
46			$this->validatePhonenumbers($toPhonenumer, $fromPhonenumer);
47
48			$response = $this->client->request(
49			'POST',
50			self::API_URL,
51			[
52			RequestOptions::AUTH => [$this->login, $this->password],
53			RequestOptions::JSON => [
54			VoysOptionsInterface::B_NUMBER => $toPhonenumer,
55			VoysOptionsInterface::A_NUMBER => $fromPhonenumer,
56			],
57			]
58			);
59			$voysResponse = new VoysResponse($response);
			0 ignored issues – show Compatibility introduced 2017-04-14 19:42 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$response` of type `object<Psr\Http\Message\ResponseInterface>` is not a sub-type of `object<GuzzleHttp\Psr7\Response>`. It seems like you assume a concrete implementation of the interface `Psr\Http\Message\ResponseInterface` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
60
61			return $voysResponse->getCallid();
62			}
63
64			/**
65			* @param string $callid
66			*
67			* @return string
68			*/
69			public function getCallStatus(string $callid): string
70			{
71			$this->validateCallId($callid);
72
73			$response = $this->client->request(
74			'GET',
75			sprintf('%s%s/', self::API_URL, $callid),
76			[
77			RequestOptions::AUTH => [$this->login, $this->password],
78			]
79			);
80			$voysResponse = new VoysResponse($response);
			0 ignored issues – show Compatibility introduced 2017-04-14 19:42 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$response` of type `object<Psr\Http\Message\ResponseInterface>` is not a sub-type of `object<GuzzleHttp\Psr7\Response>`. It seems like you assume a concrete implementation of the interface `Psr\Http\Message\ResponseInterface` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
81
82			return $voysResponse->getStatus();
83			}
84
85			/**
86			* @param string $login
87			* @param string $password
88			*/
89			private function validateLoginAndPassword(string $login, string $password): void
90			{
91			// Login validation
92			Assertion::string($login, 'Login: Value "%s" expected to be string, type %s given.');
93			Assertion::email($login, 'Login: Value "%s" was expected to be a valid e-mail address.');
94
95			// Password validation
96			Assertion::string($password, 'Password: Value "%s" expected to be string, type %s given.');
97
98			$this->login = $login;
99			$this->password = $password;
100			}
101
102			/**
103			* @param string $toPhonenumer
104			* @param string $fromPhonenumer
105			*/
106			private function validatePhonenumbers(string $toPhonenumer, string $fromPhonenumer): void
107			{
108			Assertion::notNull($toPhonenumer);
109			Assertion::notNull($fromPhonenumer);
110			}
111
112			/**
113			* @param string $callid
114			*/
115			private function validateCallId($callid): void
116			{
117			Assertion::string($callid);
118			}
119			}
120

JCID / voys

Issues (3)

Security Analysis no request data

src/Voys.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like