Middleware::handle() - Code Metrics - Inspection of "Add some comments and strict types." - JC5/google2fa-laravel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b09b4a...c4a10f )

by James

created 2019-12-01 14:09 UTC

Middleware::handle() B

↳ Parent: Middleware

Complexity

Conditions	6
Paths	6

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	14
CRAP Score	6

Importance

Changes

Metric	Value
dl	0
loc	24
ccs	14
cts	14
cp	1
rs	8.9137
c	0
b	0
f	0
cc	6
nc	6
nop	2
crap	6

<?php

namespace PragmaRX\Google2FALaravel;

use Closure;
use Illuminate\Http\Response;
use PragmaRX\Google2FALaravel\Support\Authenticator;
use PragmaRX\Google2FALaravel\Support\Constants;

/**
 * Class Middleware
 */
class Middleware
{
    /**
     * @param         $request
     * @param Closure $next
     *
     * @return \Illuminate\Http\JsonResponse|Response
     */
    public function handle($request, Closure $next)
    {
        /** @var Authenticator $authenticator */
        $authenticator = app(Authenticator::class)->boot($request);
        $cookieResult  = $authenticator->hasValidCookieToken();
        $authResult    = $authenticator->isAuthenticated();

        /** @var Response $response */
        $response = $next($request);

        if (false === $cookieResult && true === $authResult) {
            $cookieName = config('google2fa.cookie_name') ?? 'google2fa_token';
            $lifetime   = (int)(config('google2fa.cookie_lifetime') ?? 8035200);
            $lifetime   = $lifetime > 8035200 ? 8035200 : $lifetime;
            $token      = $authenticator->sessionGet(Constants::SESSION_TOKEN);
            $response->withCookie(cookie()->make($cookieName, $token, $lifetime / 60));
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        }

        if (true === $cookieResult || true === $authResult) {
            return $response;
        }

        return $authenticator->makeRequestOneTimePasswordResponse();
    }
}


GitHub Access Token became invalid

Push — master ( b09b4a...c4a10f )

Middleware::handle() B

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

1		<?php
2
3		namespace PragmaRX\Google2FALaravel;
4
5		use Closure;
6		use Illuminate\Http\Response;
7		use PragmaRX\Google2FALaravel\Support\Authenticator;
8		use PragmaRX\Google2FALaravel\Support\Constants;
9
10		/**
11		* Class Middleware
12		*/
13		class Middleware
14		{
15		/**
16		* @param $request
17		* @param Closure $next
18		*
19		* @return \Illuminate\Http\JsonResponse\|Response
20		*/
21	8	public function handle($request, Closure $next)
22		{
23		/** @var Authenticator $authenticator */
24	8	$authenticator = app(Authenticator::class)->boot($request);
25	8	$cookieResult = $authenticator->hasValidCookieToken();
26	8	$authResult = $authenticator->isAuthenticated();
27
28		/** @var Response $response */
29	8	$response = $next($request);
30
31	8	if (false === $cookieResult && true === $authResult) {
32	4	$cookieName = config('google2fa.cookie_name') ?? 'google2fa_token';
33	4	$lifetime = (int)(config('google2fa.cookie_lifetime') ?? 8035200);
34	4	$lifetime = $lifetime > 8035200 ? 8035200 : $lifetime;
35	4	$token = $authenticator->sessionGet(Constants::SESSION_TOKEN);
36	4	$response->withCookie(cookie()->make($cookieName, $token, $lifetime / 60));
		1 ignored issue – show Bug introduced 2019-12-01 12:20 UTC by Report Bug Copy Issue Report The method `make` does only exist in `Illuminate\Cookie\CookieJar`, but not in `Symfony\Component\HttpFoundation\Cookie`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
37		}
38
39	8	if (true === $cookieResult \|\| true === $authResult) {
40	4	return $response;
41		}
42
43	7	return $authenticator->makeRequestOneTimePasswordResponse();
44		}
45		}
46

JC5 / google2fa-laravel

GitHub Access Token became invalid

Push — master ( b09b4a...c4a10f )

Middleware::handle() B

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like