AdapterProvider::__invoke() - Code Metrics - Inspection of "choose the storage adapter at runtime" - IonBazan/object-store - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 13aaf0...8c7f52 )

by Ion

created 2020-05-20 20:27 UTC

AdapterProvider::__invoke() A

↳ Parent: AdapterProvider

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
eloc	5
c	1
b	0
f	0
nc	2
nop	1
dl	0
loc	10
ccs	6
cts	6
cp	1
crap	2
rs	10

<?php

declare(strict_types=1);

namespace App\Infrastructure\ObjectStorage;

class AdapterProvider
{
    /** @var ObjectStorageAdapter[] */
    private iterable $adapters;
    private string $defaultAdapter;

    /**
     * @param ObjectStorageAdapter[] $adapters
     */
    public function __construct(iterable $adapters, string $defaultAdapter)
    {
        $this->adapters = $adapters;

        $this->defaultAdapter = $defaultAdapter;
    }

    public function __invoke(?string $name = null): ObjectStorageAdapter
    {
        $name ??= $this->defaultAdapter;
        $adapters = iterator_to_array($this->adapters);

        if (!\array_key_exists($name, $adapters)) {
            throw new \UnexpectedValueException(sprintf('Invalid adapter name "%s" provided. Available options are: %s', $name, implode(', ', array_keys($adapters))));
        }

        return $adapters[$name];
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace App\Infrastructure\ObjectStorage;
6
7		class AdapterProvider
8		{
9		/** @var ObjectStorageAdapter[] */
10		private iterable $adapters;
11		private string $defaultAdapter;
12
13		/**
14		* @param ObjectStorageAdapter[] $adapters
15		*/
16	6	public function __construct(iterable $adapters, string $defaultAdapter)
17		{
18	6	$this->adapters = $adapters;
		0 ignored issues – show Documentation Bug introduced 2020-05-20 20:36 UTC by Report Bug Copy Issue Report It seems like `$adapters` of type `iterable` is incompatible with the declared type `App\Infrastructure\Objec...\ObjectStorageAdapter[]` of property `$adapters`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
19	6	$this->defaultAdapter = $defaultAdapter;
20	6	}
21
22	6	public function __invoke(?string $name = null): ObjectStorageAdapter
23		{
24	6	$name ??= $this->defaultAdapter;
25	6	$adapters = iterator_to_array($this->adapters);
26
27	6	if (!\array_key_exists($name, $adapters)) {
28	1	throw new \UnexpectedValueException(sprintf('Invalid adapter name "%s" provided. Available options are: %s', $name, implode(', ', array_keys($adapters))));
29		}
30
31	6	return $adapters[$name];
32		}
33		}
34

IonBazan / object-store

Push — master ( 13aaf0...8c7f52 )

AdapterProvider::__invoke() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like