LinuxFacade::__invoke() - Code Metrics - Inspection of "add decorators to cache cpu, memory and load avera..." - Innmind/ServerStatus - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 9ca8cc...2705d1 )

by Baptiste

created 2017-05-25 15:35 UTC

LinuxFacade::__invoke() B

↳ Parent: LinuxFacade

Complexity

Conditions	2
Paths	2

Size

Total Lines	41
Code Lines	27

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
dl	0
loc	41
c	0
b	0
f	0
ccs	0
cts	28
cp	0
rs	8.8571
cc	2
eloc	27
nc	2
nop	0
crap	6

<?php
declare(strict_types = 1);

namespace Innmind\Server\Status\Facade\Memory;

use Innmind\Server\Status\{
    Server\Memory,
    Server\Memory\Bytes,
    Exception\MemoryUsageNotAccessible
};
use Innmind\Immutable\Str;
use Symfony\Component\Process\Process;

final class LinuxFacade
{
    private $entries = [
        'MemTotal' => 'total',
        'Active' => 'active',
        'Inactive' => 'inactive',
        'MemFree' => 'free',
        'SwapCached' => 'swap',
    ];

    public function __invoke(): Memory
    {
        $process = new Process('cat /proc/meminfo');
        $process->run();

        if (!$process->isSuccessful()) {
            throw new MemoryUsageNotAccessible;
        }

        $amounts = (new Str($process->getOutput()))
            ->trim()
            ->split("\n")
            ->filter(static function(Str $line): bool {
                return $line->matches(
                    '('.implode('|', array_keys($this->entries)).')'
                );
            })
            ->reduce(
                new Map('string', 'int'),
                static function(Map $map, Str $line): Map {
                    $elements = $line->capture('~^(?P<key>\s+): +(?P<value>\d+) kB$~');

                    return $map->put(
                        $this->entries[(string) $elements->get('key')],
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                        ((int) (string) $elements->get('value')) * Bytes::BYTES
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                    );
                }
            );

        $used = $amounts->get('total') - $amounts->get('free');
        $wired = $used - $amounts->get('active') - $amounts->get('inactive');

        return new Memory(
            new Bytes($amounts->get('total')),
            new Bytes($wired),
            new Bytes($amounts->get('active')),
            new Bytes($amounts->get('free')),
            new Bytes($amounts->get('swap')),
            new Bytes($used)
        );
    }
}


1			<?php
2			declare(strict_types = 1);
3
4			namespace Innmind\Server\Status\Facade\Memory;
5
6			use Innmind\Server\Status\{
7			Server\Memory,
8			Server\Memory\Bytes,
9			Exception\MemoryUsageNotAccessible
10			};
11			use Innmind\Immutable\Str;
12			use Symfony\Component\Process\Process;
13
14			final class LinuxFacade
15			{
16			private $entries = [
17			'MemTotal' => 'total',
18			'Active' => 'active',
19			'Inactive' => 'inactive',
20			'MemFree' => 'free',
21			'SwapCached' => 'swap',
22			];
23
24			public function __invoke(): Memory
25			{
26			$process = new Process('cat /proc/meminfo');
27			$process->run();
28
29			if (!$process->isSuccessful()) {
30			throw new MemoryUsageNotAccessible;
31			}
32
33			$amounts = (new Str($process->getOutput()))
34			->trim()
35			->split("\n")
36			->filter(static function(Str $line): bool {
37			return $line->matches(
38			'('.implode('\|', array_keys($this->entries)).')'
39			);
40			})
41			->reduce(
42			new Map('string', 'int'),
43			static function(Map $map, Str $line): Map {
44			$elements = $line->capture('~^(?P<key>\s+): +(?P<value>\d+) kB$~');
45
46			return $map->put(
47			$this->entries[(string) $elements->get('key')],
			1 ignored issue – show Documentation introduced 2017-05-25 15:38 UTC by Report Bug Copy Issue Report `'key'` is of type `string`, but the function expects a `object<Innmind\Immutable\T>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
48			((int) (string) $elements->get('value')) * Bytes::BYTES
			1 ignored issue – show Documentation introduced 2017-05-25 15:38 UTC by Report Bug Copy Issue Report `'value'` is of type `string`, but the function expects a `object<Innmind\Immutable\T>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
49			);
50			}
51			);
52
53			$used = $amounts->get('total') - $amounts->get('free');
54			$wired = $used - $amounts->get('active') - $amounts->get('inactive');
55
56			return new Memory(
57			new Bytes($amounts->get('total')),
58			new Bytes($wired),
59			new Bytes($amounts->get('active')),
60			new Bytes($amounts->get('free')),
61			new Bytes($amounts->get('swap')),
62			new Bytes($used)
63			);
64			}
65			}
66

Innmind / ServerStatus

GitHub Access Token became invalid

Push — develop ( 9ca8cc...2705d1 )

LinuxFacade::__invoke() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like