Innmind\Rest\ServerBundle\Routing\RouteFactory

Complexity

Total Complexity

10

Size/Duplication

Total Lines	79
Duplicated Lines	12.66 %

Coupling/Cohesion

Components	0
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	makeName()	0	7	1
C	makeRoute()	10	52	9

<?php
declare(strict_types = 1);

namespace Innmind\Rest\ServerBundle\Routing;

use Innmind\Rest\Server\Action;
use Innmind\Http\Message\MethodInterface;
use Innmind\Immutable\StringPrimitive as Str;
use Symfony\Component\Routing\Route;

final class RouteFactory
{
    /**
     * Make a route name
     *
     * @param string $path Path to resource definition
     * @param Action $action
     *
     * @return string
     */
    public function makeName(string $path, Action $action): string
    {
        return (string) (new Str($path))
            ->prepend('innmind_rest_server.')
            ->append('.')
            ->append((string) $action);
    }

    /**
     * Make a route
     *
     * @param string $path Path to resource definition
     * @param Action $action
     *
     * @return Route
     */
    public function makeRoute(string $path, Action $action): Route
    {
        $name = $path;
        $path = (new Str($path))->replace('.', '/')->append('/');
        $condition = '';

        switch ((string) $action) {
            case Action::GET:
                $path = $path->append('{identity}');
            case Action::LIST:
                $method = MethodInterface::GET;
                break;
            case Action::CREATE:
                $method = MethodInterface::POST;
                break;
            case Action::UPDATE:
                $method = MethodInterface::PUT;
                $path = $path->append('{identity}');
                break;
            case Action::REMOVE:
                $method = MethodInterface::DELETE;
                $path = $path->append('{identity}');
                break;
            case Action::LINK:

This code seems to be duplicated across your project.

                $method = MethodInterface::LINK;
                $path = $path->append('{identity}');
                $condition = 'request.headers.has(\'Link\')';
                break;
            case Action::UNLINK:

This code seems to be duplicated across your project.

                $method = MethodInterface::UNLINK;
                $path = $path->append('{identity}');
                $condition = 'request.headers.has(\'Link\')';
                break;
            case Action::OPTIONS:
                $method = MethodInterface::OPTIONS;
                break;
        }

        return new Route(
            (string) $path,
            [
                '_innmind_resource' => $name,
                '_innmind_action' => (string) $action,
            ],
            [],
            [],
            '',
            [],
            $method,

The variable $method does not seem to be defined for all execution paths leading up to this point.

            $condition
        );
    }
}