Format::best() - Code Metrics - Inspection of "transform any exception from http lib as a bad req..." - Innmind/RestServerBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 99c8cd...370699 )

by Baptiste

created 2016-07-03 16:09 UTC

Format::best() A

↳ Parent: Format

Complexity

Conditions	2
Paths	2

Size

Total Lines	15
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	15
rs	9.4285
cc	2
eloc	10
nc	2
nop	1

<?php
declare(strict_types = 1);

namespace Innmind\Rest\ServerBundle;

use Innmind\Rest\Server\{
    Formats,
    Format\Format,
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
    Format\MediaType
};
use Innmind\Http\Message\ServerRequestInterface;
use Negotiation\Negotiator;

final class Format
{
    private $accept;
    private $contentType;
    private $negotiator;

    public function __construct(
        Formats $accept,
        Formats $contentType
    ) {
        $this->accept = $accept;
        $this->contentType = $contentType;
        $this->negotiator = new Negotiator;
    }

    public function acceptable(ServerRequestInterface $request): Format
    {
        $best = $this->negotiator->getBest(
            $request
                ->headers()
                ->get('Accept')
                ->values()
                ->join(', '),
            $this
                ->accept
                ->mediaTypes()
                ->reduce(
                    [],
                    function(array $carry, MediaType $type) {
                        $carry[] = (string) $type;
                        return $carry;
                    }
                )
        );

        return $this->best(
            $best->getBasePart().'/'.$best->getSubPart()
        );
    }

    public function contentType(ServerRequestInterface $request): Format
    {
        return $this->contentType->fromMediaType(

            (string) $request
                ->headers()
                ->get('Content-Type')
                ->values()
                ->current()
        );
    }

    private function best(string $mediaType): Format
    {
        if ($mediaType === '*/*') {
            return $this
                ->accept
                ->all()
                ->values()
                ->sort(function(Format $a, Format $b) {
                    return $a->priority() > $b->priority();
                })
                ->first();
        }

        return $this->accept->fromMediaType($mediaType);

    }
}


1			<?php
2			declare(strict_types = 1);
3
4			namespace Innmind\Rest\ServerBundle;
5
6			use Innmind\Rest\Server\{
7			Formats,
8			Format\Format,
			0 ignored issues – show Bug introduced 2016-07-03 16:11 UTC by Report Bug Copy Issue Report This use statement conflicts with another class in this namespace, `Innmind\Rest\ServerBundle\Format`. Let’s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let’s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
9			Format\MediaType
10			};
11			use Innmind\Http\Message\ServerRequestInterface;
12			use Negotiation\Negotiator;
13
14			final class Format
15			{
16			private $accept;
17			private $contentType;
18			private $negotiator;
19
20			public function __construct(
21			Formats $accept,
22			Formats $contentType
23			) {
24			$this->accept = $accept;
25			$this->contentType = $contentType;
26			$this->negotiator = new Negotiator;
27			}
28
29			public function acceptable(ServerRequestInterface $request): Format
30			{
31			$best = $this->negotiator->getBest(
32			$request
33			->headers()
34			->get('Accept')
35			->values()
36			->join(', '),
37			$this
38			->accept
39			->mediaTypes()
40			->reduce(
41			[],
42			function(array $carry, MediaType $type) {
43			$carry[] = (string) $type;
44			return $carry;
45			}
46			)
47			);
48
49			return $this->best(
50			$best->getBasePart().'/'.$best->getSubPart()
51			);
52			}
53
54			public function contentType(ServerRequestInterface $request): Format
55			{
56			return $this->contentType->fromMediaType(
			0 ignored issues – show Bug introduced 2016-07-03 16:11 UTC by Report Bug Copy Issue Report The method `fromMediaType()` does not seem to exist on `object<Innmind\Rest\Server\Formats>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
57			(string) $request
58			->headers()
59			->get('Content-Type')
60			->values()
61			->current()
62			);
63			}
64
65			private function best(string $mediaType): Format
66			{
67			if ($mediaType === '/') {
68			return $this
69			->accept
70			->all()
71			->values()
72			->sort(function(Format $a, Format $b) {
73			return $a->priority() > $b->priority();
74			})
75			->first();
76			}
77
78			return $this->accept->fromMediaType($mediaType);
			0 ignored issues – show Bug introduced 2016-07-03 16:11 UTC by Report Bug Copy Issue Report The method `fromMediaType()` does not seem to exist on `object<Innmind\Rest\Server\Formats>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
79			}
80			}
81

Innmind / RestServerBundle

Push — develop ( 99c8cd...370699 )

Format::best() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like