DelegationStrategy::extract() - Code Metrics - Inspection of "Merge branch 'develop'" - Innmind/Reflection - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 379179...de8df8 )

by Baptiste

created 2017-02-19 16:12 UTC

DelegationStrategy::extract() B

↳ Parent: DelegationStrategy

Complexity

Conditions	5
Paths	3

Size

Total Lines	32
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	18
CRAP Score	5

Importance

Changes

Metric	Value
dl	0
loc	32
ccs	18
cts	18
cp	1
rs	8.439
c	0
b	0
f	0
cc	5
eloc	18
nc	3
nop	2
crap	5

<?php
declare(strict_types = 1);

namespace Innmind\Reflection\ExtractionStrategy;

use Innmind\Reflection\{
    ExtractionStrategyInterface,
    Exception\InvalidArgumentException,
    Exception\PropertyCannotBeExtractedException
};
use Innmind\Immutable\{
    StreamInterface,
    Map
};

final class DelegationStrategy implements ExtractionStrategyInterface
{
    private $strategies;
    private $cache;

    /**
     * @param StreamInterface<ExtractionStrategyInterface> $strategies

     */
    public function __construct(StreamInterface $strategies)

    {
        if ((string) $strategies->type() !== ExtractionStrategyInterface::class) {
            throw new InvalidArgumentException;
        }

        $this->strategies = $strategies;
        $this->cache = new Map('string', ExtractionStrategyInterface::class);
    }

    /**
     * {@inheritdoc}
     */
    public function supports($object, string $property): bool
    {
        return $this
            ->strategies
            ->reduce(
                false,
                function(bool $supports, ExtractionStrategyInterface $strategy) use ($object, $property): bool {
                    if ($supports === true) {
                        return true;
                    }

                    return $strategy->supports($object, $property);
                }
            );
    }

    /**
     * {@inheritdoc}
     */
    public function extract($object, string $property)
    {
        $key = $this->generateKey($object, $property);

        if ($this->cache->contains($key)) {
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            return $this
                ->cache
                ->get($key)
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                ->extract($object, $property);
        }

        $strategy = $this->strategies->reduce(
            null,
            function($target, ExtractionStrategyInterface $strategy) use ($object, $property) {
                if ($target instanceof ExtractionStrategyInterface) {
                    return $target;
                }

                if ($strategy->supports($object, $property)) {
                    return $strategy;
                }
            }
        );

        if (!$strategy instanceof ExtractionStrategyInterface) {
            throw new PropertyCannotBeExtractedException($property);
        }

        $this->cache = $this->cache->put($key, $strategy);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        return $strategy->extract($object, $property);
    }

    private function generateKey($object, string $property): string
    {
        return get_class($object).'::'.$property;
    }
}


1			<?php
2			declare(strict_types = 1);
3
4			namespace Innmind\Reflection\ExtractionStrategy;
5
6			use Innmind\Reflection\{
7			ExtractionStrategyInterface,
8			Exception\InvalidArgumentException,
9			Exception\PropertyCannotBeExtractedException
10			};
11			use Innmind\Immutable\{
12			StreamInterface,
13			Map
14			};
15
16			final class DelegationStrategy implements ExtractionStrategyInterface
17			{
18			private $strategies;
19			private $cache;
20
21			/**
22			* @param StreamInterface<ExtractionStrategyInterface> $strategies
			0 ignored issues – show Documentation introduced 2017-02-19 16:05 UTC by Report Bug Copy Issue Report The doc-type `StreamInterface<ExtractionStrategyInterface>` could not be parsed: Expected "\|" or "end of type", but got "<" at position 15. (view supported doc-types) This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types. Loading history...
23			*/
24	7	View Code Duplication	public function __construct(StreamInterface $strategies)
			0 ignored issues – show Duplication introduced 2017-02-19 16:05 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
25			{
26	7		if ((string) $strategies->type() !== ExtractionStrategyInterface::class) {
27			throw new InvalidArgumentException;
28			}
29
30	7		$this->strategies = $strategies;
31	7		$this->cache = new Map('string', ExtractionStrategyInterface::class);
32	7		}
33
34			/**
35			* {@inheritdoc}
36			*/
37	1		public function supports($object, string $property): bool
38			{
39			return $this
40	1		->strategies
41	1		->reduce(
42	1		false,
43			function(bool $supports, ExtractionStrategyInterface $strategy) use ($object, $property): bool {
44	1		if ($supports === true) {
45	1		return true;
46			}
47
48	1		return $strategy->supports($object, $property);
49	1		}
50			);
51			}
52
53			/**
54			* {@inheritdoc}
55			*/
56	6		public function extract($object, string $property)
57			{
58	6		$key = $this->generateKey($object, $property);
59
60	6		if ($this->cache->contains($key)) {
			1 ignored issue – show Documentation introduced 2017-02-19 16:05 UTC by Report Bug Copy Issue Report `$key` is of type `string`, but the function expects a `object<Innmind\Immutable\T>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
61			return $this
62	1		->cache
63	1		->get($key)
			1 ignored issue – show Documentation introduced 2017-02-19 16:05 UTC by Report Bug Copy Issue Report `$key` is of type `string`, but the function expects a `object<Innmind\Immutable\T>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
64	1		->extract($object, $property);
65			}
66
67	6		$strategy = $this->strategies->reduce(
68	6		null,
69	6		function($target, ExtractionStrategyInterface $strategy) use ($object, $property) {
70	6		if ($target instanceof ExtractionStrategyInterface) {
71	3		return $target;
72			}
73
74	6		if ($strategy->supports($object, $property)) {
75	4		return $strategy;
76			}
77	6		}
78			);
79
80	6		if (!$strategy instanceof ExtractionStrategyInterface) {
81	2		throw new PropertyCannotBeExtractedException($property);
82			}
83
84	4		$this->cache = $this->cache->put($key, $strategy);
			2 ignored issues – show Documentation introduced 2017-02-19 16:05 UTC by Report Bug Copy Issue Report `$key` is of type `string`, but the function expects a `object<Innmind\Immutable\T>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2017-02-19 16:05 UTC by Report Bug Copy Issue Report `$strategy` is of type `object<Innmind\Reflectio...ctionStrategyInterface>`, but the function expects a `object<Innmind\Immutable\S>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
85
86	4		return $strategy->extract($object, $property);
87			}
88
89	6		private function generateKey($object, string $property): string
90			{
91	6		return get_class($object).'::'.$property;
92			}
93			}
94

Innmind / Reflection

GitHub Access Token became invalid

Push — master ( 379179...de8df8 )

DelegationStrategy::extract() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like