RepositoryFactoryConfigurator::configure() - Code Metrics - Inspection of "split services definitions" - Innmind/Neo4jBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( c8b131...c09436 )

by Baptiste

created 2017-02-27 12:12 UTC

RepositoryFactoryConfigurator::configure() A

↳ Parent: RepositoryFactoryConfigurator

Complexity

Conditions	1
Paths	1

Size

Total Lines	18
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	1.0019

Importance

Changes

Metric	Value
dl	0
loc	18
c	0
b	0
f	0
ccs	7
cts	8
cp	0.875
rs	9.4285
cc	1
eloc	12
nc	1
nop	1
crap	1.0019

<?php
declare(strict_types = 1);

namespace Innmind\Neo4jBundle\Configurator;

use Innmind\Neo4j\ONM\{
    Metadatas,
    RepositoryInterface,
    RepositoryFactory
};
use Innmind\Immutable\Map;

final class RepositoryFactoryConfigurator
{
    private $metadatas;
    private $repositories;

    public function __construct(Metadatas $metadatas)
    {
        $this->metadatas = $metadatas;
        $this->repositories = new Map('string', RepositoryInterface::class);
    }

    /**
     * Register a newrepository for the given entity class
     *
     * @param string $class
     * @param RepositoryInterface $repository
     *
     * @return self
     */
    public function register(string $class, RepositoryInterface $repository): self
    {
        $this->repositories = $this->repositories->put($class, $repository);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        return $this;
    }

    /**
     * Inject registered repositories into the given repository factory
     *
     * @param RepositoryFactory $factory
     *
     * @return RepositoryFactory
     */
    public function configure(RepositoryFactory $factory): RepositoryFactory
    {
        $this
            ->repositories
            ->foreach(function(
                string $class,
                RepositoryInterface $repository
            ) use (
                $factory
            ) {
                $factory->register(
                    $this->metadatas->get($class),
                    $repository
                );
            });

        return $factory;
    }
}


1		<?php
2		declare(strict_types = 1);
3
4		namespace Innmind\Neo4jBundle\Configurator;
5
6		use Innmind\Neo4j\ONM\{
7		Metadatas,
8		RepositoryInterface,
9		RepositoryFactory
10		};
11		use Innmind\Immutable\Map;
12
13		final class RepositoryFactoryConfigurator
14		{
15		private $metadatas;
16		private $repositories;
17
18	2	public function __construct(Metadatas $metadatas)
19		{
20	2	$this->metadatas = $metadatas;
21	2	$this->repositories = new Map('string', RepositoryInterface::class);
22	2	}
23
24		/**
25		* Register a newrepository for the given entity class
26		*
27		* @param string $class
28		* @param RepositoryInterface $repository
29		*
30		* @return self
31		*/
32	1	public function register(string $class, RepositoryInterface $repository): self
33		{
34	1	$this->repositories = $this->repositories->put($class, $repository);
		2 ignored issues – show Documentation introduced 2017-02-27 12:17 UTC by Report Bug Copy Issue Report `$class` is of type `string`, but the function expects a `object<Innmind\Immutable\T>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2017-02-27 12:17 UTC by Report Bug Copy Issue Report `$repository` is of type `object<Innmind\Neo4j\ONM\RepositoryInterface>`, but the function expects a `object<Innmind\Immutable\S>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
35
36	1	return $this;
37		}
38
39		/**
40		* Inject registered repositories into the given repository factory
41		*
42		* @param RepositoryFactory $factory
43		*
44		* @return RepositoryFactory
45		*/
46	2	public function configure(RepositoryFactory $factory): RepositoryFactory
47		{
48		$this
49	2	->repositories
50	2	->foreach(function(
51		string $class,
52		RepositoryInterface $repository
53		) use (
54		$factory
55		) {
56	1	$factory->register(
57	1	$this->metadatas->get($class),
58		$repository
59		);
60	2	});
61
62	2	return $factory;
63		}
64		}
65

Innmind / Neo4jBundle

Push — develop ( c8b131...c09436 )

RepositoryFactoryConfigurator::configure() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like