Passed
Push — develop ( b5b773...c3bc05 )
by Baptiste
02:13
created

ServiceFactory::__toString()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 5
Code Lines 4

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 3
CRAP Score 1

Importance

Changes 0
Metric Value
cc 1
eloc 4
nc 1
nop 0
dl 0
loc 5
ccs 3
cts 3
cp 1
crap 1
rs 9.4285
c 0
b 0
f 0
1
<?php
2
declare(strict_types = 1);
3
4
namespace Innmind\Compose\Compilation\Service\Constructor;
5
6
use Innmind\Compose\{
7
    Compilation\Service\Constructor,
8
    Compilation\Service\Argument
9
};
10
use Innmind\Immutable\Stream;
1 ignored issue
show
Bug introduced by
This use statement conflicts with another class in this namespace, Innmind\Compose\Compilat...vice\Constructor\Stream. Consider defining an alias.

Let?s assume that you have a directory layout like this:

.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

and let?s assume the following content of Bar.php:

// Bar.php
namespace OtherDir;

use SomeDir\Foo; // This now conflicts the class OtherDir\Foo

If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the same runtime, you will see a PHP error such as the following:

PHP Fatal error:  Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php

However, as OtherDir/Foo.php does not necessarily have to be loaded and the error is only triggered if it is loaded before OtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias:

// Bar.php
namespace OtherDir;

use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore.
Loading history...
11
12
final class ServiceFactory implements Constructor
13
{
14
    private $factory;
15
    private $method;
16
    private $arguments;
17
18 3
    public function __construct(string $method, Argument $factory, Argument ...$arguments)
19
    {
20 3
        $this->factory = $factory;
21 3
        $this->method = $method;
22 3
        $this->arguments = Stream::of(Argument::class, ...$arguments);
23 3
    }
24
25 1
    public function __toString(): string
26
    {
27
        return <<<PHP
28 1
{$this->factory}->{$this->method}(
29 1
{$this->arguments->join(",\n")}
30
)
31
PHP;
32
    }
33
}
34