ContainerAwareCommandBusFactory::make() - Code Metrics - Innmind/CommandBusBundle - Measure and Improve Code Quality continuously with Scrutinizer

ContainerAwareCommandBusFactory::make() A
last analyzed 2017-02-19 16:28 UTC

↳ Parent: ContainerAwareCommandBusFactory

Complexity

Conditions	2
Paths	2

Size

Total Lines	12
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	12
ccs	5
cts	5
cp	1
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	8
nc	2
nop	2
crap	2

<?php
declare(strict_types = 1);

namespace Innmind\CommandBusBundle\Factory;

use Innmind\CommandBusBundle\ContainerAwareCommandBus;
use Innmind\Immutable\Map;
use Symfony\Component\DependencyInjection\ContainerInterface;

final class ContainerAwareCommandBusFactory
{
    public static function make(
        ContainerInterface $container,
        array $services
    ): ContainerAwareCommandBus {
        $map = new Map('string', 'string');

        foreach ($services as $class => $service) {
            $map = $map->put($class, $service);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }

        return new ContainerAwareCommandBus($container, $map);
    }
}


1		<?php
2		declare(strict_types = 1);
3
4		namespace Innmind\CommandBusBundle\Factory;
5
6		use Innmind\CommandBusBundle\ContainerAwareCommandBus;
7		use Innmind\Immutable\Map;
8		use Symfony\Component\DependencyInjection\ContainerInterface;
9
10		final class ContainerAwareCommandBusFactory
11		{
12	3	public static function make(
13		ContainerInterface $container,
14		array $services
15		): ContainerAwareCommandBus {
16	3	$map = new Map('string', 'string');
17
18	3	foreach ($services as $class => $service) {
19	3	$map = $map->put($class, $service);
		1 ignored issue – show Documentation introduced 2017-02-19 16:28 UTC by Report Bug Copy Issue Report `$class` is of type `integer\|string`, but the function expects a `object<Innmind\Immutable\T>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
20		}
21
22	3	return new ContainerAwareCommandBus($container, $map);
23		}
24		}
25

Innmind / CommandBusBundle

ContainerAwareCommandBusFactory::make() A last analyzed 2017-02-19 16:28 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

ContainerAwareCommandBusFactory::make() A
last analyzed 2017-02-19 16:28 UTC