Frame::__construct() - Code Metrics - Inspection of "add frame model" - Innmind/AMQP - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( cc6581...39cc13 )

by Baptiste

created 2017-08-13 11:55 UTC

Frame::__construct() B

↳ Parent: Frame

Complexity

Conditions	1
Paths	1

Size

Total Lines	30
Code Lines	24

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	22
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	30
ccs	22
cts	22
cp	1
rs	8.8571
c	0
b	0
f	0
cc	1
eloc	24
nc	1
nop	4
crap	1

<?php
declare(strict_types = 1);

namespace Innmind\AMQP\Transport;

use Innmind\AMQP\Transport\Frame\{
    Type,
    Channel,
    Method,
    Value,
    Value\UnsignedOctet,
    Value\UnsignedShortInteger,
    Value\UnsignedLongInteger
};
use Innmind\Immutable\{
    Sequence,
    Stream,
    StreamInterface
};

final class Frame
{
    private $type;
    private $values;
    private $string;

    public function __construct(
        Type $type,
        Channel $channel,
        Method $method,
        Value ...$values
    ) {
        $this->type = $type;
        $this->channel = $channel;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->method = $method;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $values = new Sequence(...$values);
        $payload = $values->join('')->toEncoding('ASCII');
        $frame = new Sequence(
            new UnsignedOctet($type->toInt()),
            new UnsignedShortInteger($channel->toInt()),
            new UnsignedLongInteger(
                $payload->length() + 4 // 4 is the size for the method
            ),
            new UnsignedShortInteger($method->class()),
            new UnsignedShortInteger($method->method()),
            $payload,
            new UnsignedOctet(0xCE)
        );
        $this->values = $values->reduce(
            new Stream(Value::class),
            static function(Stream $stream, Value $value): Stream {
                return $stream->add($value);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            }
        );
        $this->string = (string) $frame->join('');
    }

    public function type(): Type
    {
        return $this->type;
    }

    public function channel(): Channel
    {
        return $this->channel;
    }

    public function method(): Method
    {
        return $this->method;
    }

    /**
     * @return StreamInterface<Value>

     */
    public function values(): StreamInterface
    {
        return $this->values;
    }

    public function __toString(): string
    {
        return $this->string;
    }
}


1		<?php
2		declare(strict_types = 1);
3
4		namespace Innmind\AMQP\Transport;
5
6		use Innmind\AMQP\Transport\Frame\{
7		Type,
8		Channel,
9		Method,
10		Value,
11		Value\UnsignedOctet,
12		Value\UnsignedShortInteger,
13		Value\UnsignedLongInteger
14		};
15		use Innmind\Immutable\{
16		Sequence,
17		Stream,
18		StreamInterface
19		};
20
21		final class Frame
22		{
23		private $type;
24		private $values;
25		private $string;
26
27	1	public function __construct(
28		Type $type,
29		Channel $channel,
30		Method $method,
31		Value ...$values
32		) {
33	1	$this->type = $type;
34	1	$this->channel = $channel;
		0 ignored issues – show Bug introduced 2017-08-13 11:56 UTC by Report Bug Copy Issue Report The property `channel` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
35	1	$this->method = $method;
		0 ignored issues – show Bug introduced 2017-08-13 11:56 UTC by Report Bug Copy Issue Report The property `method` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
36	1	$values = new Sequence(...$values);
37	1	$payload = $values->join('')->toEncoding('ASCII');
38	1	$frame = new Sequence(
39	1	new UnsignedOctet($type->toInt()),
40	1	new UnsignedShortInteger($channel->toInt()),
41	1	new UnsignedLongInteger(
42	1	$payload->length() + 4 // 4 is the size for the method
43		),
44	1	new UnsignedShortInteger($method->class()),
45	1	new UnsignedShortInteger($method->method()),
46	1	$payload,
47	1	new UnsignedOctet(0xCE)
48		);
49	1	$this->values = $values->reduce(
50	1	new Stream(Value::class),
51	1	static function(Stream $stream, Value $value): Stream {
52	1	return $stream->add($value);
		1 ignored issue – show Documentation introduced 2017-08-13 11:56 UTC by Report Bug Copy Issue Report `$value` is of type `object<Innmind\AMQP\Transport\Frame\Value>`, but the function expects a `object<Innmind\Immutable\T>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
53	1	}
54		);
55	1	$this->string = (string) $frame->join('');
56	1	}
57
58	1	public function type(): Type
59		{
60	1	return $this->type;
61		}
62
63	1	public function channel(): Channel
64		{
65	1	return $this->channel;
66		}
67
68	1	public function method(): Method
69		{
70	1	return $this->method;
71		}
72
73		/**
74		* @return StreamInterface<Value>
		0 ignored issues – show Documentation introduced 2017-08-13 11:56 UTC by Report Bug Copy Issue Report The doc-type `StreamInterface<Value>` could not be parsed: Expected "\|" or "end of type", but got "<" at position 15. (view supported doc-types) This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types. Loading history...
75		*/
76	1	public function values(): StreamInterface
77		{
78	1	return $this->values;
79		}
80
81	1	public function __toString(): string
82		{
83	1	return $this->string;
84		}
85		}
86

Innmind / AMQP

GitHub Access Token became invalid

Push — develop ( cc6581...39cc13 )

Frame::__construct() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like