Table::__construct() - Code Metrics - Inspection of "add value types allowed in a frame" - Innmind/AMQP - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( fa7ae3...61903e )

by Baptiste

created 2017-08-13 10:57 UTC

Table::__construct() B

↳ Parent: Table

Complexity

Conditions	3
Paths	2

Size

Total Lines	28
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	17
CRAP Score	3

Importance

Changes

Metric	Value
dl	0
loc	28
c	0
b	0
f	0
ccs	17
cts	17
cp	1
rs	8.8571
cc	3
eloc	18
nc	2
nop	1
crap	3

<?php
declare(strict_types = 1);

namespace Innmind\AMQP\Transport\Frame\Value;

use Innmind\AMQP\Transport\Frame\Value;
use Innmind\Immutable\{
    Str,
    Sequence as Seq,
    MapInterface
};

final class Table implements Value
{
    private $value;

    /**
     * @param MapInterface<string, Value> $map
     */
    public function __construct(MapInterface $map)
    {
        if (
            (string) $map->keyType() !== 'string' ||
            (string) $map->valueType() !== Value::class
        ) {
            throw new \TypeError(sprintf(

                'Argument 1 must be of type MapInterface<string, %s>',
                Value::class
            ));
        }

        $data = $map
            ->reduce(
                new Seq,
                static function(Seq $sequence, string $key, Value $value): Seq {
                    return $sequence
                        ->add(new ShortString(new Str($key)))
                        ->add($value);
                }
            )
            ->join('');

        $this->value = (string) new UnsignedLongInteger(
            $data->toEncoding('ASCII')->length()
        );
        $this->value .= $data;
    }

    public function __toString(): string
    {
        return $this->value;
    }
}


1		<?php
2		declare(strict_types = 1);
3
4		namespace Innmind\AMQP\Transport\Frame\Value;
5
6		use Innmind\AMQP\Transport\Frame\Value;
7		use Innmind\Immutable\{
8		Str,
9		Sequence as Seq,
10		MapInterface
11		};
12
13		final class Table implements Value
14		{
15		private $value;
16
17		/**
18		* @param MapInterface<string, Value> $map
19		*/
20	4	public function __construct(MapInterface $map)
21		{
22		if (
23	4	(string) $map->keyType() !== 'string' \|\|
24	4	(string) $map->valueType() !== Value::class
25		) {
26	1	throw new \TypeError(sprintf(
		1 ignored issue – show Unused Code introduced 2017-08-13 11:00 UTC by Report Bug Copy Issue Report The call to `TypeError::__construct()` has too many arguments starting with `sprintf('Argument 1 must...ort\Frame\Value::class)`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
27	1	'Argument 1 must be of type MapInterface<string, %s>',
28	1	Value::class
29		));
30		}
31
32		$data = $map
33	3	->reduce(
34	3	new Seq,
35	3	static function(Seq $sequence, string $key, Value $value): Seq {
36		return $sequence
37	2	->add(new ShortString(new Str($key)))
38	2	->add($value);
39	3	}
40		)
41	3	->join('');
42
43	3	$this->value = (string) new UnsignedLongInteger(
44	3	$data->toEncoding('ASCII')->length()
45		);
46	3	$this->value .= $data;
47	3	}
48
49	2	public function __toString(): string
50		{
51	2	return $this->value;
52		}
53		}
54

Innmind / AMQP

GitHub Access Token became invalid

Push — develop ( fa7ae3...61903e )

Table::__construct() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like