Basic::serializeProperties() - Code Metrics - Inspection of "send heartbeat frame when no data received for a c..." - Innmind/AMQP - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( d40077...e71353 )

by Baptiste

created 2017-09-09 15:59 UTC

Basic::serializeProperties() F

↳ Parent: Basic

Complexity

Conditions	14
Paths	8192

Size

Total Lines	99
Code Lines	57

Duplication

Lines	12
Ratio	12.12 %

Code Coverage

Tests	57
CRAP Score	14

Importance

Changes

Metric	Value
dl	12
loc	99
c	0
b	0
f	0
ccs	57
cts	57
cp	1
rs	2
cc	14
eloc	57
nc	8192
nop	1
crap	14

How to fix Long Method Complexity

<?php
declare(strict_types = 1);

namespace Innmind\AMQP\Transport\Protocol\v091;

use Innmind\AMQP\{
    Model\Basic\Ack,
    Model\Basic\Cancel,
    Model\Basic\Consume,
    Model\Basic\Get,
    Model\Basic\Publish,
    Model\Basic\Qos,
    Model\Basic\Recover,
    Model\Basic\Reject,
    Model\Basic\Message,
    Model\Connection\MaxFrameSize,
    Transport\Frame,
    Transport\Frame\Type,
    Transport\Frame\Channel as FrameChannel,
    Transport\Frame\Method,
    Transport\Frame\Value,
    Transport\Frame\Value\UnsignedLongLongInteger,
    Transport\Frame\Value\UnsignedLongInteger,
    Transport\Frame\Value\Bits,
    Transport\Frame\Value\ShortString,
    Transport\Frame\Value\UnsignedShortInteger,
    Transport\Frame\Value\Table,
    Transport\Frame\Value\UnsignedOctet,
    Transport\Frame\Value\Timestamp,
    Transport\Protocol\Basic as BasicInterface,
    Transport\Protocol\ArgumentTranslator
};
use Innmind\Math\Algebra\Integer;
use Innmind\Immutable\{
    Str,
    Map,
    MapInterface,
    StreamInterface,
    Stream
};

final class Basic implements BasicInterface
{
    private $translate;

    public function __construct(ArgumentTranslator $translator)
    {
        $this->translate = $translator;
    }

    public function ack(FrameChannel $channel, Ack $command): Frame

    {
        return Frame::command(
            $channel,
            Methods::get('basic.ack'),
            new UnsignedLongLongInteger(new Integer($command->deliveryTag())),
            new Bits($command->isMultiple())
        );
    }

    public function cancel(FrameChannel $channel, Cancel $command): Frame
    {
        return Frame::command(
            $channel,
            Methods::get('basic.cancel'),
            new ShortString(new Str($command->consumerTag())),
            new Bits(!$command->shouldWait())
        );
    }

    public function consume(FrameChannel $channel, Consume $command): Frame

    {
        $consumerTag = '';

        if (!$command->shouldAutoGenerateConsumerTag()) {
            $consumerTag = $command->consumerTag();
        }

        return Frame::command(
            $channel,
            Methods::get('basic.consume'),
            new UnsignedShortInteger(new Integer(0)), //ticket (reserved)
            new ShortString(new Str($command->queue())),
            new ShortString(new Str($consumerTag)),
            new Bits(
                !$command->isLocal(),
                $command->shouldAutoAcknowledge(),
                $command->isExclusive(),
                !$command->shouldWait()
            ),
            $this->arguments($command->arguments())
        );
    }

    public function get(FrameChannel $channel, Get $command): Frame
    {
        return Frame::command(
            $channel,
            Methods::get('basic.get'),
            new UnsignedShortInteger(new Integer(0)), //ticket (reserved)
            new ShortString(new Str($command->queue())),
            new Bits($command->shouldAutoAcknowledge())
        );
    }

    /**
     * {@inheritdoc}
     */
    public function publish(
        FrameChannel $channel,
        Publish $command,
        MaxFrameSize $maxFrameSize
    ): StreamInterface {
        $frames = (new Stream(Frame::class))
            ->add(Frame::command(
                $channel,
                Methods::get('basic.publish'),
                new UnsignedShortInteger(new Integer(0)), //ticket (reserved)
                new ShortString(new Str($command->exchange())),
                new ShortString(new Str($command->routingKey())),
                new Bits(
                    $command->mandatory(),
                    $command->immediate()
                )
            ))
            ->add(Frame::header(
                $channel,
                Methods::classId('basic'),
                new UnsignedLongLongInteger(new Integer(
                    $command->message()->body()->length()
                )),
                ...$this->serializeProperties($command->message())
            ));

        //the "-8" is due to the content frame extra informations (type, channel and end flag)
        $chunk = $maxFrameSize->isLimited() ? ($maxFrameSize->toInt() - 8) : $command->message()->body()->length();

        return $command
            ->message()
            ->body()
            ->chunk($chunk)
            ->reduce(
                $frames,
                static function(Stream $frames, Str $chunk) use ($channel): Stream {
                    return $frames->add(Frame::body($channel, $chunk));
                }
            );
    }

    public function qos(FrameChannel $channel, Qos $command): Frame

    {
        return Frame::command(
            $channel,
            Methods::get('basic.qos'),
            new UnsignedLongInteger(new Integer($command->prefetchSize())),
            new UnsignedShortInteger(new Integer($command->prefetchCount())),
            new Bits($command->isGlobal())
        );
    }

    public function recover(FrameChannel $channel, Recover $command): Frame
    {
        return Frame::command(
            $channel,
            Methods::get('basic.recover'),
            new Bits($command->shouldRequeue())
        );
    }

    public function reject(FrameChannel $channel, Reject $command): Frame

    {
        return Frame::command(
            $channel,
            Methods::get('basic.reject'),
            new UnsignedLongLongInteger(new Integer($command->deliveryTag())),
            new Bits($command->shouldRequeue())
        );
    }

    private function arguments(MapInterface $arguments): Table

    {
        return new Table(
            $arguments->reduce(
                new Map('string', Value::class),
                function(Map $carry, string $key, $value): Map {
                    return $carry->put(
                        $key,
                        ($this->translate)($value)
                    );
                }
            )
        );
    }

    private function serializeProperties(Message $message): array
    {
        $properties = [];
        $flagBits = 0;

        if ($message->hasContentType()) {
            $properties[] = new ShortString(
                new Str((string) $message->contentType())
            );
            $flagBits |= (1 << 15);
        }

        if ($message->hasContentEncoding()) {
            $properties[] = new ShortString(
                new Str((string) $message->contentEncoding())
            );
            $flagBits |= (1 << 14);
        }

        if ($message->hasHeaders()) {
            $properties[] = $this->arguments($message->headers());
            $flagBits |= (1 << 13);
        }

        if ($message->hasDeliveryMode()) {
            $properties[] = new UnsignedOctet(
                new Integer($message->deliveryMode()->toInt())
            );
            $flagBits |= (1 << 12);
        }

        if ($message->hasPriority()) {
            $properties[] = new UnsignedOctet(
                new Integer($message->priority()->toInt())
            );
            $flagBits |= (1 << 11);
        }

        if ($message->hasCorrelationId()) {
            $properties[] = new ShortString(
                new Str((string) $message->correlationId())
            );
            $flagBits |= (1 << 10);
        }

        if ($message->hasReplyTo()) {
            $properties[] = new ShortString(
                new Str((string) $message->replyTo())
            );
            $flagBits |= (1 << 9);
        }

        if ($message->hasExpiration()) {
            $properties[] = new ShortString(
                new Str((string) $message->expiration()->milliseconds())
            );
            $flagBits |= (1 << 8);
        }

        if ($message->hasId()) {

            $properties[] = new ShortString(
                new Str((string) $message->id())
            );
            $flagBits |= (1 << 7);
        }

        if ($message->hasTimestamp()) {
            $properties[] = new Timestamp($message->timestamp());
            $flagBits |= (1 << 6);
        }

        if ($message->hasType()) {

            $properties[] = new ShortString(
                new Str((string) $message->type())
            );
            $flagBits |= (1 << 5);
        }

        if ($message->hasUserId()) {
            $properties[] = new ShortString(
                new Str((string) $message->userId())
            );
            $flagBits |= (1 << 4);
        }

        if ($message->hasAppId()) {
            $properties[] = new ShortString(
                new Str((string) $message->appId())
            );
            $flagBits |= (1 << 3);
        }

        array_unshift(
            $properties,
            new UnsignedShortInteger(new Integer($flagBits))
        );

        return $properties;
    }
}


1			<?php
2			declare(strict_types = 1);
3
4			namespace Innmind\AMQP\Transport\Protocol\v091;
5
6			use Innmind\AMQP\{
7			Model\Basic\Ack,
8			Model\Basic\Cancel,
9			Model\Basic\Consume,
10			Model\Basic\Get,
11			Model\Basic\Publish,
12			Model\Basic\Qos,
13			Model\Basic\Recover,
14			Model\Basic\Reject,
15			Model\Basic\Message,
16			Model\Connection\MaxFrameSize,
17			Transport\Frame,
18			Transport\Frame\Type,
19			Transport\Frame\Channel as FrameChannel,
20			Transport\Frame\Method,
21			Transport\Frame\Value,
22			Transport\Frame\Value\UnsignedLongLongInteger,
23			Transport\Frame\Value\UnsignedLongInteger,
24			Transport\Frame\Value\Bits,
25			Transport\Frame\Value\ShortString,
26			Transport\Frame\Value\UnsignedShortInteger,
27			Transport\Frame\Value\Table,
28			Transport\Frame\Value\UnsignedOctet,
29			Transport\Frame\Value\Timestamp,
30			Transport\Protocol\Basic as BasicInterface,
31			Transport\Protocol\ArgumentTranslator
32			};
33			use Innmind\Math\Algebra\Integer;
34			use Innmind\Immutable\{
35			Str,
36			Map,
37			MapInterface,
38			StreamInterface,
39			Stream
40			};
41
42			final class Basic implements BasicInterface
43			{
44			private $translate;
45
46	94		public function __construct(ArgumentTranslator $translator)
47			{
48	94		$this->translate = $translator;
49	94		}
50
51	1	View Code Duplication	public function ack(FrameChannel $channel, Ack $command): Frame
			0 ignored issues – show Duplication introduced 2017-08-21 05:33 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
52			{
53	1		return Frame::command(
54	1		$channel,
55	1		Methods::get('basic.ack'),
56	1		new UnsignedLongLongInteger(new Integer($command->deliveryTag())),
57	1		new Bits($command->isMultiple())
58			);
59			}
60
61	1		public function cancel(FrameChannel $channel, Cancel $command): Frame
62			{
63	1		return Frame::command(
64	1		$channel,
65	1		Methods::get('basic.cancel'),
66	1		new ShortString(new Str($command->consumerTag())),
67	1		new Bits(!$command->shouldWait())
68			);
69			}
70
71	1	View Code Duplication	public function consume(FrameChannel $channel, Consume $command): Frame
			0 ignored issues – show Duplication introduced 2017-08-21 05:33 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
72			{
73	1		$consumerTag = '';
74
75	1		if (!$command->shouldAutoGenerateConsumerTag()) {
76	1		$consumerTag = $command->consumerTag();
77			}
78
79	1		return Frame::command(
80	1		$channel,
81	1		Methods::get('basic.consume'),
82	1		new UnsignedShortInteger(new Integer(0)), //ticket (reserved)
83	1		new ShortString(new Str($command->queue())),
84	1		new ShortString(new Str($consumerTag)),
85	1		new Bits(
86	1		!$command->isLocal(),
87	1		$command->shouldAutoAcknowledge(),
88	1		$command->isExclusive(),
89	1		!$command->shouldWait()
90			),
91	1		$this->arguments($command->arguments())
92			);
93			}
94
95	1		public function get(FrameChannel $channel, Get $command): Frame
96			{
97	1		return Frame::command(
98	1		$channel,
99	1		Methods::get('basic.get'),
100	1		new UnsignedShortInteger(new Integer(0)), //ticket (reserved)
101	1		new ShortString(new Str($command->queue())),
102	1		new Bits($command->shouldAutoAcknowledge())
103			);
104			}
105
106			/**
107			* {@inheritdoc}
108			*/
109	7		public function publish(
110			FrameChannel $channel,
111			Publish $command,
112			MaxFrameSize $maxFrameSize
113			): StreamInterface {
114	7		$frames = (new Stream(Frame::class))
115	7		->add(Frame::command(
116	7		$channel,
117	7		Methods::get('basic.publish'),
118	7		new UnsignedShortInteger(new Integer(0)), //ticket (reserved)
119	7		new ShortString(new Str($command->exchange())),
120	7		new ShortString(new Str($command->routingKey())),
121	7		new Bits(
122	7		$command->mandatory(),
123	7		$command->immediate()
124			)
125			))
126	7		->add(Frame::header(
127	7		$channel,
128	7		Methods::classId('basic'),
129	7		new UnsignedLongLongInteger(new Integer(
130	7		$command->message()->body()->length()
131			)),
132	7		...$this->serializeProperties($command->message())
133			));
134
135			//the "-8" is due to the content frame extra informations (type, channel and end flag)
136	7		$chunk = $maxFrameSize->isLimited() ? ($maxFrameSize->toInt() - 8) : $command->message()->body()->length();
137
138			return $command
139	7		->message()
140	7		->body()
141	7		->chunk($chunk)
142	7		->reduce(
143	7		$frames,
144	7		static function(Stream $frames, Str $chunk) use ($channel): Stream {
145	3		return $frames->add(Frame::body($channel, $chunk));
146	7		}
147			);
148			}
149
150	1	View Code Duplication	public function qos(FrameChannel $channel, Qos $command): Frame
			0 ignored issues – show Duplication introduced 2017-08-21 05:33 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
151			{
152	1		return Frame::command(
153	1		$channel,
154	1		Methods::get('basic.qos'),
155	1		new UnsignedLongInteger(new Integer($command->prefetchSize())),
156	1		new UnsignedShortInteger(new Integer($command->prefetchCount())),
157	1		new Bits($command->isGlobal())
158			);
159			}
160
161	1		public function recover(FrameChannel $channel, Recover $command): Frame
162			{
163	1		return Frame::command(
164	1		$channel,
165	1		Methods::get('basic.recover'),
166	1		new Bits($command->shouldRequeue())
167			);
168			}
169
170	1	View Code Duplication	public function reject(FrameChannel $channel, Reject $command): Frame
			0 ignored issues – show Duplication introduced 2017-08-21 05:33 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
171			{
172	1		return Frame::command(
173	1		$channel,
174	1		Methods::get('basic.reject'),
175	1		new UnsignedLongLongInteger(new Integer($command->deliveryTag())),
176	1		new Bits($command->shouldRequeue())
177			);
178			}
179
180	2	View Code Duplication	private function arguments(MapInterface $arguments): Table
			0 ignored issues – show Duplication introduced 2017-09-09 16:02 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
181			{
182	2		return new Table(
183	2		$arguments->reduce(
184	2		new Map('string', Value::class),
185	2		function(Map $carry, string $key, $value): Map {
186	2		return $carry->put(
187	2		$key,
188	2		($this->translate)($value)
189			);
190	2		}
191			)
192			);
193			}
194
195	7		private function serializeProperties(Message $message): array
196			{
197	7		$properties = [];
198	7		$flagBits = 0;
199
200	7		if ($message->hasContentType()) {
201	1		$properties[] = new ShortString(
202	1		new Str((string) $message->contentType())
203			);
204	1		$flagBits \|= (1 << 15);
205			}
206
207	7		if ($message->hasContentEncoding()) {
208	1		$properties[] = new ShortString(
209	1		new Str((string) $message->contentEncoding())
210			);
211	1		$flagBits \|= (1 << 14);
212			}
213
214	7		if ($message->hasHeaders()) {
215	1		$properties[] = $this->arguments($message->headers());
216	1		$flagBits \|= (1 << 13);
217			}
218
219	7		if ($message->hasDeliveryMode()) {
220	1		$properties[] = new UnsignedOctet(
221	1		new Integer($message->deliveryMode()->toInt())
222			);
223	1		$flagBits \|= (1 << 12);
224			}
225
226	7		if ($message->hasPriority()) {
227	1		$properties[] = new UnsignedOctet(
228	1		new Integer($message->priority()->toInt())
229			);
230	1		$flagBits \|= (1 << 11);
231			}
232
233	7		if ($message->hasCorrelationId()) {
234	1		$properties[] = new ShortString(
235	1		new Str((string) $message->correlationId())
236			);
237	1		$flagBits \|= (1 << 10);
238			}
239
240	7		if ($message->hasReplyTo()) {
241	1		$properties[] = new ShortString(
242	1		new Str((string) $message->replyTo())
243			);
244	1		$flagBits \|= (1 << 9);
245			}
246
247	7		if ($message->hasExpiration()) {
248	1		$properties[] = new ShortString(
249	1		new Str((string) $message->expiration()->milliseconds())
250			);
251	1		$flagBits \|= (1 << 8);
252			}
253
254	7	View Code Duplication	if ($message->hasId()) {
			0 ignored issues – show Duplication introduced 2017-09-09 16:02 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
255	1		$properties[] = new ShortString(
256	1		new Str((string) $message->id())
257			);
258	1		$flagBits \|= (1 << 7);
259			}
260
261	7		if ($message->hasTimestamp()) {
262	1		$properties[] = new Timestamp($message->timestamp());
263	1		$flagBits \|= (1 << 6);
264			}
265
266	7	View Code Duplication	if ($message->hasType()) {
			0 ignored issues – show Duplication introduced 2017-09-09 16:02 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
267	1		$properties[] = new ShortString(
268	1		new Str((string) $message->type())
269			);
270	1		$flagBits \|= (1 << 5);
271			}
272
273	7		if ($message->hasUserId()) {
274	1		$properties[] = new ShortString(
275	1		new Str((string) $message->userId())
276			);
277	1		$flagBits \|= (1 << 4);
278			}
279
280	7		if ($message->hasAppId()) {
281	1		$properties[] = new ShortString(
282	1		new Str((string) $message->appId())
283			);
284	1		$flagBits \|= (1 << 3);
285			}
286
287	7		array_unshift(
288	7		$properties,
289	7		new UnsignedShortInteger(new Integer($flagBits))
290			);
291
292	7		return $properties;
293			}
294			}
295

Innmind / AMQP

GitHub Access Token became invalid

Push — develop ( d40077...e71353 )

Basic::serializeProperties() F

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like