UnsignedOctet::fromStream() - Code Metrics - Inspection of "Performance improvement" - Innmind/AMQP - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — develop (#1)

by Baptiste

created 2019-02-10 18:30 UTC

UnsignedOctet::fromStream() A

↳ Parent: UnsignedOctet

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	2
nc	1
nop	1
dl	0
loc	5
ccs	3
cts	3
cp	1
crap	1
rs	10
c	0
b	0
f	0

<?php
declare(strict_types = 1);

namespace Innmind\AMQP\Transport\Frame\Value;

use Innmind\AMQP\{
    Transport\Frame\Value,
    Exception\OutOfRangeValue,
};
use Innmind\Math\{
    Algebra\Integer,
    DefinitionSet\Set,
    DefinitionSet\Range,
};
use Innmind\Stream\Readable;

/**
 * Same as unsigned shortshort
 */
final class UnsignedOctet implements Value
{
    private static $definitionSet;

    private $value;
    private $original;

    public function __construct(Integer $octet)
    {
        if (!self::definitionSet()->contains($octet)) {
            throw new OutOfRangeValue($octet, self::definitionSet());
        }

        $this->original = $octet;
    }

    public static function fromStream(Readable $stream): Value
    {
        [, $octet] = unpack('C', (string) $stream->read(1));

        return new self(new Integer($octet));
    }

    public function original(): Integer
    {
        return $this->original;
    }

    public function __toString(): string
    {
        return $this->value ?? $this->value = chr($this->original->value());
    }

    public static function definitionSet(): Set
    {
        return self::$definitionSet ?? self::$definitionSet = Range::inclusive(
            new Integer(0),
            new Integer(255)
        );
    }
}


1		<?php
2		declare(strict_types = 1);
3
4		namespace Innmind\AMQP\Transport\Frame\Value;
5
6		use Innmind\AMQP\{
7		Transport\Frame\Value,
8		Exception\OutOfRangeValue,
9		};
10		use Innmind\Math\{
11		Algebra\Integer,
12		DefinitionSet\Set,
13		DefinitionSet\Range,
14		};
15		use Innmind\Stream\Readable;
16
17		/**
18		* Same as unsigned shortshort
19		*/
20		final class UnsignedOctet implements Value
21		{
22		private static $definitionSet;
23
24		private $value;
25		private $original;
26
27	141	public function __construct(Integer $octet)
28		{
29	141	if (!self::definitionSet()->contains($octet)) {
30	3	throw new OutOfRangeValue($octet, self::definitionSet());
31		}
32
33	138	$this->original = $octet;
34	138	}
35
36	82	public static function fromStream(Readable $stream): Value
37		{
38	82	[, $octet] = unpack('C', (string) $stream->read(1));
39
40	82	return new self(new Integer($octet));
41		}
42
43	84	public function original(): Integer
44		{
45	84	return $this->original;
46		}
47
48	137	public function __toString(): string
49		{
50	137	return $this->value ?? $this->value = chr($this->original->value());
51		}
52
53	141	public static function definitionSet(): Set
54		{
55	141	return self::$definitionSet ?? self::$definitionSet = Range::inclusive(
56		new Integer(0),
57	141	new Integer(255)
58		);
59		}
60		}
61

Innmind / AMQP

GitHub Access Token became invalid

Pull Request — develop (#1)

UnsignedOctet::fromStream() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like