Decimal::original() - Code Metrics - Inspection of "Performance improvement" - Innmind/AMQP - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — develop (#1)

by Baptiste

created 2019-02-10 18:30 UTC

Decimal::original() A

↳ Parent: Decimal

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	0
dl	0
loc	3
ccs	2
cts	2
cp	1
crap	1
rs	10
c	0
b	0
f	0

<?php
declare(strict_types = 1);

namespace Innmind\AMQP\Transport\Frame\Value;

use Innmind\AMQP\{
    Transport\Frame\Value,
    Exception\OutOfRangeValue,
};
use Innmind\Math\{
    Algebra\Number,
    Algebra\Integer,
    DefinitionSet\Set,
    DefinitionSet\NaturalNumbers,
};
use Innmind\Stream\Readable;

final class Decimal implements Value
{
    private static $definitionSet;

    private $value;
    private $original;

    public function __construct(Integer $value, Integer $scale)
    {
        if (!self::definitionSet()->contains($scale)) {
            throw new OutOfRangeValue($scale, self::definitionSet());
        }

        $this->value = (string) new UnsignedOctet($scale);
        $this->value .= (string) new SignedLongInteger($value);
        $this->original = $value->divideBy(
            (new Integer(10))->power($scale)
        );
    }

    public static function fromStream(Readable $stream): Value
    {
        $scale = UnsignedOctet::fromStream($stream)->original();
        $value = SignedLongInteger::fromStream($stream)->original();

        return new self($value, $scale);
    }

    public function original(): Number
    {
        return $this->original;
    }

    public function __toString(): string
    {
        return $this->value;
    }

    public static function definitionSet(): Set
    {
        return self::$definitionSet ?? self::$definitionSet = new NaturalNumbers;
    }
}


1		<?php
2		declare(strict_types = 1);
3
4		namespace Innmind\AMQP\Transport\Frame\Value;
5
6		use Innmind\AMQP\{
7		Transport\Frame\Value,
8		Exception\OutOfRangeValue,
9		};
10		use Innmind\Math\{
11		Algebra\Number,
12		Algebra\Integer,
13		DefinitionSet\Set,
14		DefinitionSet\NaturalNumbers,
15		};
16		use Innmind\Stream\Readable;
17
18		final class Decimal implements Value
19		{
20		private static $definitionSet;
21
22		private $value;
23		private $original;
24
25	6	public function __construct(Integer $value, Integer $scale)
26		{
27	6	if (!self::definitionSet()->contains($scale)) {
28		throw new OutOfRangeValue($scale, self::definitionSet());
29		}
30
31	6	$this->value = (string) new UnsignedOctet($scale);
32	6	$this->value .= (string) new SignedLongInteger($value);
33	6	$this->original = $value->divideBy(
34	6	(new Integer(10))->power($scale)
35		);
36	6	}
37
38	3	public static function fromStream(Readable $stream): Value
39		{
40	3	$scale = UnsignedOctet::fromStream($stream)->original();
41	3	$value = SignedLongInteger::fromStream($stream)->original();
42
43	3	return new self($value, $scale);
44		}
45
46	5	public function original(): Number
47		{
48	5	return $this->original;
49		}
50
51	5	public function __toString(): string
52		{
53	5	return $this->value;
54		}
55
56	6	public static function definitionSet(): Set
57		{
58	6	return self::$definitionSet ?? self::$definitionSet = new NaturalNumbers;
59		}
60		}
61

Innmind / AMQP

GitHub Access Token became invalid

Pull Request — develop (#1)

Decimal::original() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like